Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-25424

From/to Hash assert on empty values are not strict enough

    Details

      Description

      See https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/FieldType/Tests/TextLineTest.php#L229

      Assert are not strict enough on type. null and '' are considered the same.

      Once assert are more accurate, failures need to be fixed en Emails, TextLine and Text blocks fieldtypes.

        Issue Links

          Activity

          Yannick Roger (Inactive) created issue -
          Yannick Roger (Inactive) made changes -
          Field Original Value New Value
          Summary From/to Hash assert on empty values are not done From/to Hash assert on empty values are not strict enough
          Description See https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/FieldType/Tests/TextLineTest.php#L229

          Assert are not strict enough on type. null and '' are considered the same.

          Once assert are more accurate, failures need to be fixed en Emails, TextLine and Text blocks fieldtypes.
          Yannick Roger (Inactive) made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Yannick Roger (Inactive) made changes -
          Status Confirmed [ 10037 ] Backlog [ 10000 ]
          Yannick Roger (Inactive) made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Yannick Roger (Inactive) made changes -
          Link This issue discovered while testing EZP-25375 [ EZP-25375 ]
          Hide
          Yannick Roger (Inactive) added a comment -

          Make sure to remove overrides added in TimeTest.php in EZP-25375 (it should be merged before this one).

          Show
          Yannick Roger (Inactive) added a comment - Make sure to remove overrides added in TimeTest.php in EZP-25375 (it should be merged before this one).
          Show
          Yannick Roger (Inactive) added a comment - - edited PR: https://github.com/ezsystems/ezpublish-kernel/pull/1567
          Yannick Roger (Inactive) made changes -
          Remote Link This issue links to "PR (Web Link)" [ 16153 ]
          Yannick Roger (Inactive) made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Yannick Roger (Inactive) made changes -
          Fix Version/s Engineering tracked issues [ 11179 ]
          Yannick Roger (Inactive) made changes -
          Affects Version/s 16.02 [ 14501 ]
          Yannick Roger (Inactive) made changes -
          Status Development Review [ 10006 ] Backlog [ 10000 ]
          Yannick Roger (Inactive) made changes -
          Assignee Yannick Roger [ yannick.roger@ez.no ]
          Yannick Roger (Inactive) made changes -
          Assignee Yannick Roger [ yannick.roger@ez.no ]
          Yannick Roger (Inactive) made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Yannick Roger (Inactive) made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Show
          Yannick Roger (Inactive) added a comment - Fixed in 6.7, 6.8, 6.9 and master: https://github.com/ezsystems/ezpublish-kernel/commit/e12904d36fd86c5ed7aecb2817d9863f6d3ddd9b
          Yannick Roger (Inactive) made changes -
          Assignee Yannick Roger [ yannick.roger@ez.no ]
          Status Development Review [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Bertrand Dunogier made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Bertrand Dunogier made changes -
          Fix Version/s 1.7.3 [ 14701 ]
          Fix Version/s 1.9.1 [ 14708 ]
          Fix Version/s 1.10.0 [ 14783 ]
          Bertrand Dunogier made changes -
          Fix Version/s 5.4.10 [ 14640 ]
          Bertrand Dunogier made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 97604 ] EZEE Development Workflow [ 125502 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          5m 19s 1 yannick.roger@ez.no 29/Jan/16 2:53 PM
          Confirmed Confirmed Backlog Backlog
          2s 1 yannick.roger@ez.no 29/Jan/16 2:53 PM
          Development Review Development Review Backlog Backlog
          52d 20h 56m 1 yannick.roger@ez.no 22/Mar/16 12:17 PM
          Backlog Backlog Development Development
          387d 1h 29m 2 yannick.roger@ez.no 13/Apr/17 2:47 PM
          Development Development Development Review Development Review
          27m 19s 2 yannick.roger@ez.no 13/Apr/17 2:47 PM
          Development Review Development Review Closed Closed
          22h 40m 1 yannick.roger@ez.no 14/Apr/17 1:28 PM
          Closed Closed Reopened Reopened
          12d 11m 1 Bertrand Dunogier 26/Apr/17 1:39 PM
          Reopened Reopened Closed Closed
          38s 1 Bertrand Dunogier 26/Apr/17 1:39 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Yannick Roger (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: