Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-25424

From/to Hash assert on empty values are not strict enough

    Details

      Description

      See https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/FieldType/Tests/TextLineTest.php#L229

      Assert are not strict enough on type. null and '' are considered the same.

      Once assert are more accurate, failures need to be fixed en Emails, TextLine and Text blocks fieldtypes.

        Issue Links

          Activity

          Hide
          Yannick Roger (Inactive) added a comment -

          Make sure to remove overrides added in TimeTest.php in EZP-25375 (it should be merged before this one).

          Show
          Yannick Roger (Inactive) added a comment - Make sure to remove overrides added in TimeTest.php in EZP-25375 (it should be merged before this one).
          Show
          Yannick Roger (Inactive) added a comment - - edited PR: https://github.com/ezsystems/ezpublish-kernel/pull/1567
          Show
          Yannick Roger (Inactive) added a comment - Fixed in 6.7, 6.8, 6.9 and master: https://github.com/ezsystems/ezpublish-kernel/commit/e12904d36fd86c5ed7aecb2817d9863f6d3ddd9b

            People

            • Assignee:
              Unassigned
              Reporter:
              Yannick Roger (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: