Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-23540

Cleanup XmlText/RichText embeds when the linked content is deleted

    Details

      Description

      When Content is deleted linked and embedded references in XmlText and RichText should be cleaned.

      FWIW Legacy Stack does not handle this problem either.

        Issue Links

          Activity

          Hide
          Petar Spanja (Inactive) added a comment -

          As stated in the description, Legacy Stack does not perform cleanup here either.
          However when editing affected content it will mark the embed as invalid and refuse publishing until it is fixed. Ref: https://github.com/ezsystems/ezpublish-legacy/pull/1102.

          The question: is automatic cleanup something we should implement, or handle it in the same way LS does?

          Show
          Petar Spanja (Inactive) added a comment - As stated in the description, Legacy Stack does not perform cleanup here either. However when editing affected content it will mark the embed as invalid and refuse publishing until it is fixed. Ref: https://github.com/ezsystems/ezpublish-legacy/pull/1102 . The question: is automatic cleanup something we should implement, or handle it in the same way LS does?
          Hide
          Bertrand Dunogier added a comment -

          I have checked, and rendering an xmltext with an embed of a deleted content will not throw an exception (as fixed by Petar in EZP-23523.

          Show
          Bertrand Dunogier added a comment - I have checked, and rendering an xmltext with an embed of a deleted content will not throw an exception (as fixed by Petar in EZP-23523 .
          Hide
          Bertrand Dunogier added a comment -

          I can on the other hand confirm that viewing a content that has an embed to a content the current user can't read does throw an exception.

          In legacy, iirc, this was handled by showing a specific text. Do we want to display nothing, like we do with deleted embeds, or handle it like legacy, that uses an embed_deleted.tpl template ?

          Show
          Bertrand Dunogier added a comment - I can on the other hand confirm that viewing a content that has an embed to a content the current user can't read does throw an exception. In legacy, iirc, this was handled by showing a specific text. Do we want to display nothing, like we do with deleted embeds, or handle it like legacy, that uses an embed_deleted.tpl template ?
          Hide
          Bertrand Dunogier added a comment - - edited

          Attempts at stories/scenarii.

          As a visitor, I expect not to get an error page when I view an XmlText embed of a deleted or trashed content.
          As a visitor, I expect to get a nice display when I view an XmlText embed of a content I can't view.
          As a developer, I expect a message to be logged when I view an XmlText embed of a deleted or trashed content.
          As a developer, I expect an informative message to be rendered when I view an XmlText of content the user can't view..
          As a developer, I expect display to be nice when previewing an XmlText embed of content anonymous does not have permissions for.
          As a developer, I want to customize what is rendered when viewing an XmlText embed of content the visitor can't view.

          Show
          Bertrand Dunogier added a comment - - edited Attempts at stories/scenarii. As a visitor, I expect not to get an error page when I view an XmlText embed of a deleted or trashed content. As a visitor, I expect to get a nice display when I view an XmlText embed of a content I can't view. As a developer, I expect a message to be logged when I view an XmlText embed of a deleted or trashed content. As a developer, I expect an informative message to be rendered when I view an XmlText of content the user can't view.. As a developer, I expect display to be nice when previewing an XmlText embed of content anonymous does not have permissions for. As a developer, I want to customize what is rendered when viewing an XmlText embed of content the visitor can't view.
          Hide
          André Rømcke added a comment -

          The issue has been changed to a Feature Improvement as after EZP-23523. Behavior of Platform stack is behaving similarly to Legacy as of EZP-23523 and the remaining request is thus changed to a change of behavior request.

          Show
          André Rømcke added a comment - The issue has been changed to a Feature Improvement as after EZP-23523 . Behavior of Platform stack is behaving similarly to Legacy as of EZP-23523 and the remaining request is thus changed to a change of behavior request.

            People

            • Assignee:
              Petar Spanja (Inactive)
              Reporter:
              Petar Spanja (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m