Uploaded image for project: 'Ibexa IBX'
  1. Ibexa IBX
  2. IBX-8237

Non-strict comparison operator causes issues when adding delivery party in v3.3 commerce

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: High High
    • Customer request
    • 3.3.37
    • Commerce
    • Ibexa Commerce
    • Yes

    Description

      https://github.com/ezsystems/ezcommerce-shop/blob/3.3/src/Silversolutions/Bundle/EshopBundle/Model/CustomerProfileData/CustomerProfileData.php#L115 - the following line causes an issue when comparing two delivery parties.

      As delivery part identification is a string (https://github.com/ezsystems/ezcommerce-shop/blob/3.3/src/Silversolutions/Bundle/EshopBundle/Entities/Messages/Document/PartyPartyIdentification.php#L25) the === operator is the only valid operator that be should during the mentioned comparison.

      Designs

        Attachments

          Activity

            People

              bartlomiej.wajda@ibexa.co Bartłomiej Wajda
              bartlomiej.wajda@ibexa.co Bartłomiej Wajda
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: