Uploaded image for project: 'Ibexa IBX'
  1. Ibexa IBX
  2. IBX-8040

Unneeded read of $blockDefinition from blockDefinitionFactory

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • Customer request
    • 4.5.6, 4.6.2
    • None
    • None
    • Ibexa Commerce, Ibexa Content, Ibexa Experience
    • Yes

    Description

      Call of $this->blockDefinitionFactory->getBlockDefinition('collection')
      in map() method seems unneeed as $blockDefinition is passed as argument.

      ibexa/fieldtype-page/src/lib/FieldType/Page/Block/Attribute/FormTypeMapper/LocationListFormTypeMapper.php
      ...
          /**
           * @param \Symfony\Component\Form\FormBuilderInterface $formBuilder
           * @param \Ibexa\Contracts\FieldTypePage\FieldType\Page\Block\Definition\BlockDefinition $blockDefinition
           * @param \Ibexa\Contracts\FieldTypePage\FieldType\Page\Block\Definition\BlockAttributeDefinition $blockAttributeDefinition
           * @param array $constraints
           *
           * @return \Symfony\Component\Form\FormBuilderInterface
           *
           * @throws \Exception
           */
          public function map(
              FormBuilderInterface $formBuilder,
              BlockDefinition $blockDefinition,
              BlockAttributeDefinition $blockAttributeDefinition,
              array $constraints = []
          ): FormBuilderInterface {
              $blockDefinition = $this->blockDefinitionFactory->getBlockDefinition('collection');
      
              $locationListAttribute = $blockDefinition->getAttributes()['locationlist'];
      
              return $formBuilder->create(
                  'value',
                  AttributeLocationListType::class,
                  [
                      'match' => $locationListAttribute->getOptions()['match'],
                      'constraints' => $constraints,
                  ]
              );
          }
      ..
      

      Designs

        Attachments

          Activity

            People

              thorsten.reiter@ibexa.co Thorsten Reiter
              thorsten.reiter@ibexa.co Thorsten Reiter
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: