Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-27092

Remove eZAutoLink operator usage of preg_replace and PREG_REPLACE_EVAL

    Details

      Description

      Remove eZAutoLink operator usage of preg_replace usage of "\e" (PREG_REPLACE_EVAL) to properly support php 5.5+ and php 7.0+

      Since PHP 5.5.x the usage of preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL) and preg_replace_callback() should be used instead. IE: Deprecation of feature usage.

      Since PHP 7.x the usage of preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL) and preg_replace_callback() must be used instead. IE: Removal of feature usage.

      Source #1, Deprecated features in PHP 5.5.x: http://php.net/manual/en/migration55.deprecated.php

      Source #2, Changed functions in PHP 7.x: http://php.net/manual/en/migration70.changed-functions.php
      Description Summary: preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL). preg_replace_callback() should be used instead.

      Our pull request will address these problems by refactoring the affected code and add phpunit tests to ensure the results remain the same through these code changes.

      Cheers,
      Brookins Consulting

        Activity

        Hide
        Brookins Consulting added a comment -

        Pull request: https://github.com/ezsystems/ezpublish-legacy/pull/1286

        Cheers,
        Brookins Consulting

        Show
        Brookins Consulting added a comment - Pull request: https://github.com/ezsystems/ezpublish-legacy/pull/1286 Cheers, Brookins Consulting
        Show
        André Rømcke added a comment - Merged: https://github.com/ezsystems/ezpublish-legacy/commit/82617a0a97748a1312ba3c970fab2374e1f5efc5
        Hide
        Paulo Nunes added a comment -

        No QA needed.
        No functional tests needed and unit tests are included.
        QA executed some sanities, just in case.

        Show
        Paulo Nunes added a comment - No QA needed. No functional tests needed and unit tests are included. QA executed some sanities, just in case.

          People

          • Assignee:
            Unassigned
            Reporter:
            Brookins Consulting
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: