Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-16059

DEPRECATED CSSFileList|JavaScriptList in favour of [Frontend|Backend][CSSFileList|JavaScriptList] settings

    XMLWordPrintable

Details

    Description

      When you use this setting, your almost always want to target either frontend (webin / flow) or backend.

      Suggestion is to have one setting for each case, and switch to new settings in admin2 + support new settings in webin/flow as well(but also use old settings there untill we remove the setting in a future version).

      Bellow is patch for eZ Publish.

      Steps to reproduce
      Index: design/admin2/templates/page_head_script.tpl
      ===================================================================
      --- design/admin2/templates/page_head_script.tpl	(revision 24656)
      +++ design/admin2/templates/page_head_script.tpl	(working copy)
      @@ -5,7 +5,7 @@
       {/if}
       
       {if $load_javascript_list}
      - {ezscript_load( ezini( 'JavaScriptSettings', 'JavaScriptList', 'design.ini' )|append( 'ezjsc::jquery' )|append( 'ezjsc::jqueryio' ) )}
      + {ezscript_load( ezini( 'JavaScriptSettings', 'BackendJavaScriptList', 'design.ini' )|append( 'ezjsc::jquery' )|append( 'ezjsc::jqueryio' ) )}
       {else}
        {ezscript_load( array( 'ezjsc::jquery', 'ezjsc::jqueryio' ) )}
       {/if}
      \ No newline at end of file
      Index: design/admin2/templates/page_head_style.tpl
      ===================================================================
      --- design/admin2/templates/page_head_style.tpl	(revision 24656)
      +++ design/admin2/templates/page_head_style.tpl	(working copy)
      @@ -22,7 +22,7 @@
       
         {* load main css files and requried css files *}
         {if $load_css_file_list}
      -    {ezcss_load( array( 'core.css', 'debug.css', 'pagelayout.css', 'content.css', $admin_theme_css, ezini( 'StylesheetSettings', 'CSSFileList', 'design.ini' ) ) )}
      +    {ezcss_load( array( 'core.css', 'debug.css', 'pagelayout.css', 'content.css', $admin_theme_css, ezini( 'StylesheetSettings', 'BackendCSSFileList', 'design.ini' ) ) )}
         {else}
           {ezcss_load( array( 'core.css', 'debug.css', 'pagelayout.css', 'content.css', $admin_theme_css ) )}
         {/if}
      Index: settings/design.ini
      ===================================================================
      --- settings/design.ini	(revision 24656)
      +++ settings/design.ini	(working copy)
      @@ -9,6 +9,7 @@
       #       in non-virtualhost modes (the .php file may already be present
       #       and can be used for this purpose).
       
      +
       [ExtensionSettings]
       # A list of extensions which have design data
       # It's common to create a settings/design.ini.append file
      @@ -16,6 +17,7 @@
       # get design from the extension when it's turned on.
       DesignExtensions[]
       
      +
       [StylesheetSettings]
       SiteCSS=stylesheets/t02/site-colors.css
       ClassesCSS=stylesheets/t02/classes-colors.css
      @@ -23,9 +25,25 @@
       # A list of CSS file to always include in the pagelayout
       # This can be filled in by extensions to provide styles
       # that are not in the standard themes.
      +# DEPRECATED in favor of [Frontend|Backend]CSSFileList[]
       CSSFileList[]
       
      +# Same as above for frontend designs
      +FrontendCSSFileList[]
      +
      +# Same as above for backend (admin) designs
      +BackendCSSFileList[]
      +
      +
       [JavaScriptSettings]
       # List of JavaScript files to include in pagelayout
      +# DEPRECATED in favor of [Frontend|Backend]JavaScriptList[]
       JavaScriptList[]
      -JavaScriptList[]=tools/ezjsselection.js
      +#JavaScriptList[]=tools/ezjsselection.js
      +
      +# Same as above for frontend designs
      +FrontendJavaScriptList[]
      +
      +# Same as above for backend (admin) designs
      +BackendJavaScriptList[]
      +BackendJavaScriptList[]=tools/ezjsselection.js
      
      

      Attachments

        Activity

          People

            andre1 andre1
            andre1 andre1
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: