Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-15645

Duplicate IDs in HTML for eZODF

    XMLWordPrintable

Details

    Description

      In the ezodf extension, the node/oocontextsubmenu.tpl template file, there are 3 elements with the HTML ID "menu-export-ooo" and 2 with the ID "menu-import-ooo". This causes the page to not validate as (X)HTML (Tidy gives warnings).

      As far as I can tell, these IDs are not really used for anything (certainly not the second and third copies, as those won't be returned by getElementById anyway).

      Suggested fix: rename these elements to match the forms they are submitting.
      That is, use the IDs "menu-export-ooo", "menu-export-pdf", "menu-export-word", "menu-import-ooo" and "menu-replace-ooo" instead of the duplicates that are used now.

      Steps to reproduce

      Open the mentioned template file and see that there are duplicate IDs.
      Or, view a page in the admin interface, and run the source through an HTML validator (such as the Html Validator extension for Firefox).

      Attachments

        Activity

          People

            unknown unknown
            edorfaus edorfaus
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated: