Details

      Description

      For accessibility reasons, "label" tags should have an attribute "for" with the id of the input field associated, example :

      <label for="ezcoa-183_name">Titre <span class="required">(required)</span>:</label>
      <input id="ezcoa-183_name" class="box ezcc-weblog ezcca-weblog_name" size="70" name="ContentObjectAttribute_ezstring_data_text_215486" value="" type="text">
      

      With this code, clicking on the label gives the focus to the input field. This behaviour is also very practical for all users.

        Activity

        Hide
        André R added a comment -

        This issue more or less requires us to make some guidelines for how id attributes should be generated since label tags often are not in the same template. That is a good thing though, among other things for JavaScript use.

        Show
        André R added a comment - This issue more or less requires us to make some guidelines for how id attributes should be generated since label tags often are not in the same template. That is a good thing though, among other things for JavaScript use.
        Hide
        André R added a comment - - edited

        Fixed in
        trunk (4.3.0alpha1) rev. 24459 (admin2 design) & 24465 + 24479 (standard design)

        Leaving open for now to look into ezwebin and ezflow, and cause there is more places this can be added in standard / admin design as well.

        Show
        André R added a comment - - edited Fixed in trunk (4.3.0alpha1) rev. 24459 (admin2 design) & 24465 + 24479 (standard design) Leaving open for now to look into ezwebin and ezflow, and cause there is more places this can be added in standard / admin design as well.
        Hide
        Damien Pobel added a comment -

        In reply to comment #046296
        Nice to see this implemented
        There are a lot of places in admin2 design (and probably in others) where at least one label still lacks the "for" attribute (I only list templates where the label is related to an input, select...) :
        design/admin2/templates/children.tpl
        design/admin2/templates/collaboration/handlers/view/full/ezapprove.tpl
        design/admin2/templates/content/edit_states.tpl
        design/admin2/templates/content/trash.tpl
        design/admin2/templates/content/urlalias_wildcard.tpl
        design/admin2/templates/package/creators/ezcontentobject/object_limit.tpl
        design/admin2/templates/package/list.tpl
        design/admin2/templates/settings/edit.tpl
        design/admin2/templates/settings/view.tpl
        design/admin2/templates/setup/datatype_basic.tpl
        design/admin2/templates/setup/datatype_describe.tpl
        design/admin2/templates/setup/session.tpl
        design/admin2/templates/setup/templateoperator_basic.tpl
        design/admin2/templates/setup/templateoperator_describe.tpl
        design/admin2/templates/state/edit.tpl
        design/admin2/templates/state/group_edit.tpl
        design/admin2/templates/url/edit.tpl
        design/admin2/templates/user/password.tpl
        design/admin2/templates/user/setting.tpl
        design/admin2/templates/workflow/edit.tpl
        design/admin2/templates/workflow/eventtype/edit/event_ezapprove.tpl
        design/admin2/templates/workflow/eventtype/edit/event_ezmultiplexer.tpl
        design/admin2/templates/workflow/eventtype/edit/event_ezpaymentgateway.tpl
        design/admin2/templates/workflow/eventtype/edit/event_ezwaituntildate.tpl
        design/admin2/templates/workflow/groupedit.tpl

        there are a lot in visual, pdf and shop templates too.

        There are also some templates where the label tag is around the input and descriptive text :
        design/admin2/templates/class/select_language.tpl
        design/admin2/templates/content/create_languages.tpl
        design/admin2/templates/content/edit_languages.tpl
        design/admin2/templates/content/edit_menu.tpl
        design/admin2/templates/content/restore.tpl
        design/admin2/templates/content/search.tpl
        design/admin2/templates/notification/handler/ezcollaboration/settings/edit.tpl
        design/admin2/templates/notification/handler/ezgeneraldigest/settings/edit.tpl

        I also notice that in 2 templates, the text related to an input is not in a label tag :
        design/admin2/templates/content/view/versionview.tpl for SelectedSiteAccess, SelectedPlacement and SelectedLanguage radio input
        design/admin2/templates/role/policyedit.tpl for DeleteSubtreeIDArray and DeleteNodeIDArray fields

        Hope that helps.

        Show
        Damien Pobel added a comment - In reply to comment #046296 Nice to see this implemented There are a lot of places in admin2 design (and probably in others) where at least one label still lacks the "for" attribute (I only list templates where the label is related to an input, select...) : design/admin2/templates/children.tpl design/admin2/templates/collaboration/handlers/view/full/ezapprove.tpl design/admin2/templates/content/edit_states.tpl design/admin2/templates/content/trash.tpl design/admin2/templates/content/urlalias_wildcard.tpl design/admin2/templates/package/creators/ezcontentobject/object_limit.tpl design/admin2/templates/package/list.tpl design/admin2/templates/settings/edit.tpl design/admin2/templates/settings/view.tpl design/admin2/templates/setup/datatype_basic.tpl design/admin2/templates/setup/datatype_describe.tpl design/admin2/templates/setup/session.tpl design/admin2/templates/setup/templateoperator_basic.tpl design/admin2/templates/setup/templateoperator_describe.tpl design/admin2/templates/state/edit.tpl design/admin2/templates/state/group_edit.tpl design/admin2/templates/url/edit.tpl design/admin2/templates/user/password.tpl design/admin2/templates/user/setting.tpl design/admin2/templates/workflow/edit.tpl design/admin2/templates/workflow/eventtype/edit/event_ezapprove.tpl design/admin2/templates/workflow/eventtype/edit/event_ezmultiplexer.tpl design/admin2/templates/workflow/eventtype/edit/event_ezpaymentgateway.tpl design/admin2/templates/workflow/eventtype/edit/event_ezwaituntildate.tpl design/admin2/templates/workflow/groupedit.tpl there are a lot in visual, pdf and shop templates too. There are also some templates where the label tag is around the input and descriptive text : design/admin2/templates/class/select_language.tpl design/admin2/templates/content/create_languages.tpl design/admin2/templates/content/edit_languages.tpl design/admin2/templates/content/edit_menu.tpl design/admin2/templates/content/restore.tpl design/admin2/templates/content/search.tpl design/admin2/templates/notification/handler/ezcollaboration/settings/edit.tpl design/admin2/templates/notification/handler/ezgeneraldigest/settings/edit.tpl I also notice that in 2 templates, the text related to an input is not in a label tag : design/admin2/templates/content/view/versionview.tpl for SelectedSiteAccess, SelectedPlacement and SelectedLanguage radio input design/admin2/templates/role/policyedit.tpl for DeleteSubtreeIDArray and DeleteNodeIDArray fields Hope that helps.
        Hide
        André R added a comment -

        Closing as implemented since 4.3.0alpha is out, need to create another issue and take the rest in a new issue.

        Show
        André R added a comment - Closing as implemented since 4.3.0alpha is out, need to create another issue and take the rest in a new issue.
        Hide
        ezrobot added a comment -

        This issue has been automatically closed due to the lack of activity over a long period of time. It is very likely that it is obsolete, but if you think it is still valid, do not hesitate to reopen it and mention why.

        Show
        ezrobot added a comment - This issue has been automatically closed due to the lack of activity over a long period of time. It is very likely that it is obsolete, but if you think it is still valid, do not hesitate to reopen it and mention why.

          People

          • Assignee:
            André R
            Reporter:
            Damien Pobel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: