Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-9558

[EmbedViewModeSettings] and [ImageDataTypeSettings] in site.ini

    Details

      Description

      Tested on OE 4.2rc (the one shipped with eZ publish 3.9rc1)

      While looking into eZ publish 3.9rc1 I discovered that OE has the following settings in extension/ezdhtml/settings/site.ini.append:

      [ImageDataTypeSettings]
      AvailableImageDataTypes[]=ezimage
       
      [EmbedViewModeSettings]
      AvailableViewModes[]=embed
      AvailableViewModes[]=embed-inline
      AvailableViewModes[]=full
      AvailableViewModes[]=line
      InlineViewModes[]=embed-inline
      

      However, these settings does not exist by default in eZ publish (in settings/site.ini). Therefore, these settings is OE spesific and should probably be located in a different .ini file?

      Also, these settings are not documented anywere (all settings in settings/site.ini is documented in the .ini file itself)

        Activity

        Hide
        Vidar Langseid added a comment -

        This issue is related to this one:
        http://issues.ez.no/IssueView.php?Id=9561

        Show
        Vidar Langseid added a comment - This issue is related to this one: http://issues.ez.no/IssueView.php?Id=9561
        Hide
        Kirill Subbotin added a comment -

        I agree. Not a good place, and good settings names. But it have been like this for years (for reasons we don't know). Can we break back-compatibility in this case?

        Also I believe that the correct place for most of these settings is eZ Publish. But again, their naming is not suitable for eZ Publish.

        Show
        Kirill Subbotin added a comment - I agree. Not a good place, and good settings names. But it have been like this for years (for reasons we don't know). Can we break back-compatibility in this case? Also I believe that the correct place for most of these settings is eZ Publish. But again, their naming is not suitable for eZ Publish.
        Hide
        Kirill Subbotin added a comment - - edited

        These setting could be moved to eZ Publish and renamed. For example:

        site.ini.appned
         
        [EmbedViewModeSettings]
        AvailableViewModes[]
        InlineViewModes[]
         
        [LinkViewModeSettings]
        AvailableViewModes[]
        

        can be converted to:

        content.ini
         
        [embed]
        AvailableViews[]
         
        [embed-inline]
        AvailableViews[]
         
        [link]
        AvailableViews[]
        

        Which is more nice in my opinion.

        I'm not sure about other settings:

        site.ini.append:
         
        [MediaClassSettings]
        ImageClassID[]
         
        [ImageDataTypeSettings]
        AvailableImageDataTypes[]
        

        Is there an application for them in eZ Publish and what is the best place for them?

        But anyway there are settings that touche only OE and they will remain there, so the issue of overriding may
        be actual for them at least.

        For now, I think it would be wise to create new settings for 3.9 and may be 3.8, BUT... not use them now.
        We can use them later when we have no need to support 3.6/3.7.

        As for now creating a new life-critical upgrade script when all the software is in RC state is not good, so we
        can post-pond it to next OE version.

        So, I think we should not remove them from OE, because just moving them to eZp without renaming has not very much sense and we can't rename them just now.

        Show
        Kirill Subbotin added a comment - - edited These setting could be moved to eZ Publish and renamed. For example: site.ini.appned   [EmbedViewModeSettings] AvailableViewModes[] InlineViewModes[]   [LinkViewModeSettings] AvailableViewModes[] can be converted to: content.ini   [embed] AvailableViews[]   [embed-inline] AvailableViews[]   [link] AvailableViews[] Which is more nice in my opinion. I'm not sure about other settings: site.ini.append:   [MediaClassSettings] ImageClassID[]   [ImageDataTypeSettings] AvailableImageDataTypes[] Is there an application for them in eZ Publish and what is the best place for them? But anyway there are settings that touche only OE and they will remain there, so the issue of overriding may be actual for them at least. For now, I think it would be wise to create new settings for 3.9 and may be 3.8, BUT... not use them now. We can use them later when we have no need to support 3.6/3.7. As for now creating a new life-critical upgrade script when all the software is in RC state is not good, so we can post-pond it to next OE version. So, I think we should not remove them from OE, because just moving them to eZp without renaming has not very much sense and we can't rename them just now.
        Hide
        Kristof Coomans added a comment -

        Also counts for [MediaClassSettings] in site.ini of ezdhtml/ezoe.

        Show
        Kristof Coomans added a comment - Also counts for [MediaClassSettings] in site.ini of ezdhtml/ezoe.
        Hide
        André R added a comment -

        Fixed in
        ezoe/trunk ( ezoe 5.0.0Beta2 ) rev. 2898 & rev. 2899

        Show
        André R added a comment - Fixed in ezoe/trunk ( ezoe 5.0.0Beta2 ) rev. 2898 & rev. 2899
        Hide
        Patrick Allaert added a comment - - edited

        Apparently, this issue has not been completely fixed.

        Section [ImageDataTypeSettings] is still defined in:
        https://github.com/ezsystems/ezoe/blob/master/settings/site.ini.append.php#L8
        while it does not exist in:
        https://github.com/ezsystems/ezpublish/blob/master/settings/site.ini

        However, other extension seems to use that setting:
        https://github.com/ezsystems/ezjscore/blob/master/classes/ezjscajaxcontent.php#L228
        https://github.com/ezsystems/ezflow/blob/master/packages/ezflow_extension/ezextension/ezflow/classes/ezflowajaxcontent.php#L161

        This has the side effect to increase the error.log in a very impressive way if using one of those extension but without enabling ezoe.
        Logs are full of:

        [ Nov 03 2011 19:28:45 ] [127.0.0.1] eZINI::variable:
        Undefined group: 'ImageDataTypeSettings' in site.ini

        A possible fix would be to remove this setting from ezoe and making it core.

        Show
        Patrick Allaert added a comment - - edited Apparently, this issue has not been completely fixed. Section [ImageDataTypeSettings] is still defined in: https://github.com/ezsystems/ezoe/blob/master/settings/site.ini.append.php#L8 while it does not exist in: https://github.com/ezsystems/ezpublish/blob/master/settings/site.ini However, other extension seems to use that setting: https://github.com/ezsystems/ezjscore/blob/master/classes/ezjscajaxcontent.php#L228 https://github.com/ezsystems/ezflow/blob/master/packages/ezflow_extension/ezextension/ezflow/classes/ezflowajaxcontent.php#L161 This has the side effect to increase the error.log in a very impressive way if using one of those extension but without enabling ezoe. Logs are full of: [ Nov 03 2011 19:28:45 ] [127.0.0.1] eZINI::variable: Undefined group: 'ImageDataTypeSettings' in site.ini A possible fix would be to remove this setting from ezoe and making it core.

          People

          • Assignee:
            Kirill Subbotin
            Reporter:
            Vidar Langseid
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: