Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-30479

Compile assets script is not working on some setups

    Details

      Description

      As rose by André Rømcke on #product-dev-platform there are multiple issues with bin/compile_assets.sh script:
      In regards to `bin/compile_assets.sh`, I’m running into a few issues on it:

      1. We have an issue on updates.ez.no where it seems to not retain execution bit on scripts in archives, it’s been a hidden issue as composer has been instructed to rather fetch ttl code from source instead for the last years.
      2. Symfony Env Logic might not be always right https://github.com/ezsystems/ezplatform/commit/07b2f7c7de02937eb3b6d0157778048d86a98d5b
      3. Will it work on Windows?

      1 and 3 is kind of an blocker, and after digging for 24h I don’t find a solution on 1 and no one to look at it further before earliest next week due to easter.

      A solution to both could be to do this in php, then execution bit is not that important. Another is to move it to a package and register it as bin script, then Composer will 1. add execution flag when symlinking it and 2. afaik composer will create some kind of windows bat proxy on windows, open question is how you make sure it’s executed via `@symfony-scripts` transparently.

        Activity

        Show
        Michał Szołtysek added a comment - - edited https://github.com/ezsystems/ezplatform/pull/393 https://github.com/ezsystems/ezplatform-core/pull/7 https://github.com/ezsystems/ezplatform/commit/606f2c61943e33599db27126b55585a5c5c690e4 (master) https://github.com/ezsystems/ezplatform-core/commit/d6bbfdee8d8d231dc2856594111fa3fff72cd646 (master)
        Hide
        Michał Szołtysek added a comment -

        QA Approved.

        Show
        Michał Szołtysek added a comment - QA Approved.

          People

          • Assignee:
            Unassigned
            Reporter:
            Maciej Kobus
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: