Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: High High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Customer request
    • Component/s: Legacy stack
    • Labels:
      None

      Description

      During the autosave, the status checks are performed (https://github.com/ezsystems/ezautosave/blob/master/classes/ezjscserverfunctionsautosave.php#L107) before the transaction begins (https://github.com/ezsystems/ezautosave/blob/master/classes/ezjscserverfunctionsautosave.php#L205). This means that if this version is published in the meantime (or archived, basically any status change) then during the transaction the status will be set back to draft, which leads to inconsistencies (no published version).

        Activity

        Gunnstein Lye created issue -
        Gunnstein Lye made changes -
        Field Original Value New Value
        Fix Version/s Customer request [ 11018 ]
        Gunnstein Lye made changes -
        Component/s Legacy stack [ 13341 ]
        Gunnstein Lye made changes -
        Description During the autosave, the status checks are performed (https://github.com/ezsystems/ezautosave/blob/master/classes/ezjscserverfunctionsautosave.php#L107) before the transaction begins (https://github.com/ezsystems/ezautosave/blob/master/classes/ezjscserverfunctionsautosave.php#L205). This means that if this version is published in the meantime (or archived, basically any status change) then during the transaction the status will be set back to draft, which leads to inconsistencies (no published version).
        Show
        Gunnstein Lye added a comment - - edited PR: https://github.com/ezsystems/ezautosave/pull/27 and https://github.com/ezsystems/ezpublish-legacy/pull/1403
        Gunnstein Lye made changes -
        Status InputQ [ 10001 ] Development [ 3 ]
        Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
        Gunnstein Lye logged work - 16/Nov/18 4:00 PM
        • Time Spent:
          1 hour
           

          .

        Gunnstein Lye made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 1 hour [ 3600 ]
        Worklog Id 68843 [ 68843 ]
        Gunnstein Lye logged work - 26/Nov/18 4:30 PM
        • Time Spent:
          1 hour, 30 minutes
           

          .

        Gunnstein Lye made changes -
        Time Spent 1 hour [ 3600 ] 2 hours, 30 minutes [ 9000 ]
        Worklog Id 68869 [ 68869 ]
        Gunnstein Lye logged work - 27/Nov/18 12:00 PM
        • Time Spent:
          6 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 2 hours, 30 minutes [ 9000 ] 1 day, 30 minutes [ 30600 ]
        Worklog Id 68872 [ 68872 ]
        Gunnstein Lye logged work - 28/Nov/18 10:00 AM
        • Time Spent:
          2 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 1 day, 30 minutes [ 30600 ] 1 day, 2 hours, 30 minutes [ 37800 ]
        Worklog Id 68873 [ 68873 ]
        Gunnstein Lye logged work - 29/Nov/18 11:00 AM
        • Time Spent:
          4 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 1 day, 2 hours, 30 minutes [ 37800 ] 1 day, 6 hours, 30 minutes [ 52200 ]
        Worklog Id 68877 [ 68877 ]
        Gunnstein Lye logged work - 30/Nov/18 10:00 AM
        • Time Spent:
          2 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 1 day, 6 hours, 30 minutes [ 52200 ] 2 days, 30 minutes [ 59400 ]
        Worklog Id 68881 [ 68881 ]
        Gunnstein Lye logged work - 03/Dec/18 4:00 PM
        • Time Spent:
          3 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 2 days, 30 minutes [ 59400 ] 2 days, 3 hours, 30 minutes [ 70200 ]
        Worklog Id 68884 [ 68884 ]
        Gunnstein Lye logged work - 04/Dec/18 4:00 PM
        • Time Spent:
          2 hours
           

          .

        Gunnstein Lye made changes -
        Time Spent 2 days, 3 hours, 30 minutes [ 70200 ] 2 days, 5 hours, 30 minutes [ 77400 ]
        Worklog Id 68888 [ 68888 ]
        Gunnstein Lye logged work - 03/Jan/19 3:30 PM
        • Time Spent:
          2 hours, 30 minutes
           

          .

        Gunnstein Lye made changes -
        Time Spent 2 days, 5 hours, 30 minutes [ 77400 ] 3 days [ 86400 ]
        Worklog Id 69123 [ 69123 ]
        Hide
        Gunnstein Lye added a comment -

        Moving to review. It is not fully complete, meaning we're not using select-for-update for all queries. That would require major rewriting, which we shouldn't do on legacy. Still I hope this improves things.

        Show
        Gunnstein Lye added a comment - Moving to review. It is not fully complete, meaning we're not using select-for-update for all queries. That would require major rewriting, which we shouldn't do on legacy. Still I hope this improves things.
        Gunnstein Lye made changes -
        Status Development [ 3 ] Development Review [ 10006 ]
        Gunnstein Lye made changes -
        Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
        Status Development Review [ 10006 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        InputQ InputQ Development Development
        7m 54s 1 Gunnstein Lye 09/Nov/18 4:34 PM
        Development Development Development Review Development Review
        58d 19h 14m 1 Gunnstein Lye 07/Jan/19 11:48 AM
        Development Review Development Review Closed Closed
        39d 2h 5m 1 Gunnstein Lye 15/Feb/19 1:54 PM

          People

          • Assignee:
            Unassigned
            Reporter:
            Gunnstein Lye
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 3 days
              3d