Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-29658

As an Editor, I want to attach links to images in RichText Editor

    Details

    • Sprint:
      [2.4] - Sprint 5
    • Story Points:
      1

      Description

      Currently, there is no way to attach links to images in RichText Editor. It could be configured as an additional button in the toolbar, similar to adding links to the highlighted text.

        Issue Links

          Activity

          Konrad Oboza created issue -
          Konrad Oboza made changes -
          Field Original Value New Value
          Description Currently, there is no way to attach links to images in RichText Editor. It could be configured as an additional button in the toolbar, similar to adding links to highlighted text. Currently, there is no way to attach links to images in RichText Editor. It could be configured as an additional button in the toolbar, similar to adding links to the highlighted text.
          Konrad Oboza made changes -
          Summary As an Editor, I want to have links on images in RichText Editor As an Editor, I want to attach links to images in RichText Editor
          Konrad Oboza made changes -
          Link This issue relates to CS-7009 [ CS-7009 ]
          Hide
          Vidar Langseid added a comment -

          FYI : The ezxmltext to richtext conversion scripts currently transform such links like this:

          ezxmltext:

          <?xml version="1.0" encoding="utf-8"?>
          <section
              xmlns:image="http://ez.no/namespaces/ezpublish3/image/"
              xmlns:xhtml="http://ez.no/namespaces/ezpublish3/xhtml/"
              xmlns:custom="http://ez.no/namespaces/ezpublish3/custom/">
              <paragraph>kake 
                  <link xhtml:title="custom title" xhtml:id="customID" url_id="8">
                      <embed view="embed" size="medium" object_id="126" custom:offset="0" custom:limit="5"/>
                  </link>
              </paragraph>
          </section>
          

          richtext:

          <?xml version="1.0" encoding="UTF-8"?>\n  
          <section
              xmlns="http://docbook.org/ns/docbook"
              xmlns:xlink="http://www.w3.org/1999/xlink"
              xmlns:ezxhtml="http://ez.no/xmlns/ezpublish/docbook/xhtml"
              xmlns:ezcustom="http://ez.no/xmlns/ezpublish/docbook/custom" version="5.0-variant ezpublish-1.0">
              <para>kake </para>
              <ezembed xlink:href="ezcontent://126" view="embed" ezxhtml:class="ez-embed-type-image">
                  <ezlink xlink:href="ezurl://8" xlink:show="none" xlink:title="custom title" xml:id="customID"/>
                  <ezconfig>
                      <ezvalue key="size">medium</ezvalue>
                      <ezvalue key="offset">0</ezvalue>
                      <ezvalue key="limit">5</ezvalue>
                  </ezconfig>
              </ezembed>
          </section>
          

          The xhtml transformations are ignoring that <ezlink> so html output does not include the links

          Show
          Vidar Langseid added a comment - FYI : The ezxmltext to richtext conversion scripts currently transform such links like this: ezxmltext: <?xml version="1.0" encoding="utf-8"?> <section xmlns:image="http://ez.no/namespaces/ezpublish3/image/" xmlns:xhtml="http://ez.no/namespaces/ezpublish3/xhtml/" xmlns:custom="http://ez.no/namespaces/ezpublish3/custom/"> <paragraph>kake <link xhtml:title="custom title" xhtml:id="customID" url_id="8"> <embed view="embed" size="medium" object_id="126" custom:offset="0" custom:limit="5"/> </link> </paragraph> </section> richtext: <?xml version="1.0" encoding="UTF-8"?>\n <section xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:ezxhtml="http://ez.no/xmlns/ezpublish/docbook/xhtml" xmlns:ezcustom="http://ez.no/xmlns/ezpublish/docbook/custom" version="5.0-variant ezpublish-1.0"> <para>kake </para> <ezembed xlink:href="ezcontent://126" view="embed" ezxhtml:class="ez-embed-type-image"> <ezlink xlink:href="ezurl://8" xlink:show="none" xlink:title="custom title" xml:id="customID"/> <ezconfig> <ezvalue key="size">medium</ezvalue> <ezvalue key="offset">0</ezvalue> <ezvalue key="limit">5</ezvalue> </ezconfig> </ezembed> </section> The xhtml transformations are ignoring that <ezlink> so html output does not include the links
          Hide
          Vidar Langseid added a comment -

          Petar Španja, Petar Španja : Any input on why you introduced the <ezlink> tag inside <ezembed> instead of simply using the docbook <link> around <ezembed: <link ...><ezembed>...</ezembed></link> ?

          Show
          Vidar Langseid added a comment - Petar Španja , Petar Španja : Any input on why you introduced the <ezlink> tag inside <ezembed> instead of simply using the docbook <link> around <ezembed : <link ...><ezembed>...</ezembed></link> ?
          Show
          Petar Španja added a comment - @ Vidar Langseid I wanted to avoid repeating mistakes from XmlText, for example see: https://github.com/ezsystems/ezplatform-xmltext-fieldtype/tree/master/tests/lib/FieldType/Converter/_fixtures/expanding AFAIR the idea was to have the link available in the embed template: https://github.com/ezsystems/ezplatform-richtext/blob/master/src/lib/eZ/RichText/Converter/Render/Embed.php#L159
          Sylvain Guittard made changes -
          Status Backlog [ 10000 ] Specification [ 10002 ]
          Assignee Sylvain Guittard [ sylvain.guittard@ez.no ]
          Sylvain Guittard made changes -
          Status Specification [ 10002 ] Specification Done [ 10003 ]
          Assignee Sylvain Guittard [ sylvain.guittard@ez.no ]
          Sylvain Guittard made changes -
          Sprint [2.4] - Sprint 3 [ 117 ]
          Sylvain Guittard made changes -
          Story Points 5
          Sylvain Guittard made changes -
          Remote Link This issue links to "Prototype (Web Link)" [ 18655 ]
          Kamil Madejski made changes -
          Link This issue relates to CS-7125 [ CS-7125 ]
          Sylvain Guittard made changes -
          Sprint [2.4] - Sprint 3 [ 117 ] [2.4] - Sprint 4 [ 118 ]
          Sylvain Guittard made changes -
          Rank Ranked lower
          Dariusz Szut made changes -
          Assignee Dariusz Szut [ dariusz.szut@ez.no ]
          Dariusz Szut made changes -
          Status Specification Done [ 10003 ] Development [ 3 ]
          Sylvain Guittard made changes -
          Story Points 5 1
          Sylvain Guittard made changes -
          Sprint [2.4] - Sprint 4 [ 118 ] [2.4] - Sprint 5 [ 119 ]
          Sylvain Guittard made changes -
          Rank Ranked higher
          Andrzej Longosz made changes -
          Status Development [ 3 ] Development Done [ 5 ]
          Fix Version/s 2.4.0-beta1 [ 15089 ]
          Dominika Kurek made changes -
          Status Development Done [ 5 ] QA [ 10008 ]
          Katarzyna Zawada made changes -
          Status QA [ 10008 ] QA Done [ 10007 ]
          Assignee Dariusz Szut [ dariusz.szut@ez.no ]
          Hide
          Katarzyna Zawada added a comment -

          QA Approved.

          Show
          Katarzyna Zawada added a comment - QA Approved.
          Show
          Andrzej Longosz added a comment - Merges: ezsystems/ezplatform-admin-ui#726 merged into master as ezsystems/ezplatform-admin-ui@59c6341 ezsystems/ezpublish-kernel#2492 merged into master as ezsystems/ezpublish-kernel@4ab79de ezsystems/ezplatform-richtext#20 merged into master as ezsystems/ezplatform-richtext@c4aa555
          Andrzej Longosz made changes -
          Status QA Done [ 10007 ] Closed [ 6 ]
          Resolution Done [ 9 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Backlog Backlog Specification Specification
          45d 5h 43m 1 Sylvain Guittard 05/Nov/18 4:06 PM
          Specification Specification Specification Done Specification Done
          6s 1 Sylvain Guittard 05/Nov/18 4:06 PM
          Specification Done Specification Done Development Development
          14d 15h 55m 1 Dariusz Szut 20/Nov/18 8:02 AM
          Development Development Development Done Development Done
          13d 3h 50m 1 Andrzej Longosz 03/Dec/18 11:53 AM
          Development Done Development Done QA QA
          4h 1 Dominika Kurek 03/Dec/18 3:53 PM
          QA QA QA Done QA Done
          22h 53m 1 Katarzyna Zawada 04/Dec/18 2:47 PM
          QA Done QA Done Closed Closed
          20h 10m 1 Andrzej Longosz 05/Dec/18 10:57 AM

            People

            • Assignee:
              Unassigned
              Reporter:
              Konrad Oboza
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile