Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-29559

Delete sleeping requirement for non-empty roles

    Details

      Description

      The kernel contains bits of code that is commented because it has been waiting for role policy editing to be implemented. This is present now, so the code should be uncommented and tested.

      API team decided this is not worth it - so much code has been written not taking this into account, and it will require big rewrites without a big benefit, so it's better to axe the sleeping code.

      Example: https://github.com/ezsystems/ezpublish-kernel/blame/47fb0c14beadffedcdc03b4f9706efff5e8c184f/eZ/Publish/Core/Repository/RoleService.php#L536

      Role policy editing: https://jira.ez.no/browse/EZP-24711 and https://jira.ez.no/browse/EZP-24713

        Issue Links

          Activity

          Gunnstein Lye created issue -
          Gunnstein Lye made changes -
          Field Original Value New Value
          Link This issue relates to EZP-24713 [ EZP-24713 ]
          Gunnstein Lye made changes -
          Link This issue relates to EZP-24711 [ EZP-24711 ]
          Gunnstein Lye made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Gunnstein Lye made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Gunnstein Lye made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Gunnstein Lye made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Gunnstein Lye made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 1 hour [ 3600 ]
          Worklog Id 69150 [ 69150 ]
          Gunnstein Lye made changes -
          Time Spent 1 hour [ 3600 ] 2 hours, 30 minutes [ 9000 ]
          Worklog Id 69153 [ 69153 ]
          Gunnstein Lye made changes -
          Time Spent 2 hours, 30 minutes [ 9000 ] 5 hours [ 18000 ]
          Worklog Id 69156 [ 69156 ]
          Gunnstein Lye made changes -
          Summary Uncomment sleeping code for role policy editing Delete sleeping requirement for non-empty roles
          Gunnstein Lye made changes -
          Description The kernel contains bits of code that is commented because it has been waiting for role policy editing to be implemented. This is present now, so the code should be uncommented and tested.

          Example: https://github.com/ezsystems/ezpublish-kernel/blame/47fb0c14beadffedcdc03b4f9706efff5e8c184f/eZ/Publish/Core/Repository/RoleService.php#L536

          More: https://github.com/ezsystems/ezpublish-kernel/commit/34c01342c84792e7c2ae70b111310e9af367849b

          Role policy editing: https://jira.ez.no/browse/EZP-24711 and https://jira.ez.no/browse/EZP-24713
          -The kernel contains bits of code that is commented because it has been waiting for role policy editing to be implemented. This is present now, so the code should be uncommented and tested.-

          API team decided this is not worth it - so much code has been written not taking this into account, and it will require big rewrites without a big benefit, so it's better to axe the sleeping code.

          Example: https://github.com/ezsystems/ezpublish-kernel/blame/47fb0c14beadffedcdc03b4f9706efff5e8c184f/eZ/Publish/Core/Repository/RoleService.php#L536

          Role policy editing: https://jira.ez.no/browse/EZP-24711 and https://jira.ez.no/browse/EZP-24713
          Gunnstein Lye made changes -
          Time Spent 5 hours [ 18000 ] 6 hours [ 21600 ]
          Worklog Id 69158 [ 69158 ]
          Gunnstein Lye made changes -
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Status Development Review [ 10006 ] Closed [ 6 ]
          Fix Version/s 1.7.9 [ 15015 ]
          Fix Version/s 1.13.5 [ 15016 ]
          Fix Version/s 2.3.3 [ 15096 ]
          Fix Version/s 2.4.1 [ 15101 ]
          Fix Version/s 2.5.0 [ 15104 ]
          Resolution Done [ 9 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Gunnstein Lye
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours
                6h