Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-29258

Convertion of Embeds with links from ezxmltext to richtext is broken

    Details

      Description

      This is regression caused by the fix of EZP-26962

      The following tests are failing in ezpublish-kernel ( requires ezplatform-xmltext-fieldtype bundle to be installed too ):

      ezpublish-kernel$ vendor/bin/phpunit --filter EzxmlToDocbookTest::testConvert
      2) eZ\Publish\Core\FieldType\Tests\RichText\Converter\Xslt\EzxmlToDocbookTest::testConvert with data set #26 ('/var/www/external/ezpublish-k...ed.xml', '/var/www/external/ezpublish-k...ed.xml')
      Failed asserting that two DOM documents are equal.
      Input file: /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/027-linkedEmbed.xml
      Output file /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/docbook/027-linkedEmbed.xml
      Failed asserting that two DOM documents are equal.
      --- Expected
      +++ Actual
      @@ @@
       <?xml version="1.0"?>
       <section xmlns="http://docbook.org/ns/docbook" xmlns:ezcustom="http://ez.no/xmlns/ezpublish/docbook/custom" xmlns:ezxhtml="http://ez.no/xmlns/ezpublish/docbook/xhtml" xmlns:xlink="http://www.w3.org/1999/xlink" version="5.0-variant ezpublish-1.0">
         <ezembed view="embed" ezxhtml:align="left" ezxhtml:class="embed-class" xlink:href="ezcontent://106" xml:id="embed-id-1">
      -    <ezlink ezxhtml:class="link-class" xlink:href="ezurl://95#fragment1" xlink:show="new" xlink:title="link title" xml:id="link-id-1"/>
      +    <ezlink ezxhtml:class="link-class" xlink:title="link title" xml:id="link-id-1"/>
           <ezconfig>
             <ezvalue key="size">medium</ezvalue>
             <ezvalue key="offset">10</ezvalue>
       
      /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/BaseTest.php:118
       
      3) eZ\Publish\Core\FieldType\Tests\RichText\Converter\Xslt\EzxmlToDocbookTest::testConvert with data set #35 ('/var/www/external/ezpublish-k...ml.xml', '/var/www/external/ezpublish-k...ok.xml')
      Failed asserting that two DOM documents are equal.
      Input file: /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/104-expandAndLinkEmbed.ezxml.xml
      Output file /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/104-expandAndLinkEmbed.docbook.xml
      Failed asserting that two DOM documents are equal.
      --- Expected
      +++ Actual
      @@ @@
           <link xlink:href="ezurl://72" xlink:show="none">hello </link>
         </para>
         <ezembed view="embed" xlink:href="ezcontent://110">
      -    <ezlink xlink:href="ezurl://72" xlink:show="none"/>
           <ezconfig>
             <ezvalue key="size">medium</ezvalue>
             <ezvalue key="offset">0</ezvalue>
       
      /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/BaseTest.php:118
       
      4) eZ\Publish\Core\FieldType\Tests\RichText\Converter\Xslt\EzxmlToDocbookTest::testConvert with data set #36 ('/var/www/external/ezpublish-k...ml.xml', '/var/www/external/ezpublish-k...ok.xml')
      Failed asserting that two DOM documents are equal.
      Input file: /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/105-expandAndLinkEmbedWrapped.ezxml.xml
      Output file /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/105-expandAndLinkEmbedWrapped.docbook.xml
      Failed asserting that two DOM documents are equal.
      --- Expected
      +++ Actual
      @@ @@
         <para ezxhtml:class="grass">
           i<emphasis>have<link xlink:href="ezurl://73" xlink:show="none">no<emphasis role="strong">idea</emphasis></link></emphasis></para>
         <ezembed view="embed" xlink:href="ezcontent://106">
      -    <ezlink xlink:href="ezurl://73" xlink:show="none"/>
           <ezconfig>
             <ezvalue key="size">medium</ezvalue>
             <ezvalue key="offset">0</ezvalue>
       
      /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/BaseTest.php:118
       
      5) eZ\Publish\Core\FieldType\Tests\RichText\Converter\Xslt\EzxmlToDocbookTest::testConvert with data set #37 ('/var/www/external/ezpublish-k...ml.xml', '/var/www/external/ezpublish-k...ok.xml')
      Failed asserting that two DOM documents are equal.
      Input file: /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/106-expandAndLinkEmbedDoubleWrapped.ezxml.xml
      Output file /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/106-expandAndLinkEmbedDoubleWrapped.docbook.xml
      Failed asserting that two DOM documents are equal.
      --- Expected
      +++ Actual
      @@ @@
         <para>
           why<emphasis>be<link xlink:href="ezurl://73" xlink:show="none">dumb<emphasis role="strong">if you've</emphasis></link></emphasis></para>
         <ezembed view="embed" xlink:href="ezcontent://106">
      -    <ezlink xlink:href="ezurl://73" xlink:show="none"/>
           <ezconfig>
             <ezvalue key="size">medium</ezvalue>
             <ezvalue key="offset">0</ezvalue>
       
      /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/BaseTest.php:118
       
      6) eZ\Publish\Core\FieldType\Tests\RichText\Converter\Xslt\EzxmlToDocbookTest::testConvert with data set #38 ('/var/www/external/ezpublish-k...ml.xml', '/var/www/external/ezpublish-k...ok.xml')
      Failed asserting that two DOM documents are equal.
      Input file: /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/107-expandAndLinkEmbedDoubleWrapped2.ezxml.xml
      Output file /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/_fixtures/ezxml/lossy/107-expandAndLinkEmbedDoubleWrapped2.docbook.xml
      Failed asserting that two DOM documents are equal.
      --- Expected
      +++ Actual
      @@ @@
           <link xlink:href="ezurl://73" xlink:show="none">don't come in<emphasis role="strong">again like that,<emphasis role="strong">it isn't funny</emphasis></emphasis></link>
         </para>
         <ezembed view="embed" xlink:href="ezcontent://106">
      -    <ezlink xlink:href="ezurl://73" xlink:show="none"/>
           <ezconfig>
             <ezvalue key="size">medium</ezvalue>
             <ezvalue key="offset">0</ezvalue>
       
      /var/www/external/ezpublish-kernel/eZ/Publish/Core/FieldType/Tests/RichText/Converter/Xslt/BaseTest.php:118
      

        Issue Links

          Activity

          Show
          Vidar Langseid added a comment - PR : https://github.com/ezsystems/ezplatform-xmltext-fieldtype/pull/43

            People

            • Assignee:
              Unassigned
              Reporter:
              Vidar Langseid
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: