Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-28161

Update php-cs-fixer configuration to align with v2.7.1

    XMLWordPrintable

Details

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: High High
    • 1.13.0, 2.0.0
    • 1.7.5
    • None
    • None

    Description

      This is cross-package issue for public packages.

      We need to make sure php-cs-fixer configuration is updated according to rules introduced in v2.7.1 as this is what we use now for CI.

      While handling this, it's worth to:

      • explore a possibility of making require-dev dependency on friendsofphp/php-cs-fixer:~2.7.1 so developers can know which version to align with.
      • if the above succeeds, then add composer fix-cs command to simplify fixing code even more

      Note that this might not be possible due to symfony/console <3.2 constraints in some packages, however if it works, proper solution is already known and identical for all packages.

      List of affected public packages:

      • ezsystems/comments-bundle
      • ezsystems/content-on-the-fly-prototype
      • ezsystems/ezplatform-design-engine
      • ezsystems/ezplatform-http-cache (no .php_cs yet, might require more work)
      • ezsystems/ezplatform-multi-file-upload
      • ezsystems/ezplatform-solr-search-engine
      • ezsystems/ezpublish-kernel
      • ezsystems/ez-support-tools (no .php_cs yet, might require more work)
      • ezsystems/platform-ui-bundle
      • ezsystems/recommendation-bundle
      • ezsystems/repository-forms
      • ezsystems/share-buttons-bundle
      • ezsystems/ezplatform-admin-ui

      Note that for some repositories the changes were already made.

      Attachments

        Activity

          People

            Unassigned Unassigned
            andrew.longosz@ibexa.co Andrew Longosz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours
                1d 5h