Details

    • Type: Bug Bug
    • Status: InputQ
    • Priority: High High
    • Resolution: Unresolved
    • Affects Version/s: 1.8.1, 1.9.0, 1.7.3
    • Fix Version/s: 1.9.1, 1.7.4, 1.10.0
    • Component/s: Platform > MVC
    • Labels:
      None

      Description

      When using the view system, it is now possible to add arbitrary parameters. However it is currently possible to replace an existing one as BaseView::addParameters() uses + union operator and does not expose a setter.

        Issue Links

          Activity

          Jérôme Vieilledent created issue -
          Show
          Jérôme Vieilledent added a comment - - edited PR: https://github.com/ezsystems/ezpublish-kernel/pull/1976 Related issue in EzCoreExtraBundle: https://github.com/lolautruche/EzCoreExtraBundle/issues/23
          Jérôme Vieilledent made changes -
          Field Original Value New Value
          Remote Link Cette demande est liée à "PR (Lien Web)" [ 17593 ]
          Jérôme Vieilledent made changes -
          Remote Link Cette demande est liée à "Related issue in EzCoreExtraBundle (Lien Web)" [ 17594 ]
          Hide
          Bertrand Dunogier added a comment -
          Show
          Bertrand Dunogier added a comment - PR https://github.com/ezsystems/ezpublish-kernel/pull/1976 merged to 6.7, 6.9 and master.
          Bertrand Dunogier made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Bertrand Dunogier made changes -
          Status Confirmed [ 10037 ] Backlog [ 10000 ]
          Bertrand Dunogier made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Bertrand Dunogier made changes -
          Status Development Review [ 10006 ] Documentation Review done [ 10011 ]
          Fix Version/s 1.9.1 [ 14708 ]
          Fix Version/s 1.7.4 [ 14711 ]
          Fix Version/s 1.10.0 [ 14783 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Rui Silva (Inactive) made changes -
          Status Documentation Review done [ 10011 ] QA [ 10008 ]
          Hide
          Rui Silva (Inactive) added a comment -

          QA needs a practical use case scenario to test this.
          Can someone please provide one?
          Thank you.

          Show
          Rui Silva (Inactive) added a comment - QA needs a practical use case scenario to test this. Can someone please provide one? Thank you.
          Rui Silva (Inactive) made changes -
          Status QA [ 10008 ] InputQ [ 10001 ]
          Assignee Rui Silva [ rui.silva@ez.no ]
          Hide
          Bertrand Dunogier added a comment -

          [~rui.silva@ez.no] did you open the pull-requests ?

          Show
          Bertrand Dunogier added a comment - [~rui.silva@ez.no] did you open the pull-requests ?
          Hide
          Rui Silva (Inactive) added a comment -

          Bertrand Dunogier, yes, the PR did not include much more info that could be useful for QA tests though, than the description of this jira itself.
          As a matter of fact, we didn't quite understand the purpose of it:
          is it to test that we CAN actually replace an existing parameter or to add an arbitrary one, or both? The description seems clear "Cannot override view parameters" ( = can't replace), but it is referred "However it is currently possible to replace an existing one (...)" ( = can replace).
          However I did just read your latest comment on the PR, and seems somehow our doubts were justified
          And which simplest parameter configuration could one perhaps test this with?
          Thanks.

          Show
          Rui Silva (Inactive) added a comment - Bertrand Dunogier , yes, the PR did not include much more info that could be useful for QA tests though, than the description of this jira itself. As a matter of fact, we didn't quite understand the purpose of it: is it to test that we CAN actually replace an existing parameter or to add an arbitrary one, or both? The description seems clear "Cannot override view parameters" ( = can't replace), but it is referred "However it is currently possible to replace an existing one (...)" ( = can replace). However I did just read your latest comment on the PR, and seems somehow our doubts were justified And which simplest parameter configuration could one perhaps test this with? Thanks.
          Damien Pobel (Inactive) made changes -
          Rank Ranked lower
          Damien Pobel (Inactive) made changes -
          Rank Ranked lower
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 103733 ] EZEE Development Workflow [ 108173 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          3d 19h 23m 1 Bertrand Dunogier 09/May/17 12:08 PM
          Confirmed Confirmed Backlog Backlog
          4s 1 Bertrand Dunogier 09/May/17 12:08 PM
          Backlog Backlog Development Development
          6s 1 Bertrand Dunogier 09/May/17 12:08 PM
          Development Development Development Review Development Review
          3s 1 Bertrand Dunogier 09/May/17 12:08 PM
          Development Review Development Review Documentation Review done Documentation Review done
          14s 1 Bertrand Dunogier 09/May/17 12:08 PM
          Documentation Review done Documentation Review done QA QA
          22h 42m 1 rui.silva@ez.no 10/May/17 10:51 AM
          QA QA InputQ InputQ
          5d 22h 24m 1 rui.silva@ez.no 16/May/17 9:15 AM

            People

            • Assignee:
              Unassigned
              Reporter:
              Jérôme Vieilledent
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: