Details

      Description

      If possible, the interface should be translated in the preferred languages send by the browser. At the moment, the main language of the matched siteaccess is used with a fallback on "en".

      This involves several changes:

      1. shell.html.twig should load the translations configured in the browser
      2. Y.eZ.trans() should be more than a shortcut to Translator.trans(), it should iterate over the languages to find the best translation
      3. the same strategy should be applied to what is generated server side (pjax) EZP-26600
      1. browser window full.jpg
        284 kB
      2. browser window full 2.jpg
        353 kB
      3. greek vs french chrome.jpg
        266 kB
      4. loading app greek.jpg
        69 kB
      5. platformui greek.jpg
        255 kB

        Issue Links

          Activity

          Hide
          Damien Pobel (Inactive) added a comment -

          Again merged before testing...

          Merged in https://github.com/ezsystems/PlatformUIBundle/commit/9cdbe80fec650da33c1abc973aa63fdd6801059d

          @QA to test that, you need to configure your browser in a language different add some translations in that language.

          Show
          Damien Pobel (Inactive) added a comment - Again merged before testing... Merged in https://github.com/ezsystems/PlatformUIBundle/commit/9cdbe80fec650da33c1abc973aa63fdd6801059d @QA to test that, you need to configure your browser in a language different add some translations in that language.
          Hide
          Rui Silva (Inactive) added a comment -

          I've managed to successfully reproduce this on Edge and Firefox, using French language.
          However, on Chrome (using version 54.0), I've configured it to use French language as the other browsers, and when I load platformui interface, it displays almost everything in Greek.

          Show
          Rui Silva (Inactive) added a comment - I've managed to successfully reproduce this on Edge and Firefox, using French language. However, on Chrome (using version 54.0), I've configured it to use French language as the other browsers, and when I load platformui interface, it displays almost everything in Greek.
          Hide
          Rui Silva (Inactive) added a comment -

          Sending back to dev-needed, as the patch is not working, for when using Chrome.

          Show
          Rui Silva (Inactive) added a comment - Sending back to dev-needed, as the patch is not working, for when using Chrome.
          Hide
          Bertrand Dunogier added a comment -

          For what it's worth, i'm using chrome, configured with french as the first language, and PlatformUI does show up elements in french, not in greek.

          Show
          Bertrand Dunogier added a comment - For what it's worth, i'm using chrome, configured with french as the first language, and PlatformUI does show up elements in french, not in greek.
          Hide
          Rui Silva (Inactive) added a comment -

          As seen from the screenshots I attached to this jira, with Chrome configured in French, platformui is still showing Greek translation.

          Show
          Rui Silva (Inactive) added a comment - As seen from the screenshots I attached to this jira, with Chrome configured in French, platformui is still showing Greek translation.
          Hide
          Damien Pobel (Inactive) added a comment -

          not sure it's greek but anyway, could you please add a screenshot of the whole window (including the URL) bar also, I would be interested in a screenshot of chrome://settings/languages

          Show
          Damien Pobel (Inactive) added a comment - not sure it's greek but anyway, could you please add a screenshot of the whole window (including the URL) bar also, I would be interested in a screenshot of chrome://settings/languages
          Hide
          Rui Silva (Inactive) added a comment - - edited

          Added those screenshots [~damien.pobel@ez.no].
          Weird enough, but it seems the problem is whether on Chrome or Chrome's Language Pack "French", because I just noticed that ezplatform interface is not the only content being translated onto Greek, but rather every content on any page I access translates to Greek.
          On another environment, QA can conclude that the French language is being correctly shown as well on Chrome as on other browsers.

          Show
          Rui Silva (Inactive) added a comment - - edited Added those screenshots [~damien.pobel@ez.no] . Weird enough, but it seems the problem is whether on Chrome or Chrome's Language Pack "French", because I just noticed that ezplatform interface is not the only content being translated onto Greek, but rather every content on any page I access translates to Greek. On another environment, QA can conclude that the French language is being correctly shown as well on Chrome as on other browsers.
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for master, on Chrome, Firefox and Edge.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for master, on Chrome, Firefox and Edge.
          Hide
          Damien Pobel (Inactive) added a comment -

          This is what I thought, the page is automatically translated with Google Translate service (notice the small icon in the URL bar)... If you disable that, you should see the normal result.

          Show
          Damien Pobel (Inactive) added a comment - This is what I thought, the page is automatically translated with Google Translate service (notice the small icon in the URL bar)... If you disable that, you should see the normal result.

            People

            • Assignee:
              Unassigned
              Reporter:
              Damien Pobel (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: