Details

      Description

      Same as EZP-25821, EZP-25822 and EZP-25861 but with the quality standards of PlatformUI so with the units tests, CS, comments, ...

      Also no need for the prototype bundle prefix everywhere.

        Activity

        Show
        Stéphane Diot added a comment - PR: https://github.com/ezsystems/PlatformUIBundle/pull/659
        Hide
        Stéphane Diot added a comment - - edited

        Merged in : https://github.com/ezsystems/PlatformUIBundle/commit/652354077ae72335d3657dcc0ef3a5bd5a68d81a into feature/ezp-25979-search

        @QA The search feature is now functionnaly done (only style to finish, but you can test it).

        Show
        Stéphane Diot added a comment - - edited Merged in : https://github.com/ezsystems/PlatformUIBundle/commit/652354077ae72335d3657dcc0ef3a5bd5a68d81a into feature/ezp-25979-search @QA The search feature is now functionnaly done (only style to finish, but you can test it).
        Hide
        Paulo Nunes (Inactive) added a comment -

        @QA The search feature is now functionnaly done (only style to finish, but you can test it).

        Some issues are still occurring if we test Search functionalities on the git branches you are working in, so full tests can only be done after the merge. Example of that is EZP-26130, that is present in your branch, but it's fixed on master.

        Show
        Paulo Nunes (Inactive) added a comment - @QA The search feature is now functionnaly done (only style to finish, but you can test it). Some issues are still occurring if we test Search functionalities on the git branches you are working in, so full tests can only be done after the merge. Example of that is EZP-26130 , that is present in your branch, but it's fixed on master.
        Hide
        Paulo Nunes (Inactive) added a comment - - edited

        Stéphane Diot: When I try to test the search feature, I have one issue that doesn't happen outside your branch. When I
        -Open the developer tools from your browser
        -Go to "eZ Platform" location
        -Create one folder
        -After the creation of the folder, on the folder's view, click "eZ Platform" link from the breadcrumb
        -I'm not directed to "eZ Platform" and I'll have an infinite spinning well.
        -The following JavaScript error appears on developer tools:

        TypeError: this.get(...).one(...) is null
        http://ezp.paulo/_ezcombo?/bundles/ezplatformui/js/extensions/ez-tabs.js&/tpl/handlebars/subitemboxview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitembaseview.js&/bundles/ezplatformui/js/extensions/ez-loadmorepagination.js&/bundles/ezplatformui/js/views/subitem/ez-asynchronoussubitemview.js&/tpl/handlebars/subitemlistitemview-ez-template.js&/tpl/handlebars/subitemlistitem-name-ez-template.js&/tpl/handlebars/subitemlistitem-priority-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemlistitemview.js&/tpl/handlebars/subitemlistmoreview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemlistmoreview.js&/tpl/handlebars/subitemgriditemview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemgriditemview.js&/tpl/handlebars/subitemgridview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemgridview.js&/bundles/ezplatformui/js/views/ez-subitemboxview.js&/tpl/handlebars/locationviewview-ez-template.js&/bundles/ezplatformui/js/views/ez-locationviewview.js
        Line 453
        

        As I said above, this only happens in your branch, not on master.

        Show
        Paulo Nunes (Inactive) added a comment - - edited Stéphane Diot : When I try to test the search feature, I have one issue that doesn't happen outside your branch. When I -Open the developer tools from your browser -Go to "eZ Platform" location -Create one folder -After the creation of the folder, on the folder's view, click "eZ Platform" link from the breadcrumb -I'm not directed to "eZ Platform" and I'll have an infinite spinning well. -The following JavaScript error appears on developer tools: TypeError: this.get(...).one(...) is null http://ezp.paulo/_ezcombo?/bundles/ezplatformui/js/extensions/ez-tabs.js&/tpl/handlebars/subitemboxview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitembaseview.js&/bundles/ezplatformui/js/extensions/ez-loadmorepagination.js&/bundles/ezplatformui/js/views/subitem/ez-asynchronoussubitemview.js&/tpl/handlebars/subitemlistitemview-ez-template.js&/tpl/handlebars/subitemlistitem-name-ez-template.js&/tpl/handlebars/subitemlistitem-priority-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemlistitemview.js&/tpl/handlebars/subitemlistmoreview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemlistmoreview.js&/tpl/handlebars/subitemgriditemview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemgriditemview.js&/tpl/handlebars/subitemgridview-ez-template.js&/bundles/ezplatformui/js/views/subitem/ez-subitemgridview.js&/bundles/ezplatformui/js/views/ez-subitemboxview.js&/tpl/handlebars/locationviewview-ez-template.js&/bundles/ezplatformui/js/views/ez-locationviewview.js Line 453 As I said above, this only happens in your branch, not on master.
        Hide
        Damien Pobel (Inactive) added a comment -

        Stéphane Diot can you have a look at that please ?

        Show
        Damien Pobel (Inactive) added a comment - Stéphane Diot can you have a look at that please ?
        Hide
        Stéphane Diot added a comment -

        Paulo Nunes the feature branch is now updated and should be working.
        PR of the feature branch on master : https://github.com/ezsystems/PlatformUIBundle/pull/676

        Show
        Stéphane Diot added a comment - Paulo Nunes the feature branch is now updated and should be working. PR of the feature branch on master : https://github.com/ezsystems/PlatformUIBundle/pull/676
        Hide
        Rui Silva (Inactive) added a comment -

        Tested and approved by QA for master.

        Show
        Rui Silva (Inactive) added a comment - Tested and approved by QA for master.

          People

          • Assignee:
            Unassigned
            Reporter:
            Damien Pobel (Inactive)
          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: