Details

      Description

      Basically the same as EZP-25820 but done in a core way (ie no special prefix, the action id should be search, with unit tests, ...)

        Issue Links

          Activity

          Show
          Stéphane Diot added a comment - PR: https://github.com/ezsystems/PlatformUIBundle/pull/637
          Show
          Stéphane Diot added a comment - Merged: https://github.com/ezsystems/PlatformUIBundle/commit/7499d83c1f83d4edccdfeae1dc403123822d0aab
          Hide
          Rui Silva (Inactive) added a comment -

          Stéphane Diot, I attached a screenshot of what I see when I click on Search on the Discovery Bar. I have the fix on a recent master installation and I did dump the assets.
          Is it how it is supposed to show currently?
          If not, any ideas as to why it shows so weird?
          Thanks.

          Show
          Rui Silva (Inactive) added a comment - Stéphane Diot , I attached a screenshot of what I see when I click on Search on the Discovery Bar. I have the fix on a recent master installation and I did dump the assets. Is it how it is supposed to show currently? If not, any ideas as to why it shows so weird? Thanks.
          Hide
          Rui Silva (Inactive) added a comment -
          Show
          Rui Silva (Inactive) added a comment - ping Stéphane Diot .
          Hide
          Paulo Nunes (Inactive) added a comment - - edited

          Stéphane Diot
          As requested by [~rui.silva@ez.no], I tried the same steps
          Steps I have done:

          • Installed master
            $ php -d memory_limit=-1 composer.phar create-project --prefer-source ezsystems/ezplatform ezplatform dev-master
          • Checkout to feature/ezp-25979-search branch
            $ git checkout -b ezp-25979-search --track origin/feature/ezp-25979-search
          • Executed the assetic dump
            $ php app/console assetic:dump --env=prod
          • Clear caches, including browser ones

          In the end, when I clicked "Search" button from Discovery Bar, I had the same result as [~rui.silva@ez.no] (see screenshot previously attached by Rui)

          Question: what is supposed to be the scope of this story? Just to add the "search" button or something else more?

          Show
          Paulo Nunes (Inactive) added a comment - - edited Stéphane Diot As requested by [~rui.silva@ez.no] , I tried the same steps Steps I have done: Installed master $ php -d memory_limit=-1 composer.phar create-project --prefer-source ezsystems/ezplatform ezplatform dev-master Checkout to feature/ezp-25979-search branch $ git checkout -b ezp-25979-search --track origin/feature/ezp-25979-search Executed the assetic dump $ php app/console assetic:dump --env=prod Clear caches, including browser ones In the end, when I clicked "Search" button from Discovery Bar, I had the same result as [~rui.silva@ez.no] (see screenshot previously attached by Rui) Question: what is supposed to be the scope of this story? Just to add the "search" button or something else more?
          Hide
          Rui Silva (Inactive) added a comment -

          On lack or explanatory steps and due to odd results while testing (as explained above in previous comments), I'm sending this back to dev-needed.

          Show
          Rui Silva (Inactive) added a comment - On lack or explanatory steps and due to odd results while testing (as explained above in previous comments), I'm sending this back to dev-needed.
          Hide
          Stéphane Diot added a comment -

          Sorry was on vacation while you were testing it, that's why I wasn't answering. The scope of the story, (as mentionned in the PR) is only to add the button and the route, so your result is normal.

          Show
          Stéphane Diot added a comment - Sorry was on vacation while you were testing it, that's why I wasn't answering. The scope of the story, (as mentionned in the PR) is only to add the button and the route, so your result is normal.
          Hide
          Stéphane Diot added a comment -

          By the way I didn't filled the fixversion because it will be probably in 1.6 which is not tagged yet.

          Show
          Stéphane Diot added a comment - By the way I didn't filled the fixversion because it will be probably in 1.6 which is not tagged yet.
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for master.
          Thanks Stéphane.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for master. Thanks Stéphane.

            People

            • Assignee:
              Unassigned
              Reporter:
              Damien Pobel (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: