Details

    • Type: Story Story
    • Status: Backlog
    • Priority: High High
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Package structure

      Different directory structure for the package, based on repository-forms/ezplatform-solr-search-engine

      InfoCollector

      "infocollector" is in use in legacy. Rename SystemInfoCollector to something else.
      SystemInfoCollector is okay, as long as we use the full name, and not InfoCollector.

      Services/parameters

      Rename support_tools.info_collector.registry to support_tools.system_info.collector_registry
      and in general, support_tools.info_collector to support_tools.system_info
      Taken care of in https://github.com/ezsystems/ez-support-tools/pull/12

        Activity

        Hide
        Gunnstein Lye added a comment - - edited

        André Rømcke Bertrand Dunogier I joked about SystemInfoGatherer before, but I like it actually. Clear meaning and little risk of future collisions, though not so easy on the tongue. What do you think?

        Show
        Gunnstein Lye added a comment - - edited André Rømcke Bertrand Dunogier I joked about SystemInfoGatherer before, but I like it actually. Clear meaning and little risk of future collisions, though not so easy on the tongue. What do you think?
        Hide
        Bertrand Dunogier added a comment -

        I like the 2nd option, where we keep Collector, but change "Info". Data could work, but any other alternative for us to think about ?

        Show
        Bertrand Dunogier added a comment - I like the 2nd option, where we keep Collector, but change "Info". Data could work, but any other alternative for us to think about ?
        Hide
        Bertrand Dunogier added a comment - - edited

        We should make this task a bit wider. As discussed on github, services would benefit from a bit of paint as well, mostly for consistency and clarity.

        As long as we haven't tagged a 1.x, we can easily take care of that once the steam has cleared away. About that: we need to be conservative on the version operator for the support-tools requirement in platform-ui: it should be ~0.1.0, so that 0.2 or above are not grabbed as they can break BC.

        We should also update the structure to match the src/, bundle/ structure we have adopted in other packages.

        Show
        Bertrand Dunogier added a comment - - edited We should make this task a bit wider. As discussed on github , services would benefit from a bit of paint as well, mostly for consistency and clarity. As long as we haven't tagged a 1.x, we can easily take care of that once the steam has cleared away. About that: we need to be conservative on the version operator for the support-tools requirement in platform-ui: it should be ~0.1.0 , so that 0.2 or above are not grabbed as they can break BC. We should also update the structure to match the src/ , bundle/ structure we have adopted in other packages.
        Hide
        Gunnstein Lye added a comment -

        Bertrand Dunogier As for package structure, can you suggest a package as an example to follow? Seems to be quite a few different setups.

        André Rømcke Any opinion about the renaming?

        Show
        Gunnstein Lye added a comment - Bertrand Dunogier As for package structure, can you suggest a package as an example to follow? Seems to be quite a few different setups. André Rømcke Any opinion about the renaming?
        Hide
        Bertrand Dunogier added a comment -

        Bertrand Dunogier As for package structure, can you suggest a package as an example to follow? Seems to be quite a few different setups.

        Show
        Bertrand Dunogier added a comment - Bertrand Dunogier As for package structure, can you suggest a package as an example to follow? Seems to be quite a few different setups. https://github.com/ezsystems/repository-forms https://github.com/ezsystems/ezplatform-solr-search-engine
        Hide
        André Rømcke added a comment - - edited

        > André Rømcke Any opinion about the renaming?

        As written on PR*, as long as we refer to it by full name, "SystemInfoCollector", I'm fine with it.
        I'm also fine with terms like "SystemDataCollector" or somewhat "SystemPropertiesCollector". However "SystemInfoCollector" is maybe the most relevant name, with "SystemDataCollector" on a second for me.

        * https://github.com/ezsystems/ez-support-tools/pull/12/files#r58554709

        Show
        André Rømcke added a comment - - edited > André Rømcke Any opinion about the renaming? As written on PR*, as long as we refer to it by full name, "SystemInfoCollector", I'm fine with it. I'm also fine with terms like "SystemDataCollector" or somewhat "SystemPropertiesCollector". However "SystemInfoCollector" is maybe the most relevant name, with "SystemDataCollector" on a second for me. * https://github.com/ezsystems/ez-support-tools/pull/12/files#r58554709
        Hide
        Gunnstein Lye added a comment -

        Cool, glad to keep the current name as none of the others are as good. Issue updated.

        Show
        Gunnstein Lye added a comment - Cool, glad to keep the current name as none of the others are as good. Issue updated.

          People

          • Assignee:
            Gunnstein Lye
            Reporter:
            Gunnstein Lye
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 0 minutes
              0m
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 30 minutes
              1h 30m