Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-25197

Renaming role to existing name must be gracefully handled

    Details

      Description

      In platform 1.0.0 rc1, if a role is renamed to a name that already exists, a notification "Failed to load 'http://php55-vm.ezplatform/pjax/role/update/7'" is sent. These are the elements the behat scenario checks for a notification 'Form did not validate. Please review errors below.', with details about the error.

      Behat scenario: https://github.com/ezsystems/PlatformUIBundle/blob/master/Features/RoleUI/RoleUI.feature#L143-L150.

        Issue Links

          Activity

          Hide
          Adam Wójs added a comment - - edited

          Actually problem is more general. In fact there is no any validation for name field (on form level), especially:

            Constraint Description
          A Uniqueness Incorrect FQN to RoleData in validation.yml, there is EzSystems\RepositoryForms\Data\RoleData instead of EzSystems\RepositoryForms\Data\Role\RoleData
          B NotBlank Missing, there is only "required" attribute on <input />
          C Max length Missing, should be 255 chars
          Show
          Adam Wójs added a comment - - edited Actually problem is more general. In fact there is no any validation for name field (on form level), especially:   Constraint Description A Uniqueness Incorrect FQN to RoleData in validation.yml , there is EzSystems\RepositoryForms\Data\RoleData instead of EzSystems\RepositoryForms\Data\Role\RoleData B NotBlank Missing, there is only "required" attribute on <input /> C Max length Missing, should be 255 chars
          Hide
          Adam Wójs added a comment - - edited
          Show
          Adam Wójs added a comment - - edited PR: https://github.com/ezsystems/repository-forms/pull/122
          Show
          André Rømcke added a comment - Merged: https://github.com/ezsystems/repository-forms/commit/6f12c725d25dfad5b10f677beba1cf9b8577aafe
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for master.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for master.

            People

            • Assignee:
              Unassigned
              Reporter:
              Bertrand Dunogier
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: