Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-25088

Content items not indexed by legacySearchEngine

    Details

      Description

      Steps to reproduce:

      1. Install a master version without legacy;

      2. Import the attached bundle and register it on EzPublishKernel.php and on routing.yml;

      3. With the bundle working, from the ezpublish root, run the following command:

      php ezpublish/console test:testSearch footer
      

      You should get:

      Found: footer
      Execution terminated.
      

      4. Now, via platformUI, create a folder "folder" and on its short name, for instance write "footer" as well;

      5. From the ezpublish root, run the following command again:

      php ezpublish/console test:testSearch footer
      

      You still get only the default footer:

      Found: footer
      Execution terminated.
      

      even if "footer" is contained in a field of "folder";

      6. Run the following command:

      php ezpublish/console test:testSearch folder
      

      You'll get empty results:

      Execution terminated.
      

      doesn't find either by its name.

        Issue Links

          Activity

          Rui Silva (Inactive) created issue -
          Rui Silva (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] Confirmed [ 10037 ]
          Paulo Nunes (Inactive) made changes -
          Labels 6.0Certification QA
          Rui Silva (Inactive) made changes -
          Attachment Test.tar.gz [ 25820 ]
          André Rømcke made changes -
          Summary Contents created via platformUI not indexed for legacy search Contents created via platformUI not indexed for legacySearchEngine
          Bertrand Dunogier made changes -
          Summary Contents created via platformUI not indexed for legacySearchEngine Content items created via platformUI not indexed for legacySearchEngine
          Paulo Nunes (Inactive) made changes -
          Affects Version/s 2015.11.2 [ 14499 ]
          Affects Version/s 2015.11 [ 14487 ]
          Damien Pobel (Inactive) made changes -
          Priority High [ 3 ] Critical [ 2 ]
          Hide
          Damien Pobel (Inactive) added a comment -

          Actually, it goes way beyond content created in PlatformUI. Any content created in Platform (with REST or with the Public API seems to not be indexed in the "legacy search engine".

          Show
          Damien Pobel (Inactive) added a comment - Actually, it goes way beyond content created in PlatformUI. Any content created in Platform (with REST or with the Public API seems to not be indexed in the "legacy search engine".
          Damien Pobel (Inactive) made changes -
          Summary Content items created via platformUI not indexed for legacySearchEngine Content items not indexed by legacySearchEngine
          Damien Pobel (Inactive) made changes -
          Component/s Platform stack [ 10303 ]
          Component/s Platform UI (Admin UI & Content UI) [ 10301 ]
          Damien Pobel (Inactive) made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Backlog [ 10000 ]
          Bertrand Dunogier made changes -
          Issue Type Bug [ 1 ] Task [ 3 ]
          Bertrand Dunogier made changes -
          Issue Type Task [ 3 ] Bug [ 1 ]
          Hide
          André Rømcke added a comment -

          Initial empty implementation for anyone to get started on this
          https://github.com/ezsystems/ezpublish-kernel/pull/1533

          Show
          André Rømcke added a comment - Initial empty implementation for anyone to get started on this https://github.com/ezsystems/ezpublish-kernel/pull/1533
          André Rømcke made changes -
          Fix Version/s Known Issues List [ 14512 ]
          Damien Pobel (Inactive) made changes -
          Link This issue relates to EZP-25000 [ EZP-25000 ]
          Damien Pobel (Inactive) made changes -
          Link This issue relates to EZP-25000 [ EZP-25000 ]
          André Rømcke made changes -
          Affects Version/s 16.02 [ 14501 ]
          Affects Version/s 16.04 [ 14502 ]
          Andrzej Longosz logged work - 11/May/16 2:00 PM - edited
          • Time Spent:
            2 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 12/May/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            n/a - catching up on log work

          Andrzej Longosz made changes -
          Assignee Andrzej Longosz [ andrzej.longosz@ez.no ]
          Andrzej Longosz made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Andrzej Longosz logged work - 13/May/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 16/May/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 18/May/16 9:00 AM - edited
          • Time Spent:
            3 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 19/May/16 9:00 AM - edited
          • Time Spent:
            2 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 20/May/16 9:00 AM - edited
          • Time Spent:
            4 hours
             

            n/a - catching up on log work

          Andrzej Longosz logged work - 27/May/16 11:00 AM
          • Time Spent:
            6 hours, 30 minutes
             

            n/a - catching up on work log

          Andrzej Longosz logged work - 30/May/16 1:00 PM - edited
          • Time Spent:
            4 hours
             

            n/a

          Andrzej Longosz logged work - 31/May/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            working on PR - CI errors, code cleanup, investigating possibilities of improvements

          Andrzej Longosz logged work - 01/Jun/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            working on PR - CI errors, code cleanup, investigating possibilities of improvements

          Andrzej Longosz logged work - 02/Jun/16 9:00 AM - edited
          • Time Spent:
            7 hours
             

            working on PR - investigating possibilities of improvements

          Hide
          Andrzej Longosz added a comment -

          My PR: https://github.com/ezsystems/ezpublish-kernel/pull/1660

          I think code still needs some improvements (as I've mentioned in PR comments), I'll appreciate any feedback.

          Show
          Andrzej Longosz added a comment - My PR: https://github.com/ezsystems/ezpublish-kernel/pull/1660 I think code still needs some improvements (as I've mentioned in PR comments), I'll appreciate any feedback.
          Andrzej Longosz logged work - 03/Jun/16 11:00 AM
          • Time Spent:
            3 hours, 30 minutes
             

            working on PR - investigating possibilities of improvements

          Andrzej Longosz made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 7 hours [ 25200 ]
          Worklog Id 59859 [ 59859 ]
          Andrzej Longosz made changes -
          Time Spent 7 hours [ 25200 ] 1 day, 6 hours [ 50400 ]
          Worklog Id 59860 [ 59860 ]
          Andrzej Longosz made changes -
          Time Spent 1 day, 6 hours [ 50400 ] 2 days, 5 hours [ 75600 ]
          Worklog Id 59861 [ 59861 ]
          Andrzej Longosz made changes -
          Time Spent 2 days, 5 hours [ 75600 ] 3 days, 4 hours [ 100800 ]
          Worklog Id 59862 [ 59862 ]
          Andrzej Longosz made changes -
          Time Spent 3 days, 4 hours [ 100800 ] 4 days, 3 hours [ 126000 ]
          Worklog Id 59863 [ 59863 ]
          Andrzej Longosz made changes -
          Time Spent 4 days, 3 hours [ 126000 ] 1 week, 2 hours [ 151200 ]
          Worklog Id 59864 [ 59864 ]
          Andrzej Longosz made changes -
          Time Spent 1 week, 2 hours [ 151200 ] 1 week, 1 day, 1 hour [ 176400 ]
          Worklog Id 59865 [ 59865 ]
          Andrzej Longosz made changes -
          Remaining Estimate 0 minutes [ 0 ] 5 hours [ 18000 ]
          Time Spent 1 week, 1 day, 1 hour [ 176400 ] 1 week, 4 hours [ 158400 ]
          Worklog Id 59859 [ 59859 ]
          Andrzej Longosz made changes -
          Worklog Id 59860 [ 59860 ]
          Andrzej Longosz made changes -
          Worklog Id 59861 [ 59861 ]
          Andrzej Longosz made changes -
          Worklog Id 59862 [ 59862 ]
          Andrzej Longosz made changes -
          Remaining Estimate 5 hours [ 18000 ] 1 day, 1 hour [ 32400 ]
          Time Spent 1 week, 4 hours [ 158400 ] 1 week [ 144000 ]
          Worklog Id 59863 [ 59863 ]
          Andrzej Longosz made changes -
          Remaining Estimate 1 day, 1 hour [ 32400 ] 1 day, 6 hours [ 50400 ]
          Time Spent 1 week [ 144000 ] 4 days, 3 hours [ 126000 ]
          Worklog Id 59864 [ 59864 ]
          Andrzej Longosz made changes -
          Worklog Id 59864 [ 59864 ]
          Andrzej Longosz made changes -
          Remaining Estimate 1 day, 6 hours [ 50400 ] 2 days, 1 hour [ 61200 ]
          Time Spent 4 days, 3 hours [ 126000 ] 4 days [ 115200 ]
          Worklog Id 59865 [ 59865 ]
          Andrzej Longosz made changes -
          Remaining Estimate 2 days, 1 hour [ 61200 ] 1 day, 2 hours, 30 minutes [ 37800 ]
          Time Spent 4 days [ 115200 ] 4 days, 6 hours, 30 minutes [ 138600 ]
          Worklog Id 59866 [ 59866 ]
          Andrzej Longosz made changes -
          Remaining Estimate 1 day, 2 hours, 30 minutes [ 37800 ] 6 hours, 30 minutes [ 23400 ]
          Time Spent 4 days, 6 hours, 30 minutes [ 138600 ] 1 week, 2 hours, 30 minutes [ 153000 ]
          Worklog Id 59867 [ 59867 ]
          Andrzej Longosz made changes -
          Worklog Id 59867 [ 59867 ]
          Andrzej Longosz made changes -
          Remaining Estimate 6 hours, 30 minutes [ 23400 ] 0 minutes [ 0 ]
          Time Spent 1 week, 2 hours, 30 minutes [ 153000 ] 1 week, 1 day, 1 hour, 30 minutes [ 178200 ]
          Worklog Id 59868 [ 59868 ]
          Andrzej Longosz made changes -
          Time Spent 1 week, 1 day, 1 hour, 30 minutes [ 178200 ] 1 week, 2 days, 30 minutes [ 203400 ]
          Worklog Id 59869 [ 59869 ]
          Andrzej Longosz made changes -
          Time Spent 1 week, 2 days, 30 minutes [ 203400 ] 1 week, 2 days, 7 hours, 30 minutes [ 228600 ]
          Worklog Id 59870 [ 59870 ]
          Andrzej Longosz made changes -
          Worklog Id 59868 [ 59868 ]
          Andrzej Longosz made changes -
          Worklog Id 59869 [ 59869 ]
          Andrzej Longosz made changes -
          Worklog Id 59870 [ 59870 ]
          Andrzej Longosz made changes -
          Time Spent 1 week, 2 days, 7 hours, 30 minutes [ 228600 ] 1 week, 3 days, 3 hours [ 241200 ]
          Worklog Id 59871 [ 59871 ]
          Andrzej Longosz made changes -
          Time Spent 1 week, 3 days, 3 hours [ 241200 ] 1 week, 3 days, 4 hours [ 244800 ]
          Worklog Id 59898 [ 59898 ]
          Andrzej Longosz logged work - 08/Jun/16 9:00 PM
          • Time Spent:
            1 hour
             

            working on PR - investigating possibilites of reuse of FieldNameResolver

          Andrzej Longosz made changes -
          Time Spent 1 week, 3 days, 4 hours [ 244800 ] 1 week, 3 days, 7 hours [ 255600 ]
          Worklog Id 59909 [ 59909 ]
          Andrzej Longosz logged work - 09/Jun/16 6:46 PM
          • Time Spent:
            3 hours
             

            working on PR - implementing changes in SPI\Search\Handler and related code

          Andrzej Longosz made changes -
          Time Spent 1 week, 3 days, 7 hours [ 255600 ] 1 week, 4 days, 5 hours, 30 minutes [ 279000 ]
          Worklog Id 59915 [ 59915 ]
          Andrzej Longosz logged work - 10/Jun/16 7:09 PM
          • Time Spent:
            6 hours, 30 minutes
             

            working on PR - extracting common classes (refactoring)

          Andrzej Longosz made changes -
          Time Spent 1 week, 4 days, 5 hours, 30 minutes [ 279000 ] 2 weeks, 4 hours, 30 minutes [ 304200 ]
          Worklog Id 59935 [ 59935 ]
          Andrzej Longosz logged work - 13/Jun/16 7:21 PM
          • Time Spent:
            7 hours
             

            extracting Solr FieldValueMappers to Core\Search\Common\FieldValueMappers namespace

          Andrzej Longosz made changes -
          Time Spent 2 weeks, 4 hours, 30 minutes [ 304200 ] 2 weeks, 1 day, 3 hours [ 327600 ]
          Worklog Id 59938 [ 59938 ]
          Andrzej Longosz logged work - 14/Jun/16 7:07 PM
          • Time Spent:
            6 hours, 30 minutes
             

            extracing Elasticsearch FieldValueMappers to Core\Search\Common\FieldValueMapper

          Andrzej Longosz made changes -
          Time Spent 2 weeks, 1 day, 3 hours [ 327600 ] 2 weeks, 2 days, 30 minutes [ 347400 ]
          Worklog Id 59943 [ 59943 ]
          Andrzej Longosz logged work - 15/Jun/16 6:54 PM
          • Time Spent:
            5 hours, 30 minutes
             

            implementing FieldValueMappers for legacy/SQL search engine using common (extracted from Solr and Elasticsearch) classes

          Andrzej Longosz made changes -
          Time Spent 2 weeks, 2 days, 30 minutes [ 347400 ] 2 weeks, 2 days, 7 hours [ 370800 ]
          Worklog Id 60000 [ 60000 ]
          Andrzej Longosz logged work - 16/Jun/16 6:56 PM
          • Time Spent:
            6 hours, 30 minutes
             

            implementing FieldValueMappers for legacy/SQL search engine

          Andrzej Longosz made changes -
          Time Spent 2 weeks, 2 days, 7 hours [ 370800 ] 2 weeks, 3 days, 7 hours [ 399600 ]
          Worklog Id 60021 [ 60021 ]
          Andrzej Longosz logged work - 18/Jun/16 1:36 AM
          • Time Spent:
            1 day
             

            implementing DocumentMapper for legacy/SQL search engine, refactoring, testing

          Andrzej Longosz made changes -
          Time Spent 2 weeks, 3 days, 7 hours [ 399600 ] 2 weeks, 4 days, 6 hours [ 424800 ]
          Worklog Id 60025 [ 60025 ]
          Andrzej Longosz logged work - 20/Jun/16 6:57 PM
          • Time Spent:
            7 hours
             

            changing SPI\Search\Handler interface to expose new possibilities of handling db inconsistencies

          Hide
          Andrzej Longosz added a comment - - edited

          Due to dependencies on Solr, which was changed as well, following PR's were created:

          Show
          Andrzej Longosz added a comment - - edited Due to dependencies on Solr, which was changed as well, following PR's were created: Solr PR #49 - merged to satisfy dependencies during Kernel PR #1660 Kernel PR #1707 CI tests; Solr PR #48 - to be reviewed and merged after review and merge of Kernel PR #1660.
          Andrzej Longosz made changes -
          Time Spent 2 weeks, 4 days, 6 hours [ 424800 ] 3 weeks, 4 hours [ 446400 ]
          Worklog Id 60028 [ 60028 ]
          Andrzej Longosz logged work - 21/Jun/16 6:59 PM
          • Time Spent:
            6 hours
             

            Created separate PR for Solr dependencies, testing PR #1660

          Andrzej Longosz made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Andrzej Longosz made changes -
          Time Spent 3 weeks, 4 hours [ 446400 ] 3 weeks, 1 day, 3 hours, 30 minutes [ 473400 ]
          Worklog Id 60033 [ 60033 ]
          Andrzej Longosz logged work - 22/Jun/16 7:24 PM
          • Time Spent:
            7 hours, 30 minutes
             

            fixed code review remarks, modified and rebased Solr PR #47.

          Andrzej Longosz made changes -
          Time Spent 3 weeks, 1 day, 3 hours, 30 minutes [ 473400 ] 3 weeks, 1 day, 7 hours [ 486000 ]
          Worklog Id 60035 [ 60035 ]
          Andrzej Longosz logged work - 23/Jun/16 6:43 PM
          • Time Spent:
            3 hours, 30 minutes
             

            reviewing and discussing next steps, splitting up PR

          Andrzej Longosz made changes -
          Time Spent 3 weeks, 1 day, 7 hours [ 486000 ] 3 weeks, 2 days, 6 hours [ 511200 ]
          Worklog Id 60099 [ 60099 ]
          Andrzej Longosz logged work - 24/Jun/16 6:30 PM
          • Time Spent:
            7 hours
             

            Implementing content objects indexing in legacy search engine without common parts

          Andrzej Longosz made changes -
          Time Spent 3 weeks, 2 days, 6 hours [ 511200 ] 3 weeks, 3 days, 5 hours [ 536400 ]
          Worklog Id 60110 [ 60110 ]
          Andrzej Longosz logged work - 27/Jun/16 6:58 PM
          • Time Spent:
            7 hours
             

            Applying common parts introduced in Kernel PR #1697

          Andrzej Longosz made changes -
          Time Spent 3 weeks, 3 days, 5 hours [ 536400 ] 3 weeks, 4 days, 2 hours, 30 minutes [ 556200 ]
          Worklog Id 60111 [ 60111 ]
          Andrzej Longosz logged work - 28/Jun/16 7:57 PM
          • Time Spent:
            5 hours, 30 minutes
             

            Moved search engine signal slot configuration from common to search engine config

          André Rømcke made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ]
          André Rømcke made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          André Rømcke made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Andrzej Longosz made changes -
          Time Spent 3 weeks, 4 days, 2 hours, 30 minutes [ 556200 ] 3 weeks, 4 days, 3 hours, 15 minutes [ 558900 ]
          Worklog Id 60161 [ 60161 ]
          Andrzej Longosz logged work - 05/Jul/16 7:00 PM
          • Time Spent:
            45 minutes
             

            discussing possibilities of disabling some signal slots when all the search engine bundles are loaded

          Andrzej Longosz made changes -
          Time Spent 3 weeks, 4 days, 3 hours, 15 minutes [ 558900 ] 4 weeks, 2 hours, 15 minutes [ 584100 ]
          Worklog Id 60165 [ 60165 ]
          Andrzej Longosz logged work - 06/Jul/16 6:55 PM
          • Time Spent:
            7 hours
             

            making SignalDispatcher ignore signals not relevant for configured search engine (per siteaccess repository)

          Andrzej Longosz made changes -
          Time Spent 4 weeks, 2 hours, 15 minutes [ 584100 ] 4 weeks, 1 day, 1 hour, 15 minutes [ 609300 ]
          Worklog Id 60172 [ 60172 ]
          Andrzej Longosz logged work - 07/Jul/16 7:20 PM
          • Time Spent:
            7 hours
             

            improving approach with separated signal slots

          Andrzej Longosz made changes -
          Time Spent 4 weeks, 1 day, 1 hour, 15 minutes [ 609300 ] 4 weeks, 2 days, 15 minutes [ 634500 ]
          Worklog Id 60177 [ 60177 ]
          Andrzej Longosz logged work - 08/Jul/16 6:51 PM
          • Time Spent:
            7 hours
             

            refactoring SignalDispatcher, updating tests

          Andrzej Longosz logged work - 11/Jul/16 12:54 PM
          • Time Spent:
            7 hours
             

            moving attaching signal slots from SignalDispatcher to its factory, solving integration tests issues.

          Andrzej Longosz made changes -
          Time Spent 4 weeks, 2 days, 15 minutes [ 634500 ] 4 weeks, 2 days, 7 hours, 15 minutes [ 659700 ]
          Worklog Id 60191 [ 60191 ]
          Andrzej Longosz made changes -
          Time Spent 4 weeks, 2 days, 7 hours, 15 minutes [ 659700 ] 4 weeks, 3 days, 4 hours, 45 minutes [ 679500 ]
          Worklog Id 60193 [ 60193 ]
          Andrzej Longosz logged work - 12/Jul/16 6:27 PM
          • Time Spent:
            5 hours, 30 minutes
             

            improving SignalDispatcherFactory

          Andrzej Longosz made changes -
          Time Spent 4 weeks, 3 days, 4 hours, 45 minutes [ 679500 ] 4 weeks, 3 days, 7 hours, 45 minutes [ 690300 ]
          Worklog Id 60200 [ 60200 ]
          Andrzej Longosz logged work - 13/Jul/16 8:10 PM
          • Time Spent:
            3 hours
             

            code review fixes

          Andrzej Longosz logged work - 14/Jul/16 1:31 PM - edited
          • Time Spent:
            6 hours, 30 minutes
             

            making ezpublish-kernel not dependent on $repository$ and %ezpublish.repositories% parameters

          Andrzej Longosz made changes -
          Time Spent 4 weeks, 3 days, 7 hours, 45 minutes [ 690300 ] 4 weeks, 4 days, 6 hours, 15 minutes [ 713700 ]
          Worklog Id 60210 [ 60210 ]
          Andrzej Longosz made changes -
          Worklog Id 60210 [ 60210 ]
          Andrzej Longosz made changes -
          Time Spent 4 weeks, 4 days, 6 hours, 15 minutes [ 713700 ] 5 weeks, 5 hours, 15 minutes [ 738900 ]
          Worklog Id 60214 [ 60214 ]
          Andrzej Longosz logged work - 15/Jul/16 6:50 PM
          • Time Spent:
            7 hours
             

            improving code

          André Rømcke made changes -
          Epic Link EZP-25990 [ 54869 ]
          André Rømcke made changes -
          Original Estimate 0 minutes [ 0 ]
          Andrzej Longosz logged work - 19/Jul/16 11:01 AM
          • Time Spent:
            7 hours
             

            applying changes for PR solving this issue

          Andrzej Longosz made changes -
          Time Spent 5 weeks, 5 hours, 15 minutes [ 738900 ] 5 weeks, 1 day, 4 hours, 15 minutes [ 764100 ]
          Worklog Id 60238 [ 60238 ]
          Hide
          Andrzej Longosz added a comment - - edited

          During a review we discovered that this bugfix requires several changes including implementing missing features on ezpublish-kernel. Therefore it cannot be backported to previous versions (5.0, 5.4).
          Also, an Epic was created ("Full Text Search SQL") to link all related issues.

          This issue is fixed by the WordIndexer Kernel PR #1707 (reopened #1660 against the `master` branch).
          Ready for a review.

          Before this could be completed, separate PRs needed to be merged solving required, separate tasks:

          1. Move FieldValueMapper namespace in each engine to the common one `eZ\Publish\Core\Search\Common\FieldValueMapper`:
            • Merged - Kernel PR #1697 - an improvement refactoring FieldValueMapper namespace to be common for all search engine bundles.
            • Merged - Solr PR #50 - removed FieldValueMapper namespace in favor of the one introduced by Kernel PR #1697|https://github.com/ezsystems/ezpublish-kernel/pull/1697]
          2. Decouple Signal Slots for each search engine to exclude not needed search Slots (e.g. for legacy search engine we don't need Slots related to Locations as Locations are not indexable by this engine):

          Note: To work properly when multiple search engine bundles are enabled in `AppKernel`, Signal Slots names are different in each search engine. If the names remained the same, each bundle would override configuration. This use case occurs when siteacceses in a web application use different repositories which can use different search engines.

          Mentioned common/generic indexing command is a separate story in the "Full Text Search SQL" Epic.

          Show
          Andrzej Longosz added a comment - - edited During a review we discovered that this bugfix requires several changes including implementing missing features on ezpublish-kernel. Therefore it cannot be backported to previous versions (5.0, 5.4). Also, an Epic was created ("Full Text Search SQL") to link all related issues. This issue is fixed by the WordIndexer Kernel PR #1707 (reopened #1660 against the `master` branch). Ready for a review. Before this could be completed, separate PRs needed to be merged solving required, separate tasks: Move FieldValueMapper namespace in each engine to the common one `eZ\Publish\Core\Search\Common\FieldValueMapper`: Merged - Kernel PR #1697 - an improvement refactoring FieldValueMapper namespace to be common for all search engine bundles. Merged - Solr PR #50 - removed FieldValueMapper namespace in favor of the one introduced by Kernel PR #1697|https://github.com/ezsystems/ezpublish-kernel/pull/1697] Decouple Signal Slots for each search engine to exclude not needed search Slots (e.g. for legacy search engine we don't need Slots related to Locations as Locations are not indexable by this engine): Merged - Kernel PR #1704 - introduces SignalDispatcherFactory creating SignalDispatcher with a proper SignalSlot map. Ready for a review - Solr PR #54 - aligns with changes done in the Kernel PR #1704 Merged Solr PR #51 - moves search engine Signal Slots configuration to Solr-specific yaml file. Note: To work properly when multiple search engine bundles are enabled in `AppKernel`, Signal Slots names are different in each search engine. If the names remained the same, each bundle would override configuration. This use case occurs when siteacceses in a web application use different repositories which can use different search engines. Mentioned common/generic indexing command is a separate story in the "Full Text Search SQL" Epic.
          Andrzej Longosz made changes -
          Time Spent 5 weeks, 1 day, 4 hours, 15 minutes [ 764100 ] 5 weeks, 2 days, 2 hours, 15 minutes [ 785700 ]
          Worklog Id 60240 [ 60240 ]
          Andrzej Longosz logged work - 20/Jul/16 6:31 PM
          • Time Spent:
            6 hours
             

            investigating code review issues, refactoring - removing not needed parts of code

          Show
          Andrzej Longosz added a comment - Merged Kernel PR #1707 solving this issue: https://github.com/ezsystems/ezpublish-kernel/commit/e391f2bfb9b39ec77393e7a7cc5714074bf2bc24 Merged Solr PR #54 aligning with Kernel PR #1707: https://github.com/ezsystems/ezplatform-solr-search-engine/commit/d48cd690679939c6a4c54d631dbf16cbafda7c55
          Andrzej Longosz made changes -
          Status Development Review [ 10006 ] Documentation Review done [ 10011 ]
          Assignee Andrzej Longosz [ andrzej.longosz@ez.no ]
          Rui Silva (Inactive) made changes -
          Status Documentation Review done [ 10011 ] QA [ 10008 ]
          Hide
          Paulo Nunes (Inactive) added a comment -

          Andrzej Longosz: can you please update "Fix Version/s" tag?
          Thank you.

          Show
          Paulo Nunes (Inactive) added a comment - Andrzej Longosz : can you please update "Fix Version/s" tag? Thank you.
          Hide
          Rui Silva (Inactive) added a comment -

          Andrzej Longosz, what exactly is the testing scope of these fixes, and which of the six of them exactly are necessary to test the legacy indexing issue?
          QA is having difficulty understanding what exactly is necessary to test this and if and why fixes for Solr are needed for a fix on Legacy search engine.
          Thanks.

          Show
          Rui Silva (Inactive) added a comment - Andrzej Longosz , what exactly is the testing scope of these fixes, and which of the six of them exactly are necessary to test the legacy indexing issue? QA is having difficulty understanding what exactly is necessary to test this and if and why fixes for Solr are needed for a fix on Legacy search engine. Thanks.
          Andrzej Longosz made changes -
          Fix Version/s 1.5.0 [ 14582 ]
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for master.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for master.
          Rui Silva (Inactive) made changes -
          Assignee Rui Silva [ rui.silva@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Andrzej Longosz added a comment -

          Paulo Nunes: done

          [~rui.silva@ez.no]: To test this you need to have eZ Platform web app with ezpublish-kernel taken from master branch (every Kernel PR is needed for this to work). eZ Platform needs to be configured for legacy search engine (for simple setup it can be set in app/config/parameters.yml). Attached test case and steps to reproduce should be enough to test this. After adding some content object (e.g. a Folder named "folder") attached test command should display it as found.

          Fixes for Solr are needed only if Solr bundle is enabled in app/AppKernel.php along with Legacy Search Bundle. Moreover most of these fixes are due to performance issues not the actual fix of a bug (as I understand it at least ).

          This is my first bug fix that covers so extensive changes, so I'm not sure if my explanation makes sense for QA. Maybe André Rømcke could comment on this?

          Show
          Andrzej Longosz added a comment - Paulo Nunes : done [~rui.silva@ez.no] : To test this you need to have eZ Platform web app with ezpublish-kernel taken from master branch (every Kernel PR is needed for this to work). eZ Platform needs to be configured for legacy search engine (for simple setup it can be set in app/config/parameters.yml ). Attached test case and steps to reproduce should be enough to test this. After adding some content object (e.g. a Folder named "folder") attached test command should display it as found. Fixes for Solr are needed only if Solr bundle is enabled in app/AppKernel.php along with Legacy Search Bundle. Moreover most of these fixes are due to performance issues not the actual fix of a bug (as I understand it at least ). This is my first bug fix that covers so extensive changes, so I'm not sure if my explanation makes sense for QA. Maybe André Rømcke could comment on this?
          Hide
          Rui Silva (Inactive) added a comment -

          Thanks Andrzej Longosz, as you can see, QA was afterwards able to certify this. We'd had just a little trouble understanding what this was meant to fix, exactly, because we were having consistency issues reproducing the issue I opened, and then run the test case again with the fix to see if it was fixed: we were not seeing it as fixed though, but then QA realized it must be due to the not-yet-implemented second jira of the epic that envelops this, since I was taking advantage of the previously existent contents created on the first run.
          I reinstalled it and did it all from scratch the second time, and it went ok.
          However, any further explanation or detailed information on this, or on how it is supposed to work as a whole, is welcome, since as for now, only this first part was tested and QA'ed, and it may be useful for later developments following this.

          Show
          Rui Silva (Inactive) added a comment - Thanks Andrzej Longosz , as you can see, QA was afterwards able to certify this. We'd had just a little trouble understanding what this was meant to fix, exactly, because we were having consistency issues reproducing the issue I opened, and then run the test case again with the fix to see if it was fixed: we were not seeing it as fixed though, but then QA realized it must be due to the not-yet-implemented second jira of the epic that envelops this, since I was taking advantage of the previously existent contents created on the first run. I reinstalled it and did it all from scratch the second time, and it went ok. However, any further explanation or detailed information on this, or on how it is supposed to work as a whole, is welcome, since as for now, only this first part was tested and QA'ed, and it may be useful for later developments following this.
          Dominika Kurek made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Roland Benedetti made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Dominika Kurek made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Dominika Kurek made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Dominika Kurek made changes -
          Remote Link This issue links to "Page (eZ Documentation)" [ 16682 ] This issue links to "Page (eZ Documentation)" [ 16682 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 96575 ] EZEE Development Workflow [ 125274 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          22s 1 rui.silva@ez.no 11/Nov/15 4:48 PM
          Confirmed Confirmed InputQ InputQ
          23d 1h 55m 1 damien.pobel@ez.no 04/Dec/15 6:44 PM
          InputQ InputQ Backlog Backlog
          21h 48m 1 Bertrand Dunogier 05/Dec/15 4:32 PM
          Backlog Backlog Development Development
          158d 16h 20m 1 Andrzej Longosz 12/May/16 9:53 AM
          Development Development Development Review Development Review
          41d 5h 12m 1 Andrzej Longosz 22/Jun/16 3:05 PM
          Development Review Development Review Documentation Review done Documentation Review done
          33d 19h 11m 1 Andrzej Longosz 26/Jul/16 10:16 AM
          Documentation Review done Documentation Review done QA QA
          5m 49s 1 rui.silva@ez.no 26/Jul/16 10:22 AM
          QA QA Closed Closed
          1h 37m 1 rui.silva@ez.no 26/Jul/16 12:00 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Rui Silva (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 weeks, 2 days, 2 hours, 15 minutes
                5w 2d 2h 15m