Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-25007

"Number of text rows in the editor" should be removed from RichText fieldtype

    Details

      Description

      Steps to reproduce

      *Create one content type with a richtext fieldtype. In the richtext fieldtype, set "Number of text rows in the editor" to 15
      *Create one object from previous content type

      Here it can be seen that the number of rows in the field are not the defined ones.

        Activity

        Hide
        Damien Pobel (Inactive) added a comment -

        I guess this was just copied from XmlText, but I wonder if we really want to have that setting on the RichText fields ?
        Btw the height of the RichText editor is not really specified anywhere (default height, does it grow with content in both focus and non focus mode ? ...)
        ping Roland Benedetti Inaki Juaniz-Velilla [~jince.kuruvilla@ez.no] André Rømcke

        Show
        Damien Pobel (Inactive) added a comment - I guess this was just copied from XmlText, but I wonder if we really want to have that setting on the RichText fields ? Btw the height of the RichText editor is not really specified anywhere (default height, does it grow with content in both focus and non focus mode ? ...) ping Roland Benedetti Inaki Juaniz-Velilla [~jince.kuruvilla@ez.no] André Rømcke
        Hide
        Jince Kuruvilla (Inactive) added a comment -

        Default Height - I would say we could take the default height that's currently specified for rich text fields. We should also allow users to control the height by making it adjustable. I don't think it should grow automatically though - the height should be a user decision.

        In focus mode, the height should by default be nearly the height of the user's browser (https://doc.ez.no/download/attachments/26674619/Focus%205.png?version=1&modificationDate=1441232180000&api=v2) and should scale automatically as the user continues to add content.

        Show
        Jince Kuruvilla (Inactive) added a comment - Default Height - I would say we could take the default height that's currently specified for rich text fields. We should also allow users to control the height by making it adjustable. I don't think it should grow automatically though - the height should be a user decision. In focus mode, the height should by default be nearly the height of the user's browser ( https://doc.ez.no/download/attachments/26674619/Focus%205.png?version=1&modificationDate=1441232180000&api=v2 ) and should scale automatically as the user continues to add content.
        Hide
        André Rømcke added a comment -

        This is not supposed to be here, so I'll change this to improvement to remove it.

        Show
        André Rømcke added a comment - This is not supposed to be here, so I'll change this to improvement to remove it.
        Show
        Andrzej Longosz added a comment - repository-forms PR: https://github.com/ezsystems/repository-forms/pull/112 ezpublish-kernel PR: https://github.com/ezsystems/ezpublish-kernel/pull/1915
        Hide
        Bertrand Dunogier added a comment -

        repository-forms PR merged to master.

        Show
        Bertrand Dunogier added a comment - repository-forms PR merged to master.
        Hide
        Andrzej Longosz added a comment -

        kernel PR merged to master

        Note for the QA: for this solution to work, packages:

        • ezsystems/ezpublish-kernel
        • ezsystems/repository-forms
          need to be updated (currently to dev-master).

        We removed one obsolete setting for RichText FieldType, so manual tests should include creating and updating a Content Type with this field and a Content Object (at least this is what I did).

        Show
        Andrzej Longosz added a comment - kernel PR merged to master Note for the QA: for this solution to work, packages: ezsystems/ezpublish-kernel ezsystems/repository-forms need to be updated (currently to dev-master ). We removed one obsolete setting for RichText FieldType, so manual tests should include creating and updating a Content Type with this field and a Content Object (at least this is what I did).
        Hide
        Rui Silva (Inactive) added a comment -

        Tested and approved by QA for master.

        Show
        Rui Silva (Inactive) added a comment - Tested and approved by QA for master.

          People

          • Assignee:
            Unassigned
            Reporter:
            Paulo Nunes (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: