Details

      Description

      As of EZP-24790, Repository exceptions like NotFound or Unauthorized are bubbled to Symfony and converted to appropriate HTTP exception.

      The problem is that Repository exceptions are not translatable. They're using injected parameters when they are created.

      Idea is to introduce a new interface for translatable exceptions, where messages could be easily internationalized.

        Issue Links

          Activity

          Hide
          Pedro Resende (Inactive) added a comment -

          [~jerome.vieilledent@ez.no]: I've tested the following list of exceptions:

          • BadStateException;
          • ContentFieldValidationException;
          • ContentTypeFieldDefinitionValidationException;
          • ContentTypeValidationException;
          • ContentValidationException;
          • ForbiddenException;
          • InvalidArgumentException;
          • InvalidArgumentType;
          • InvalidArgumentValue;
          • LimitationValidationException;
          • MissingClass;
          • FieldTypeNotFoundException;
          • LimitationNotFoundException;
          • NotFoundException;
          • UnauthorizedException;

          And they are working correctly and the translations are correct, but apparently:

          • FieldTypeNotFoundException;
          • LimitationNotFoundException;

          Aren't being translated

          Show
          Pedro Resende (Inactive) added a comment - [~jerome.vieilledent@ez.no] : I've tested the following list of exceptions: BadStateException; ContentFieldValidationException; ContentTypeFieldDefinitionValidationException; ContentTypeValidationException; ContentValidationException; ForbiddenException; InvalidArgumentException; InvalidArgumentType; InvalidArgumentValue; LimitationValidationException; MissingClass; FieldTypeNotFoundException; LimitationNotFoundException; NotFoundException; UnauthorizedException; And they are working correctly and the translations are correct, but apparently: FieldTypeNotFoundException; LimitationNotFoundException; Aren't being translated
          Hide
          Bertrand Dunogier added a comment - - edited

          QA, could you please create a follow-up story (affecting 2015.09) for the 2 items that didn't pass your tests, and move this one forward ?

          Show
          Bertrand Dunogier added a comment - - edited QA, could you please create a follow-up story (affecting 2015.09) for the 2 items that didn't pass your tests, and move this one forward ?
          Hide
          Paulo Nunes (Inactive) added a comment -

          Bertrand Dunogier: Ok. So "FieldTypeNotFoundException" and "LimitationNotFoundException" exceptions will be out of the scope of current story.

          Show
          Paulo Nunes (Inactive) added a comment - Bertrand Dunogier : Ok. So "FieldTypeNotFoundException" and "LimitationNotFoundException" exceptions will be out of the scope of current story.
          Hide
          Bertrand Dunogier added a comment -

          Yes, Paulo Nunes. Given that the change was merged to master, and master was released as 2015.09, we don't really choose the scope anymore

          Show
          Bertrand Dunogier added a comment - Yes, Paulo Nunes . Given that the change was merged to master, and master was released as 2015.09, we don't really choose the scope anymore
          Hide
          Pedro Resende (Inactive) added a comment -

          Tested and approved by Q.A. with the exception for the two translations

          • FieldTypeNotFoundException
          • LimitationNotFoundException

          These will be tested in EZP-24936

          Show
          Pedro Resende (Inactive) added a comment - Tested and approved by Q.A. with the exception for the two translations FieldTypeNotFoundException LimitationNotFoundException These will be tested in EZP-24936

            People

            • Assignee:
              Unassigned
              Reporter:
              Jérôme Vieilledent (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 25 minutes
                25m