Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-24423

RichText: input in the internal format is validated twice

    Details

      Description

      Input value is validated in the acceptValue(), using validator dispatcher. As both input the result of conversion is validated, input in internal format gets validated twice.

      Internal format validator should be passed to the constructor separately from validator dispatcher, and validation if internal format should be moved to the validate() method.

        Issue Links

          Activity

          Petar Spanja (Inactive) created issue -
          André Rømcke made changes -
          Field Original Value New Value
          Status Open [ 1 ] Confirmed [ 10037 ]
          André Rømcke made changes -
          Status Confirmed [ 10037 ] Backlog [ 10000 ]
          André Rømcke made changes -
          Epic Link EZP-22949 [ 11445 ]
          Show
          Petar Spanja (Inactive) added a comment - Pull request: https://github.com/ezsystems/ezpublish-kernel/pull/1274
          Petar Spanja (Inactive) logged work - 01/Jun/15 12:18 PM
          • Time Spent:
            1 hour, 30 minutes
             

            fixing

          Petar Spanja (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 1 hour, 30 minutes [ 5400 ]
          Worklog Id 55774 [ 55774 ]
          André Rømcke made changes -
          Rank Ranked higher
          André Rømcke made changes -
          Rank Ranked lower
          André Rømcke made changes -
          Status Backlog [ 10000 ] InputQ [ 10001 ]
          André Rømcke made changes -
          Rank Ranked lower
          Petar Spanja (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Show
          Petar Spanja (Inactive) added a comment - Merged in https://github.com/ezsystems/ezpublish-kernel/commit/941666113ace2400241de9b6aed06e24f0824980
          Petar Spanja (Inactive) made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Petar Spanja (Inactive) made changes -
          Status Development Review [ 10006 ] Documentation Review done [ 10011 ]
          Assignee Petar Spanja [ petar.spanja@ez.no ]
          Petar Spanja (Inactive) logged work - 02/Oct/15 3:38 PM
          • Time Spent:
            45 minutes
             

            fixing

          Rui Silva (Inactive) made changes -
          Status Documentation Review done [ 10011 ] QA [ 10008 ]
          Hide
          Rui Silva (Inactive) added a comment -

          Cannot save / publish richtext field contents.
          Currently being blocked EZP-24907.

          Show
          Rui Silva (Inactive) added a comment - Cannot save / publish richtext field contents. Currently being blocked EZP-24907 .
          Rui Silva (Inactive) made changes -
          Link This issue is blocked by EZP-24907 [ EZP-24907 ]
          Hide
          Rui Silva (Inactive) added a comment -

          Currently being blocked by EZP-24732, which doesn't allow to publish / save richtext fieldtype contents, thus blocking the validation to proceed.

          Show
          Rui Silva (Inactive) added a comment - Currently being blocked by EZP-24732 , which doesn't allow to publish / save richtext fieldtype contents, thus blocking the validation to proceed.
          Rui Silva (Inactive) made changes -
          Link This issue is blocked by EZP-24732 [ EZP-24732 ]
          Hide
          Rui Silva (Inactive) added a comment -

          Sanity tests were executed on RichText, by using its various subfields and chaining them with several formattings and styles.
          Remaining validation seems to work fine (after the removal of one other validation process).
          (Had to manually remove the last "empty" paragraph from richtext field that doesn't allow publishing of the richtext content, which is an issue)
          Approved by QA, for master.

          Show
          Rui Silva (Inactive) added a comment - Sanity tests were executed on RichText, by using its various subfields and chaining them with several formattings and styles. Remaining validation seems to work fine (after the removal of one other validation process). (Had to manually remove the last "empty" paragraph from richtext field that doesn't allow publishing of the richtext content, which is an issue) Approved by QA, for master.
          Rui Silva (Inactive) made changes -
          Assignee Rui Silva [ rui.silva@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Petar Spanja (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Petar Spanja (Inactive) made changes -
          Time Spent 1 hour, 30 minutes [ 5400 ] 2 hours, 15 minutes [ 8100 ]
          Worklog Id 57616 [ 57616 ]
          Petar Spanja (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 85881 ] EZEE Development Workflow [ 124841 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          5h 25m 1 André Rømcke 29/May/15 6:59 PM
          Confirmed Confirmed Backlog Backlog
          2s 1 André Rømcke 29/May/15 6:59 PM
          Backlog Backlog InputQ InputQ
          123d 6h 28m 1 André Rømcke 30/Sep/15 1:27 AM
          InputQ InputQ Development Development
          2d 9h 22m 1 Petar Spanja (Inactive) 02/Oct/15 10:49 AM
          Development Development Development Review Development Review
          2h 51m 1 Petar Spanja (Inactive) 02/Oct/15 1:41 PM
          Development Review Development Review Documentation Review done Documentation Review done
          4s 1 Petar Spanja (Inactive) 02/Oct/15 1:41 PM
          Documentation Review done Documentation Review done QA QA
          2d 21h 42m 1 rui.silva@ez.no 05/Oct/15 11:23 AM
          QA QA Closed Closed
          22d 1h 15m 1 rui.silva@ez.no 27/Oct/15 11:39 AM
          Closed Closed Reopened Reopened
          11d 1h 59m 1 Petar Spanja (Inactive) 07/Nov/15 1:38 PM
          Reopened Reopened Closed Closed
          0s 1 Petar Spanja (Inactive) 07/Nov/15 1:38 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Petar Spanja (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 15 minutes
                2h 15m