Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-24198

legacy admin: autosave will delete information about relations if AdvancedObjectRelationList = enabled

    Details

      Description

      When "AdvancedObjectRelationList" and the autosave feature are enabled, editing a related target object directly will remove the relation information from the source object's full view.

      TEST:

      set
      [BackwardCompatibilitySettings]
      AdvancedObjectRelationList=enabled
       
      - create an object X with a relations attribute, fill the relation with 1 target object, Y, and publish.
      - open the object X in the backend, the Relations tab should have 1 relation
       
      (use a second tab to make navigation easier. using 2 tabs has no effect on the issue at all)
      - In a new tab, edit the object X. Within the object relations field, edit the related object Y. trigger eZ Autosave to fire.
       
      - back In the first tab, clear caches using the right toolbar. Notice how object X no longer has any relation in the Relations tab.
       
      - In the second tab, discard the draft, close the tab
       
      - in first (and now only) tab, reload the full view of object X. the relation to Y does not show anymore.
       
      as secondary tests:
      - open X for edit. check that Y is still in the relations list
      - open X in a front end. check that Y shows as a related object. 
      

        Issue Links

          Activity

          Paulo Bras (Inactive) created issue -
          Paulo Bras (Inactive) made changes -
          Field Original Value New Value
          Link This issue relates to EZP-22466 [ EZP-22466 ]
          Paulo Bras (Inactive) made changes -
          Link This issue relates to EZP-23316 [ EZP-23316 ]
          Paulo Bras (Inactive) made changes -
          Summary ezcontentstaging: autosave will delete information about relations if AdvancedObjectRelationList = enabled legacy admin: autosave will delete information about relations if AdvancedObjectRelationList = enabled
          Paulo Bras (Inactive) made changes -
          Component/s Legacy/Administration Interface [ 10785 ]
          Component/s Legacy/Extensions/eZ Content Staging [ 10797 ]
          Paulo Bras (Inactive) made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Hide
          Peter Keung added a comment -

          One important thing to note is that this is not just a display issue in the Relations tab, but that the entry from the ezcontentobject_link table is removed.

          Show
          Peter Keung added a comment - One important thing to note is that this is not just a display issue in the Relations tab, but that the entry from the ezcontentobject_link table is removed.
          Yannick Roger (Inactive) made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          André Rømcke made changes -
          Rank Ranked higher
          Jérôme Vieilledent (Inactive) made changes -
          Assignee Damien Pobel [ damien.pobel@ez.no ]
          André Rømcke made changes -
          Assignee Damien Pobel [ damien.pobel@ez.no ]
          Gunnstein Lye made changes -
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Gunnstein Lye made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Gunnstein Lye logged work - 20/Apr/15 3:30 PM
          • Time Spent:
            3 hours
             

            .

          Hide
          Gunnstein Lye added a comment - - edited

          Confirmed on 5.4, partially. The related object Y disappears from the Relations tab of the full object view, but not from the object view itself. It is not removed from ezcontentobject_link, but the status of the current_version of Y in ezcontentobject is set to 0 (draft) which is why it isn't shown in the related object list. If I edit and publish Y, it shows in the list again.

          I suspect that this part is wrong or incomplete:
          https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/datatypes/ezobjectrelationlist/ezobjectrelationlisttype.php#L461

          It is ancient though, 2003 or older:
          https://github.com/ezsystems/ezpublish-legacy/commit/e6647e2e27572395a08c16e9089e6e558de7af69#diff-ba3bb3637db36baecce818bf6091e025R251

          Show
          Gunnstein Lye added a comment - - edited Confirmed on 5.4, partially. The related object Y disappears from the Relations tab of the full object view, but not from the object view itself. It is not removed from ezcontentobject_link, but the status of the current_version of Y in ezcontentobject is set to 0 (draft) which is why it isn't shown in the related object list. If I edit and publish Y, it shows in the list again. I suspect that this part is wrong or incomplete: https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/datatypes/ezobjectrelationlist/ezobjectrelationlisttype.php#L461 It is ancient though, 2003 or older: https://github.com/ezsystems/ezpublish-legacy/commit/e6647e2e27572395a08c16e9089e6e558de7af69#diff-ba3bb3637db36baecce818bf6091e025R251
          Gunnstein Lye made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 3 hours [ 10800 ]
          Worklog Id 54118 [ 54118 ]
          Gunnstein Lye logged work - 21/Apr/15 2:00 PM - edited
          • Time Spent:
            3 hours, 45 minutes
             

            Working on issue EZP-24198

          Show
          Gunnstein Lye added a comment - - edited PR: https://github.com/ezsystems/ezpublish-legacy/pull/1161 Merged in master: https://github.com/ezsystems/ezpublish-legacy/commit/6ae131d0b0bc3b6f82ccc5e064687d4c3ca36288
          Gunnstein Lye made changes -
          Time Spent 3 hours [ 10800 ] 6 hours, 45 minutes [ 24300 ]
          Worklog Id 54137 [ 54137 ]
          Gunnstein Lye made changes -
          Status Development [ 3 ] Development Review [ 10006 ]
          Gunnstein Lye made changes -
          Worklog Id 54137 [ 54137 ]
          Gunnstein Lye made changes -
          Status Development Review [ 10006 ] Development Review done [ 10028 ]
          Gunnstein Lye logged work - 22/Apr/15 11:00 AM - edited
          • Time Spent:
            45 minutes
             

            Working on issue EZP-24198

          Gunnstein Lye made changes -
          Affects Version/s 5.3.5 [ 13889 ]
          Affects Version/s 5.2 [ 12582 ]
          Affects Version/s 5.1 [ 11280 ]
          Affects Version/s 5.0 [ 10300 ]
          Affects Version/s 4.7.0 [ 11010 ]
          Affects Version/s 4.6.0 [ 11005 ]
          Gunnstein Lye made changes -
          Fix Version/s 4.5 Maintenance [ 12585 ]
          Fix Version/s 4.6 Maintenance [ 12584 ]
          Fix Version/s 4.7 Maintenance [ 12583 ]
          Fix Version/s 5.0 Maintenance [ 11287 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Fix Version/s 5.2 Maintenance [ 12782 ]
          Fix Version/s 5.4.3 [ 14184 ]
          Fix Version/s 5.3.6 [ 14185 ]
          Gunnstein Lye made changes -
          Time Spent 6 hours, 45 minutes [ 24300 ] 7 hours, 30 minutes [ 27000 ]
          Worklog Id 54145 [ 54145 ]
          Gunnstein Lye made changes -
          Status Development Review done [ 10028 ] Documentation Review done [ 10011 ]
          Gunnstein Lye made changes -
          Worklog Id 54145 [ 54145 ]
          Rui Silva (Inactive) made changes -
          Status Documentation Review done [ 10011 ] QA [ 10008 ]
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ] Rui Silva [ rui.silva@ez.no ]
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for 4.5, 4.6, 4.7, 5.0, 5.1, 5.2, 5.3, 5.4 and master.
          Issue could not be reproduced on a 5.1 and 5.2, so sanity testes were made in the scope. Thus, the suggested fixes applied for said versions didn't seemingly change any behaviour.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for 4.5, 4.6, 4.7, 5.0, 5.1, 5.2, 5.3, 5.4 and master. Issue could not be reproduced on a 5.1 and 5.2, so sanity testes were made in the scope. Thus, the suggested fixes applied for said versions didn't seemingly change any behaviour.
          Rui Silva (Inactive) made changes -
          Assignee Rui Silva [ rui.silva@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 66585 ] EZ* Development Workflow [ 85793 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 85793 ] EZEE Development Workflow [ 124708 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          8m 39s 1 Paulo Bras (Inactive) 27/Mar/15 5:10 PM
          Confirmed Confirmed InputQ InputQ
          2d 15h 47m 1 yannick.roger@ez.no 30/Mar/15 9:57 AM
          InputQ InputQ Development Development
          21d 5h 10m 1 Gunnstein Lye 20/Apr/15 3:08 PM
          Development Development Development Review Development Review
          1d 34m 1 Gunnstein Lye 21/Apr/15 3:43 PM
          Development Review Development Review Development Review done Development Review done
          19h 13m 1 Gunnstein Lye 22/Apr/15 10:56 AM
          Development Review done Development Review done Documentation Review done Documentation Review done
          17m 36s 1 Gunnstein Lye 22/Apr/15 11:14 AM
          Documentation Review done Documentation Review done QA QA
          1h 43m 1 rui.silva@ez.no 22/Apr/15 12:58 PM
          QA QA Closed Closed
          22h 47m 1 rui.silva@ez.no 23/Apr/15 11:45 AM

            People

            • Assignee:
              Unassigned
              Reporter:
              Paulo Bras (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 30 minutes
                7h 30m