Details

      Description

      Option for returning unlimited number of search hits needs to be removed.

      While this worked with relational database (Legacy Search Engine), Solr and Elasticsearch were never made to provide for this. Using big number to fake unlimited (1073741824 for Legacy Search Engine) routinely causes OOM exceptions with Solr and Elasticsearch.

      Solr and Elasticsearch were made to work with returning relatively small number of hits, providing paging/scrolling for the case when full set is required.

      Null as an alias for unlimited in Query objects should be removed, but also other service methods that rely on search should be updated.
      Limit should always be expected to be set to a definite number.

        Issue Links

          Activity

          Hide
          Petar Spanja (Inactive) added a comment -

          It seems unlimited size is not possible in Elasticsearch, so we might want to add default limit value to the API Query object.

          Show
          Petar Spanja (Inactive) added a comment - It seems unlimited size is not possible in Elasticsearch, so we might want to add default limit value to the API Query object.
          Hide
          Petar Spanja (Inactive) added a comment -

          Also valid for Solr.

          Elasticsearch and Solr were not built for returning complete set of search hits. Current limit in service is set to 1073741824.
          That works with relational database, but with Solr (particularly multicore) and Elasticsearch causes OOM exceptions.

          Show
          Petar Spanja (Inactive) added a comment - Also valid for Solr. Elasticsearch and Solr were not built for returning complete set of search hits. Current limit in service is set to 1073741824. That works with relational database, but with Solr (particularly multicore) and Elasticsearch causes OOM exceptions.
          Show
          Petar Spanja (Inactive) added a comment - Pull request: https://github.com/ezsystems/ezpublish-kernel/pull/1257
          Show
          Petar Spanja (Inactive) added a comment - Merged to ezpublish-kernel/master in https://github.com/ezsystems/ezpublish-kernel/commit/8e6e38e1589ee75085dba38e9b5cc450d4224fb6
          Hide
          Rui Silva (Inactive) added a comment -

          Tested and approved by QA for master.

          Show
          Rui Silva (Inactive) added a comment - Tested and approved by QA for master.

            People

            • Assignee:
              Unassigned
              Reporter:
              Petar Spanja (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 15 minutes
                3h 15m