Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-23289

Add support for view parameters to layout module views

    Details

    • Type: Feature Feature
    • Status: Declined
    • Priority: Medium Medium
    • Resolution: Obsolete
    • Affects Version/s: 2014.07
    • Fix Version/s: None
    • Component/s: Misc
    • Labels:
    • Environment:

      n/a

      Description

      We'll be brief this time around.

      We were verbose in our first introduction of this feature back in 2012 and that didn't help anyone. To read our original introduction please read this pull request title and first comment: https://github.com/ezsystems/ezpublish-legacy/pull/284#issue-2929770

      In short: eZ Publish layout/set module view has lacked view parameter support.

      It lacks this support even though the layout/set module view can be used to view existing module views and templates which already expect view parameter support as provided by the content module.

      This creates serious template variable conflicts for existing content view templates.

      Our simple code improvement brings in layman's terms view parameter support to the layout module indirectly.

      It does this by providing view parameters to other module views which make use of eZModule:STATUS_RERUN requests ie: custom modules or modified copies of the layout module in extensions.

      Thank you for your continued support!

      Cheers,
      Brookins Consulting

        Activity

        Hide
        Brookins Consulting added a comment -

        Hello,

        We have updated and refactored our original pull request commit content to use the very latest version of the code.

        You can review our new commit changes here: https://github.com/ezsystems/ezpublish-legacy/pull/284/files

        Cheers,
        Brookins Consulting

        Show
        Brookins Consulting added a comment - Hello, We have updated and refactored our original pull request commit content to use the very latest version of the code. You can review our new commit changes here: https://github.com/ezsystems/ezpublish-legacy/pull/284/files Cheers, Brookins Consulting
        Hide
        Brookins Consulting added a comment - - edited

        Hello,

        Some apologies are in order. It's been quite some time since we last tested this patch. And Jérôme's pull request comments are right.

        More over it seems this pull request is no longer needed. View parameters are indeed already available within the layout/set module view pagelayout and content view templates after all.

        Either something wonderful has changed in the last two and a half years ago since we last tested or we were mistaken to begin with.

        Either way. We will test harder before submitting our next pull request. Thanks again and apologies for the trouble.

        So in any case. This pull request issue can be closed.

        Respectfully,
        Brookins Consulting

        Show
        Brookins Consulting added a comment - - edited Hello, Some apologies are in order. It's been quite some time since we last tested this patch. And Jérôme's pull request comments are right. More over it seems this pull request is no longer needed. View parameters are indeed already available within the layout/set module view pagelayout and content view templates after all. Either something wonderful has changed in the last two and a half years ago since we last tested or we were mistaken to begin with. Either way. We will test harder before submitting our next pull request. Thanks again and apologies for the trouble. So in any case. This pull request issue can be closed. Respectfully, Brookins Consulting

          People

          • Assignee:
            Unassigned
            Reporter:
            Brookins Consulting
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 hour
              1h
              Remaining:
              Remaining Estimate - 1 hour
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified