Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-23124

eZ Flow block items in v1 of content aren't synced correctly

    Details

      Description

      When syncing version 1 of content with an ezpage attribute, no valid nodes will be returned on the target server.

      In the database, the following fields are incorrect:

      • ezm_block.node_id is set to 0, while it should be set to the synced node id
      • ezm_pool.ts_valid is set to 0 as well, while a ts_valid > 0 condition is used in the query that fetches valid nodes.

      The node_id problem occurs because when processing the attributes in models/field.php, the object hasn't been published, and doesn't have a node id: https://github.com/ezsystems/ezcontentstaging/blob/custom-4.7.1/classes/models/field.php#L722.

        Issue Links

          Activity

          Bertrand Dunogier created issue -
          Bertrand Dunogier made changes -
          Field Original Value New Value
          Link This issue discovered while testing EZP-23052 [ EZP-23052 ]
          Hide
          Bertrand Dunogier added a comment -

          This mostly comes from the differences between normal eZPageType and the way staging handles it:

          • eZPageType stores an XML with zone/block/item "action" attributes (add, remove, modify). Those are processes in onPublish to create/modify/remove elements from ezm_block and ezm_pool. It then stores a modified XML to data_text that only contains zone + block, and no item info.
          • Staging builds a custom payload with the list of zones, blocks and itemsn and processes it back when creating content.

          I see two ways to fix this:

          • post process ezpage attributes, and fix invalid ezm_block.node_id fields (ts_valid is probably something else)
          • stop using this custom payload, and re-create an XML that behaves likes the one used by staging. It is identical, except for the list of items and the action attributes. The only thing is that we can probably not re-create the remove/modify actions, but it shouldn't be a problem if we keep erasing the blocks & items on the target server first, like it is currently done.
          Show
          Bertrand Dunogier added a comment - This mostly comes from the differences between normal eZPageType and the way staging handles it: eZPageType stores an XML with zone/block/item "action" attributes (add, remove, modify). Those are processes in onPublish to create/modify/remove elements from ezm_block and ezm_pool . It then stores a modified XML to data_text that only contains zone + block, and no item info. Staging builds a custom payload with the list of zones, blocks and itemsn and processes it back when creating content. I see two ways to fix this: post process ezpage attributes, and fix invalid ezm_block.node_id fields (ts_valid is probably something else) stop using this custom payload, and re-create an XML that behaves likes the one used by staging. It is identical, except for the list of items and the action attributes. The only thing is that we can probably not re-create the remove/modify actions, but it shouldn't be a problem if we keep erasing the blocks & items on the target server first, like it is currently done.
          Bertrand Dunogier made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Bertrand Dunogier made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Fix Version/s 5.4 [ 13180 ]
          Hide
          Bertrand Dunogier added a comment -
          Show
          Bertrand Dunogier added a comment - Pull-request https://github.com/ezsystems/ezflow/pull/63 .
          Bertrand Dunogier made changes -
          Remote Link This issue links to "PR ezsystems/ezflow#63 (Web Link)" [ 14202 ]
          Marcos Loureiro (Inactive) made changes -
          Link This issue relates to EZP-23130 [ EZP-23130 ]
          André Rømcke made changes -
          Fix Version/s 5.3.3 [ 13484 ]
          Bertrand Dunogier made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Hide
          Bertrand Dunogier added a comment -

          Merged to ezflow/master @ 7d863be.

          Show
          Bertrand Dunogier added a comment - Merged to ezflow/master @ 7d863be .
          Bertrand Dunogier made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Pedro Resende (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Pedro Resende [ pedro.resende@ez.no ]
          Paulo Nunes (Inactive) made changes -
          Assignee Pedro Resende [ pedro.resende@ez.no ] Eduardo Fernandes [ eduardo.fernandes@ez.no ]
          Eduardo Fernandes (Inactive) made changes -
          Rank Ranked higher
          Eduardo Fernandes (Inactive) made changes -
          Status QA [ 10008 ] InputQ [ 10001 ]
          Assignee Eduardo Fernandes [ eduardo.fernandes@ez.no ]
          André Rømcke made changes -
          Flagged Impediment [ 10000 ]
          André Rømcke made changes -
          Fix Version/s 4.7 Maintenance [ 12583 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Fix Version/s 5.2 Maintenance [ 12782 ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Documentation done [ 10011 ]
          Eduardo Fernandes (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Eduardo Fernandes [ eduardo.fernandes@ez.no ]
          Hide
          Eduardo Fernandes (Inactive) added a comment -

          QA Tested and Approved

          Show
          Eduardo Fernandes (Inactive) added a comment - QA Tested and Approved
          Eduardo Fernandes (Inactive) made changes -
          Assignee Eduardo Fernandes [ eduardo.fernandes@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 63818 ] EZ* Development Workflow [ 85197 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 85197 ] EZEE Development Workflow [ 123991 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          19h 27m 1 Bertrand Dunogier 08/Jul/14 4:27 PM
          Confirmed Confirmed InputQ InputQ
          2s 1 Bertrand Dunogier 08/Jul/14 4:27 PM
          Development Development Development Review Development Review
          14s 1 Bertrand Dunogier 08/Jul/14 4:28 PM
          Development Review Development Review Development Review done Development Review done
          76d 17h 47m 1 Bertrand Dunogier 23/Sep/14 10:15 AM
          Development Review done Development Review done Documentation Review done Documentation Review done
          13m 4s 1 Bertrand Dunogier 23/Sep/14 10:28 AM
          QA QA InputQ InputQ
          12d 23h 37m 1 eduardo.fernandes@ez.no 07/Oct/14 9:33 AM
          InputQ InputQ Development Development
          2d 7h 9m 2 Bertrand Dunogier 09/Oct/14 4:42 PM
          Development Development Documentation Review done Documentation Review done
          3d 19h 15m 1 Bertrand Dunogier 13/Oct/14 11:57 AM
          Documentation Review done Documentation Review done QA QA
          23h 29m 2 eduardo.fernandes@ez.no 13/Oct/14 12:00 PM
          QA QA Closed Closed
          16s 1 eduardo.fernandes@ez.no 13/Oct/14 12:00 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Bertrand Dunogier
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: