Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-22685

Embed images displayed side-by-side in Online Editor

    Details

      Description

      Embed images are displayed in eZOE side-by-side, what shouldn't happen according to Object embedding documentation page. See attached bug-001.png image.

      With this tag, embedded objects are inserted as "block elements". Such an element always begins on a new line when it is displayed. It exists in its own virtual box and is always followed by a carriage return (like if someone hit the "Enter" key after inserting the object). This means that, for example, inserting an image using the "embed" tag will break the current paragraph. The "embed" tag is represented by block-level tags in the resulting XHTML code.

      In fact, if you insert an embed file object, it will be a block element not allowing anything in the same line. See attached bug-002.png image.

      The behavior of embed image and file elements should be the same.

      Steps to Reproduce

      1. In eZOE, add an embed image according to attached bug-001.png image.
      2. Add a second embed image in the same line according to attached bug-001.png image.
        See that both images are side-by-side.
      3. Add an embed file element.
        See that the file won't allow anything else in the line.
      1. bug-001.png
        47 kB
      2. bug-002.png
        36 kB
      3. capture_001.png
        61 kB
      4. capture_002.png
        42 kB
      5. capture_003.png
        42 kB
      6. capture_004.png
        42 kB
      7. capture_005.png
        54 kB

        Issue Links

          Activity

          Eduardo Fernandes (Inactive) created issue -
          Eduardo Fernandes (Inactive) made changes -
          Field Original Value New Value
          Attachment bug-001.png [ 18265 ]
          Attachment bug-002.png [ 18266 ]
          Eduardo Fernandes (Inactive) made changes -
          Description Embed images are displayed in eZOE side-by-side, what shouldn't happen according to [Object embedding documentation page|http://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Datatypes/XML-block/Object-embedding]. See attached bug-001.png image.

          In fact, if you insert an embed file object, it will be a block element not allowing anything in the same line. See attached bug-002.png image.

          The behavior of embed image and file elements should be the same.

          h1. Steps to Reproduce
          # In eZOE, add an embed image according to attached bug-001.png image.
          # Add a second embed image in the same line according to attached bug-001.png image.
          See that both images are side-by-side.
          # Add an embed file element.
          See that the file won't allow anything else in the line.
          Embed images are displayed in eZOE side-by-side, what shouldn't happen according to [Object embedding documentation page|http://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Datatypes/XML-block/Object-embedding]. See attached bug-001.png image.

          {quote}
          With this tag, embedded objects are inserted as "block elements". Such an element always begins on a new line when it is displayed. It exists in its own virtual box and is always followed by a carriage return (like if someone hit the "Enter" key after inserting the object). This means that, for example, inserting an image using the "embed" tag will break the current paragraph. The "embed" tag is represented by block-level tags in the resulting XHTML code.
          {quote}

          In fact, if you insert an embed file object, it will be a block element not allowing anything in the same line. See attached bug-002.png image.

          The behavior of embed image and file elements should be the same.

          h1. Steps to Reproduce
          # In eZOE, add an embed image according to attached bug-001.png image.
          # Add a second embed image in the same line according to attached bug-001.png image.
          See that both images are side-by-side.
          # Add an embed file element.
          See that the file won't allow anything else in the line.
          Eduardo Fernandes (Inactive) made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Eduardo Fernandes (Inactive) made changes -
          Description Embed images are displayed in eZOE side-by-side, what shouldn't happen according to [Object embedding documentation page|http://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Datatypes/XML-block/Object-embedding]. See attached bug-001.png image.

          {quote}
          With this tag, embedded objects are inserted as "block elements". Such an element always begins on a new line when it is displayed. It exists in its own virtual box and is always followed by a carriage return (like if someone hit the "Enter" key after inserting the object). This means that, for example, inserting an image using the "embed" tag will break the current paragraph. The "embed" tag is represented by block-level tags in the resulting XHTML code.
          {quote}

          In fact, if you insert an embed file object, it will be a block element not allowing anything in the same line. See attached bug-002.png image.

          The behavior of embed image and file elements should be the same.

          h1. Steps to Reproduce
          # In eZOE, add an embed image according to attached bug-001.png image.
          # Add a second embed image in the same line according to attached bug-001.png image.
          See that both images are side-by-side.
          # Add an embed file element.
          See that the file won't allow anything else in the line.
          Embed images are displayed in eZOE side-by-side, what shouldn't happen according to [Object embedding documentation page|http://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Datatypes/XML-block/Object-embedding]. See attached bug-001.png image.

          {quote}
          With this tag, embedded objects are inserted as "block elements". Such an element always begins on a new line when it is displayed. It exists in its own virtual box and is always followed by a carriage return (like if someone hit the "Enter" key after inserting the object). This means that, for example, inserting an image using the "embed" tag will break the current paragraph. The "embed" tag is represented by block-level tags in the resulting XHTML code.
          {quote}

          In fact, if you insert an embed file object, it will be a block element not allowing anything in the same line. See attached bug-002.png image.

          The behavior of embed image and file elements should be the same.

          h3. Steps to Reproduce
          # In eZOE, add an embed image according to attached bug-001.png image.
          # Add a second embed image in the same line according to attached bug-001.png image.
          See that both images are side-by-side.
          # Add an embed file element.
          See that the file won't allow anything else in the line.
          André Rømcke made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          André Rømcke made changes -
          Assignee Damien Pobel [ damien.pobel@ez.no ]
          Damien Pobel (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Damien Pobel (Inactive) made changes -
          Summary Embed images displayed side-by-side in eZOE Embed images displayed side-by-side in Online Editor
          Show
          Damien Pobel (Inactive) added a comment - PR: https://github.com/ezsystems/ezpublish-legacy/pull/959
          Damien Pobel (Inactive) made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Damien Pobel (Inactive) made changes -
          Remote Link This issue links to "PR (Web Link)" [ 14065 ]
          Damien Pobel (Inactive) made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Show
          Damien Pobel (Inactive) added a comment - Fixed in ezpublish-legacy: master: https://github.com/ezsystems/ezpublish-legacy/commit/7b15917dc90c10abb2bd78f5f59b8ee8e1579044
          Damien Pobel (Inactive) made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Damien Pobel (Inactive) made changes -
          Fix Version/s 5.3 [ 11282 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Fix Version/s 5.2 Maintenance [ 12782 ]
          Damien Pobel (Inactive) made changes -
          Fix Version/s 2014.05 [ 13480 ]
          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Damien Pobel [ damien.pobel@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Joao Pingo (Inactive) made changes -
          Attachment Screenshot.png [ 18294 ]
          Joao Pingo (Inactive) made changes -
          Flagged Impediment [ 10000 ]
          Joao Pingo (Inactive) made changes -
          Comment [ Screenshot from Master ]
          Joao Pingo (Inactive) made changes -
          Comment [ @Damien
          Just tested on Master ( the patch is already applied ) and the images are still side by side ]
          Joao Pingo (Inactive) made changes -
          Flagged Impediment [ 10000 ]
          Joao Pingo (Inactive) made changes -
          Attachment Screenshot.png [ 18294 ]
          Hide
          Joao Pingo (Inactive) added a comment -

          QA Approved

          Show
          Joao Pingo (Inactive) added a comment - QA Approved
          Joao Pingo (Inactive) made changes -
          Assignee Joao Pingo [ joao.pingo@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Joao Pingo (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Joao Pingo (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 5 hours [ 18000 ]
          Worklog Id 48139 [ 48139 ]
          Joao Pingo (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Joao Pingo (Inactive) logged work - 13/May/14 4:43 PM
          • Time Spent:
            5 hours
             

            Tested and closed

          Eduardo Fernandes (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Eduardo Fernandes (Inactive) made changes -
          Status Reopened [ 4 ] Confirmed [ 10037 ]
          Paulo Lopes (Inactive) made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Eduardo Fernandes (Inactive) made changes -
          Attachment capture_001.png [ 18315 ]
          Attachment capture_002.png [ 18316 ]
          Attachment capture_003.png [ 18317 ]
          Attachment capture_004.png [ 18318 ]
          Attachment capture_005.png [ 18319 ]
          Hide
          Eduardo Fernandes (Inactive) added a comment -

          Attached image codes

          <strong>TWO IMAGES:</strong>
          <embed view="embed" size="medium" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" custom:offset="0" custom:limit="5" href="ezobject://119" /><strong>NOT INLINE, NOT ALIGNED</strong>

          <strong>TWO IMAGES:</strong>
          <embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><strong>NOT INLINE, LEFT ALIGNED</strong>

          <strong>TWO IMAGES:</strong>
          <embed-inline view="embed-inline" size="medium" href="ezobject://123" /><embed-inline view="embed-inline" size="medium" href="ezobject://123" /><strong>INLINE, NOT ALIGNED</strong>

          <strong>TWO IMAGES:</strong>
          <embed-inline view="embed-inline" size="medium" align="left" href="ezobject://124" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://124" /><strong>INLINE, LEFT ALIGNED</strong>

          <strong>FOUR IMAGES:</strong>
          <embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed-inline view="embed-inline" size="medium" align="left" href="ezobject://124" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://124" /><strong>TWO NOT INLINE, LEFT ALIGNED</strong><strong>TWO INLINE, LEFT ALIGNED</strong>

          Show
          Eduardo Fernandes (Inactive) added a comment - Attached image codes <strong>TWO IMAGES:</strong> <embed view="embed" size="medium" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" custom:offset="0" custom:limit="5" href="ezobject://119" /><strong>NOT INLINE, NOT ALIGNED</strong> <strong>TWO IMAGES:</strong> <embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><strong>NOT INLINE, LEFT ALIGNED</strong> <strong>TWO IMAGES:</strong> <embed-inline view="embed-inline" size="medium" href="ezobject://123" /><embed-inline view="embed-inline" size="medium" href="ezobject://123" /><strong>INLINE, NOT ALIGNED</strong> <strong>TWO IMAGES:</strong> <embed-inline view="embed-inline" size="medium" align="left" href="ezobject://124" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://124" /><strong>INLINE, LEFT ALIGNED</strong> <strong>FOUR IMAGES:</strong> <embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://119" /><embed-inline view="embed-inline" size="medium" align="left" href="ezobject://124" /><embed view="embed" size="medium" align="left" custom:offset="0" custom:limit="5" href="ezobject://124" /><strong>TWO NOT INLINE, LEFT ALIGNED</strong><strong>TWO INLINE, LEFT ALIGNED</strong>
          André Rømcke made changes -
          Assignee Damien Pobel [ damien.pobel@ez.no ]
          Damien Pobel (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Damien Pobel (Inactive) made changes -
          Link This issue relates to EZP-22928 [ EZP-22928 ]
          Hide
          Damien Pobel (Inactive) added a comment -

          Eduardo: this is a different issue being handled in https://jira.ez.no/browse/EZP-22685

          Show
          Damien Pobel (Inactive) added a comment - Eduardo: this is a different issue being handled in https://jira.ez.no/browse/EZP-22685
          Hide
          Damien Pobel (Inactive) added a comment -

          The issue is already fixed, the second one reported in the comment is being handled in EZP-22928.

          Show
          Damien Pobel (Inactive) added a comment - The issue is already fixed, the second one reported in the comment is being handled in EZP-22928 .
          Damien Pobel (Inactive) made changes -
          Assignee Damien Pobel [ damien.pobel@ez.no ]
          Status Development [ 3 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 62866 ] EZ* Development Workflow [ 84964 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84964 ] EZEE Development Workflow [ 123698 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          3m 1s 1 eduardo.fernandes@ez.no 22/Apr/14 2:55 PM
          Development Development Development Review Development Review
          1h 17m 1 damien.pobel@ez.no 12/May/14 12:09 PM
          Development Review Development Review Development Review done Development Review done
          21h 44m 1 damien.pobel@ez.no 13/May/14 9:54 AM
          Development Review done Development Review done Documentation Review done Documentation Review done
          48s 1 damien.pobel@ez.no 13/May/14 9:55 AM
          Documentation Review done Documentation Review done QA QA
          28m 16s 1 Joao Pingo (Inactive) 13/May/14 10:23 AM
          QA QA Closed Closed
          5h 17m 1 Joao Pingo (Inactive) 13/May/14 3:41 PM
          Reopened Reopened Closed Closed
          0s 1 Joao Pingo (Inactive) 13/May/14 3:44 PM
          Closed Closed Reopened Reopened
          6d 27m 2 eduardo.fernandes@ez.no 19/May/14 4:09 PM
          Reopened Reopened Confirmed Confirmed
          4m 13s 1 eduardo.fernandes@ez.no 19/May/14 4:13 PM
          Confirmed Confirmed InputQ InputQ
          12d 9h 28m 2 Paulo Lopes (Inactive) 19/May/14 4:29 PM
          InputQ InputQ Development Development
          14d 4h 34m 2 damien.pobel@ez.no 26/May/14 10:19 AM
          Development Development Closed Closed
          2h 2m 1 damien.pobel@ez.no 26/May/14 12:22 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Eduardo Fernandes (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours
                5h