Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-22466

Related Objects editing not saved when AdvancedObjectRelationList is used

    Details

      Description

      If you edit a related object with "AdvancedObjectRelationList=enabled", the changes will be lost after publishing

      Steps to reproduce

      1. Edit site.ini and add the following settings

        [BackwardCompatibilitySettings]
        AdvancedObjectRelationList=enabled
        

      2. Clear the caches
      3. Make a copy of the article class and name it "New Article"
      4. Add an "Object Relations" attribute to "New Article"
      5. Create a new "New Article" content object and Add some existent content to its "Object Relations" attribute. Publish it.
      6. In the front end, open the newly created content object and edit it.
      7. Select one of the items in "Object Relations" attribute and edit it.
      8. Change the title of related object to something else.
      9. Click the publish button.
        The changes to the title of the related object will be lost.

      Repeat the steps above, but:

      1. Do not change the title
      2. Change any other field instead

        Issue Links

          Activity

          Hide
          Bertrand Dunogier added a comment -

          Note: after testing, the issue ain't that only the first attribute is updated. It is that some types are not. As far as I could see, it only affects XmlText.

          Thank you for your feedback, Jérôme. Since this patch affects ezobjectrelationlisttype.php, it is perfectly possible that it creates this regression.

          Show
          Bertrand Dunogier added a comment - Note: after testing, the issue ain't that only the first attribute is updated. It is that some types are not. As far as I could see, it only affects XmlText. Thank you for your feedback, Jérôme. Since this patch affects ezobjectrelationlisttype.php, it is perfectly possible that it creates this regression.
          Hide
          Bertrand Dunogier added a comment -

          New PR: https://github.com/ezsystems/ezpublish-legacy/pull/923

          Introduces a new (simpler) fix, and reverts the previous fix.

          Show
          Bertrand Dunogier added a comment - New PR: https://github.com/ezsystems/ezpublish-legacy/pull/923 Introduces a new (simpler) fix, and reverts the previous fix.
          Hide
          Bertrand Dunogier added a comment -

          Fix merged to ezpublish-legacy/master @bd1da413.

          Show
          Bertrand Dunogier added a comment - Fix merged to ezpublish-legacy/master @bd1da413 . Revert from previous commit @2f557b8f . Fix @48426e90 .
          Hide
          Pedro Resende (Inactive) added a comment -

          Tested and approved by Q.A.

          Show
          Pedro Resende (Inactive) added a comment - Tested and approved by Q.A.
          Hide
          Bertrand Dunogier added a comment -

          Phew

          Show
          Bertrand Dunogier added a comment - Phew

            People

            • Assignee:
              Unassigned
              Reporter:
              Eduardo Fernandes (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 2 hours
                3d 2h