Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-22315

Use ez_is_field_empty to do the checks in content_fields.html.twig

    Details

    • Sprint:
      Ventoux Sprint 5

      Description

      On the ezimage fieldtype, the check :

      {% block ezimage_field %}
      {% spaceless %}
      {% if field.value %}
      

      Doesn't work and displays invalid elements.

      Instead of doing a quick fix on this specific field (like it has been done on some other ones), we cloud use: https://confluence.ez.no/display/EZP52/ez_is_field_empty

        Issue Links

          Activity

          Yannick Roger (Inactive) logged work - 06/Feb/14 9:17 AM
          • Time Spent:
            6 hours
             
            <No comment>
          Yannick Roger (Inactive) created issue -
          Yannick Roger (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] Confirmed [ 10037 ]
          Yannick Roger (Inactive) made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Yannick Roger (Inactive) made changes -
          Status InputQ [ 10001 ] Specification [ 10002 ]
          Assignee Yannick Roger [ yannick.roger@ez.no ]
          Yannick Roger (Inactive) made changes -
          Status Specification [ 10002 ] Specification done [ 10003 ]
          Yannick Roger (Inactive) made changes -
          Status Specification done [ 10003 ] Development [ 3 ]
          Yannick Roger (Inactive) logged work - 07/Feb/14 1:00 AM
          • Time Spent:
            6 hours
             

            .

          Yannick Roger (Inactive) logged work - 10/Feb/14 1:00 AM
          • Time Spent:
            6 hours
             

            unit test.

          Yannick Roger (Inactive) logged work - 11/Feb/14 1:00 AM
          • Time Spent:
            6 hours
             

            unit test.

          Yannick Roger (Inactive) made changes -
          Link This issue relates to EZP-20502 [ EZP-20502 ]
          Hide
          Yannick Roger (Inactive) added a comment -

          Looks like the quick fix has been done on EZP-20502

          Show
          Yannick Roger (Inactive) added a comment - Looks like the quick fix has been done on EZP-20502
          Show
          Yannick Roger (Inactive) added a comment - PR: https://github.com/ezsystems/ezpublish-kernel/pull/729
          Yannick Roger (Inactive) made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Hide
          Yannick Roger (Inactive) added a comment - - edited
          Show
          Yannick Roger (Inactive) added a comment - - edited Documentation updated: https://confluence.ez.no/display/EZP/ez_is_field_empty
          André Rømcke made changes -
          Remaining Estimate 1 day [ 28800 ]
          André Rømcke made changes -
          Original Estimate 1 day [ 28800 ]
          André Rømcke made changes -
          Sprint Ventoux Sprint 5 [ 27 ]
          André Rømcke made changes -
          Rank Ranked higher
          Show
          Yannick Roger (Inactive) added a comment - Fixed in master: https://github.com/ezsystems/ezpublish-kernel/commit/c4d5e0de95e4d99b2aee7857f6c950707304ca2c
          Yannick Roger (Inactive) made changes -
          Remaining Estimate 1 day [ 28800 ] 2 hours [ 7200 ]
          Time Spent 6 hours [ 21600 ]
          Worklog Id 45585 [ 45585 ]
          Yannick Roger (Inactive) made changes -
          Remaining Estimate 2 hours [ 7200 ] 0 minutes [ 0 ]
          Time Spent 6 hours [ 21600 ] 1 day, 4 hours [ 43200 ]
          Worklog Id 45586 [ 45586 ]
          Yannick Roger (Inactive) made changes -
          Time Spent 1 day, 4 hours [ 43200 ] 2 days, 2 hours [ 64800 ]
          Worklog Id 45587 [ 45587 ]
          Yannick Roger (Inactive) made changes -
          Time Spent 2 days, 2 hours [ 64800 ] 3 days [ 86400 ]
          Worklog Id 45588 [ 45588 ]
          Yannick Roger (Inactive) made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Yannick Roger (Inactive) made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Fix Version/s 5.3 [ 11282 ]
          Marcos Loureiro (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Yannick Roger [ yannick.roger@ez.no ] Marcos Loureiro [ marcos.loureiro@ez.no ]
          Marcos Loureiro (Inactive) logged work - 14/Feb/14 5:36 PM
          • Time Spent:
            4 hours, 30 minutes
             

            testing
            writing test
            automating

          Marcos Loureiro (Inactive) made changes -
          Time Spent 3 days [ 86400 ] 3 days, 4 hours, 30 minutes [ 102600 ]
          Worklog Id 45663 [ 45663 ]
          Hide
          Marcos Loureiro (Inactive) added a comment -

          QA Approved

          Show
          Marcos Loureiro (Inactive) added a comment - QA Approved
          Marcos Loureiro (Inactive) made changes -
          Assignee Marcos Loureiro [ marcos.loureiro@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Gaetano Giunta (Inactive) added a comment -

          without looking at the code: does this carry some performance hit (ez_field_is_empty doing more stuff than the previous solution) ?

          Show
          Gaetano Giunta (Inactive) added a comment - without looking at the code: does this carry some performance hit (ez_field_is_empty doing more stuff than the previous solution) ?
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 61660 ] EZ* Development Workflow [ 84736 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84736 ] EZEE Development Workflow [ 123429 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          19s 1 yannick.roger@ez.no 06/Feb/14 5:54 PM
          Confirmed Confirmed InputQ InputQ
          9s 1 yannick.roger@ez.no 06/Feb/14 5:55 PM
          InputQ InputQ Specification Specification
          8s 1 yannick.roger@ez.no 06/Feb/14 5:55 PM
          Specification Specification Specification Done Specification Done
          8s 1 yannick.roger@ez.no 06/Feb/14 5:55 PM
          Specification Done Specification Done Development Development
          3s 1 yannick.roger@ez.no 06/Feb/14 5:55 PM
          Development Development Development Review Development Review
          4d 22h 32m 1 yannick.roger@ez.no 11/Feb/14 4:28 PM
          Development Review Development Review Development Review done Development Review done
          2d 17h 20m 1 yannick.roger@ez.no 14/Feb/14 9:48 AM
          Development Review done Development Review done Documentation Review done Documentation Review done
          26s 1 yannick.roger@ez.no 14/Feb/14 9:48 AM
          Documentation Review done Documentation Review done QA QA
          2h 49m 1 Marcos Loureiro (Inactive) 14/Feb/14 12:38 PM
          QA QA Closed Closed
          5h 1m 1 Marcos Loureiro (Inactive) 14/Feb/14 5:39 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Yannick Roger (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 4 hours, 30 minutes
                3d 4h 30m

                  Agile