Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-22315

Use ez_is_field_empty to do the checks in content_fields.html.twig

    Details

    • Sprint:
      Ventoux Sprint 5

      Description

      On the ezimage fieldtype, the check :

      {% block ezimage_field %}
      {% spaceless %}
      {% if field.value %}
      

      Doesn't work and displays invalid elements.

      Instead of doing a quick fix on this specific field (like it has been done on some other ones), we cloud use: https://confluence.ez.no/display/EZP52/ez_is_field_empty

        Issue Links

          Activity

          Hide
          Gaetano Giunta (Inactive) added a comment -

          without looking at the code: does this carry some performance hit (ez_field_is_empty doing more stuff than the previous solution) ?

          Show
          Gaetano Giunta (Inactive) added a comment - without looking at the code: does this carry some performance hit (ez_field_is_empty doing more stuff than the previous solution) ?
          Hide
          Marcos Loureiro (Inactive) added a comment -

          QA Approved

          Show
          Marcos Loureiro (Inactive) added a comment - QA Approved
          Show
          Yannick Roger (Inactive) added a comment - Fixed in master: https://github.com/ezsystems/ezpublish-kernel/commit/c4d5e0de95e4d99b2aee7857f6c950707304ca2c
          Hide
          Yannick Roger (Inactive) added a comment - - edited
          Show
          Yannick Roger (Inactive) added a comment - - edited Documentation updated: https://confluence.ez.no/display/EZP/ez_is_field_empty
          Show
          Yannick Roger (Inactive) added a comment - PR: https://github.com/ezsystems/ezpublish-kernel/pull/729
          Hide
          Yannick Roger (Inactive) added a comment -

          Looks like the quick fix has been done on EZP-20502

          Show
          Yannick Roger (Inactive) added a comment - Looks like the quick fix has been done on EZP-20502

            People

            • Assignee:
              Unassigned
              Reporter:
              Yannick Roger (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day Original Estimate - 1 day
                1d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 4 hours, 30 minutes
                3d 4h 30m

                  Agile