Details

    • Type: Story Story
    • Status: Closed
    • Priority: High High
    • Resolution: Fixed
    • Affects Version/s: Engineering tracked issues
    • Fix Version/s: 2014.11, 5.4.0-beta1
    • Component/s: Platform stack
    • Labels:
    • Epic Link:
    • Sprint:
      Castor Core S4, Castor Core S6, Castor Core S7
    • Story Points:
      3

      Description

      Currently, a legacy callback is used for image alias generation (see eZ\Publish\Core\MVC\Legacy\Image\AliasGenerator).

      We should implement a new one, not based on the legacy kernel and having the same behavior.

      Imagine library might be used for this purpose.

        Issue Links

          Activity

          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited PRs: ezpublish-kernel: https://github.com/ezsystems/ezpublish-kernel/pull/952 ezpublish-legacy: https://github.com/ezsystems/ezpublish-legacy/pull/1079 ezpublish-community: https://github.com/ezsystems/ezpublish-community/pull/187
          Hide
          Jérôme Vieilledent (Inactive) added a comment - - edited

          Follow-up issues:

          • EZP-23367: Implement a find() method in IOService
          • EZP-23368: Migrate image filters leftovers
          • EZP-23369: Change alias path to have variation name first
          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited Follow-up issues: EZP-23367 : Implement a find() method in IOService EZP-23368 : Migrate image filters leftovers EZP-23369 : Change alias path to have variation name first
          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited Implemented in: ezpublish-legacy: https://github.com/ezsystems/ezpublish-legacy/commit/4010254636cbc8290fc6712dbdc9d2bc4805d2e3 ezpublish-community: https://github.com/ezsystems/ezpublish-community/commit/bb0d93ac514edc303f3c545acbe46a92ac7bf1ad ezpublish-kernel: https://github.com/ezsystems/ezpublish-kernel/commit/69291405a877ddfced76ea42ff405233f05d3ed0
          Show
          Jérôme Vieilledent (Inactive) added a comment - Doc: https://doc.ez.no/display/EZP/Image+alias+generation
          Hide
          Pedro Resende (Inactive) added a comment - - edited

          [~jerome.vieilledent@ez.no]: Using

          liip_imagine:
              driver: ~
          

          Shouldn't it be using gd driver by default ? I'm asking this since

                                                                                                        
            [Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]                 
            Invalid configuration for path "liip_imagine.driver": Invalid imagine driver specified: null  
                                                                                                          
                                                    
            [InvalidArgumentException]              
            Invalid imagine driver specified: null                        
          

          Show
          Pedro Resende (Inactive) added a comment - - edited [~jerome.vieilledent@ez.no] : Using liip_imagine: driver: ~ Shouldn't it be using gd driver by default ? I'm asking this since [Symfony\Component\Config\Definition\Exception\InvalidConfigurationException] Invalid configuration for path "liip_imagine.driver": Invalid imagine driver specified: null [InvalidArgumentException] Invalid imagine driver specified: null
          Hide
          Jérôme Vieilledent (Inactive) added a comment - - edited

          [~pedro.resende@ez.no] This configuration is plain wrong... If you specify a driver you must explicitly mention it. This is pure configuration for liip_image, and it's not mentioned anywhere you can set driver to null. GD is the default, if you don't specify any driver (absent from config).

          More info on LiipImagineBundle config : https://github.com/liip/LiipImagineBundle/blob/master/Resources/doc/configuration.md

          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited [~pedro.resende@ez.no] This configuration is plain wrong... If you specify a driver you must explicitly mention it. This is pure configuration for liip_image , and it's not mentioned anywhere you can set driver to null. GD is the default , if you don't specify any driver (absent from config). More info on LiipImagineBundle config : https://github.com/liip/LiipImagineBundle/blob/master/Resources/doc/configuration.md
          Hide
          Rui Silva (Inactive) added a comment -

          Approved by QA for master.

          Show
          Rui Silva (Inactive) added a comment - Approved by QA for master.

            People

            • Assignee:
              Unassigned
              Reporter:
              Jérôme Vieilledent (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 week
                1w
                Remaining:
                Time Spent - 3 days, 6 hours, 40 minutes Remaining Estimate - 2 hours, 20 minutes
                2h 20m
                Logged:
                Time Spent - 3 days, 6 hours, 40 minutes Remaining Estimate - 2 hours, 20 minutes Time Not Required
                3d 6h 40m

                  Agile