Details

      Description

      this fix EZP-22030 created a regression

      using :

      [BackwardCompatibilitySettings]AdvancedObjectRelationList=enabled
      

      when re-sorting objects of a ezobjectrelationlist, it doesn't save when hitting publish (or even save draft)

      because eZObjectRelationListType::fetchObjectAttributeHTTPInput too early and doesn't check POSTed priorities before return false;

        Issue Links

          Activity

          Hide
          Hamdi Laadhari added a comment -
          Show
          Hamdi Laadhari added a comment - pull request submitted https://github.com/ezsystems/ezpublish-legacy/pull/850
          Hide
          Yannick Roger (Inactive) added a comment -

          Hi,
          Can you provide steps to reproduce.

          I tried creating a new class with a relation list. Added 3 relations. I changed the order of objects in the relation and click on store draft. And the order changes. What is your precise use case ?

          Thanks

          Show
          Yannick Roger (Inactive) added a comment - Hi, Can you provide steps to reproduce. I tried creating a new class with a relation list. Added 3 relations. I changed the order of objects in the relation and click on store draft. And the order changes. What is your precise use case ? Thanks
          Hide
          Hamdi Laadhari added a comment - - edited

          did you integrated EZP-22030 in your test env and try using browse as a selection_type

          Show
          Hamdi Laadhari added a comment - - edited did you integrated EZP-22030 in your test env and try using browse as a selection_type
          Hide
          Hamdi Laadhari added a comment -

          the statement introduced by https://github.com/killerwolf/ezpublish-legacy/commit/240191c7a68bbe33b8a9d6a35d5ab0888b1bdadf is missleading

          type is browse and no http input (data_object_relation_list) is a NORMAL situation (when just resorting relations)
          relations_order are POSTed with a different variable name (*_priority[])

          when looking at content/datatype/edit/ezobjectrelationlist.tpl and the global if statement NO _data_object_relation_list input is set

          Show
          Hamdi Laadhari added a comment - the statement introduced by https://github.com/killerwolf/ezpublish-legacy/commit/240191c7a68bbe33b8a9d6a35d5ab0888b1bdadf is missleading type is browse and no http input ( data_object_relation_list ) is a NORMAL situation (when just resorting relations) relations_order are POSTed with a different variable name (*_priority[]) when looking at content/datatype/edit/ezobjectrelationlist.tpl and the global if statement NO _data_object_relation_list input is set
          Hide
          Yannick Roger (Inactive) added a comment - - edited

          I am using the master branch, so it is using c4a5a0898b4a4a148ca2ca2b7e9ec5c00fcc9e05

          We need to see it break. Can you provide a step by step scenario that shows the regression (I believe you are using the master branch).

          Show
          Yannick Roger (Inactive) added a comment - - edited I am using the master branch, so it is using c4a5a0898b4a4a148ca2ca2b7e9ec5c00fcc9e05 We need to see it break. Can you provide a step by step scenario that shows the regression (I believe you are using the master branch).
          Hide
          Hamdi Laadhari added a comment -

          i just set up a complete new env on cloud9 and managed to make it fail by enabling
          [BackwardCompatibilitySettings]AdvancedObjectRelationList=enabled

          Show
          Hamdi Laadhari added a comment - i just set up a complete new env on cloud9 and managed to make it fail by enabling [BackwardCompatibilitySettings] AdvancedObjectRelationList=enabled
          Hide
          Yannick Roger (Inactive) added a comment -

          Ok with this setting we can reproduce the problem.

          Show
          Yannick Roger (Inactive) added a comment - Ok with this setting we can reproduce the problem.
          Hide
          Hamdi Laadhari added a comment - - edited

          As i understood the problem, i am working on a better solution(not PHP side but TPL side). I'll amend the PR

          Show
          Hamdi Laadhari added a comment - - edited As i understood the problem, i am working on a better solution(not PHP side but TPL side). I'll amend the PR
          Hide
          Yannick Roger (Inactive) added a comment -

          Great. Feel free to ping me here or on github if you need feedback.

          Show
          Yannick Roger (Inactive) added a comment - Great. Feel free to ping me here or on github if you need feedback.
          Hide
          Hamdi Laadhari added a comment -

          PR updated

          Show
          Hamdi Laadhari added a comment - PR updated
          Show
          Yannick Roger (Inactive) added a comment - Fixed in master: https://github.com/ezsystems/ezpublish-legacy/commit/bd8a1684d2c9f83d9a0940800f6c91cc817d4756
          Hide
          Paulo Nunes (Inactive) added a comment -

          QA Approved

          Show
          Paulo Nunes (Inactive) added a comment - QA Approved

            People

            • Assignee:
              Unassigned
              Reporter:
              Hamdi Laadhari
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours
                5h