Details

      Description

      this fix EZP-22030 created a regression

      using :

      [BackwardCompatibilitySettings]AdvancedObjectRelationList=enabled
      

      when re-sorting objects of a ezobjectrelationlist, it doesn't save when hitting publish (or even save draft)

      because eZObjectRelationListType::fetchObjectAttributeHTTPInput too early and doesn't check POSTed priorities before return false;

        Issue Links

          Activity

          Hamdi Laadhari created issue -
          Hide
          Hamdi Laadhari added a comment -
          Show
          Hamdi Laadhari added a comment - pull request submitted https://github.com/ezsystems/ezpublish-legacy/pull/850
          Yannick Roger (Inactive) made changes -
          Field Original Value New Value
          Link This issue relates to EZP-22030 [ EZP-22030 ]
          Hide
          Yannick Roger (Inactive) added a comment -

          Hi,
          Can you provide steps to reproduce.

          I tried creating a new class with a relation list. Added 3 relations. I changed the order of objects in the relation and click on store draft. And the order changes. What is your precise use case ?

          Thanks

          Show
          Yannick Roger (Inactive) added a comment - Hi, Can you provide steps to reproduce. I tried creating a new class with a relation list. Added 3 relations. I changed the order of objects in the relation and click on store draft. And the order changes. What is your precise use case ? Thanks
          Hide
          Hamdi Laadhari added a comment - - edited

          did you integrated EZP-22030 in your test env and try using browse as a selection_type

          Show
          Hamdi Laadhari added a comment - - edited did you integrated EZP-22030 in your test env and try using browse as a selection_type
          Hide
          Hamdi Laadhari added a comment -

          the statement introduced by https://github.com/killerwolf/ezpublish-legacy/commit/240191c7a68bbe33b8a9d6a35d5ab0888b1bdadf is missleading

          type is browse and no http input (data_object_relation_list) is a NORMAL situation (when just resorting relations)
          relations_order are POSTed with a different variable name (*_priority[])

          when looking at content/datatype/edit/ezobjectrelationlist.tpl and the global if statement NO _data_object_relation_list input is set

          Show
          Hamdi Laadhari added a comment - the statement introduced by https://github.com/killerwolf/ezpublish-legacy/commit/240191c7a68bbe33b8a9d6a35d5ab0888b1bdadf is missleading type is browse and no http input ( data_object_relation_list ) is a NORMAL situation (when just resorting relations) relations_order are POSTed with a different variable name (*_priority[]) when looking at content/datatype/edit/ezobjectrelationlist.tpl and the global if statement NO _data_object_relation_list input is set
          Hide
          Yannick Roger (Inactive) added a comment - - edited

          I am using the master branch, so it is using c4a5a0898b4a4a148ca2ca2b7e9ec5c00fcc9e05

          We need to see it break. Can you provide a step by step scenario that shows the regression (I believe you are using the master branch).

          Show
          Yannick Roger (Inactive) added a comment - - edited I am using the master branch, so it is using c4a5a0898b4a4a148ca2ca2b7e9ec5c00fcc9e05 We need to see it break. Can you provide a step by step scenario that shows the regression (I believe you are using the master branch).
          Hide
          Hamdi Laadhari added a comment -

          i just set up a complete new env on cloud9 and managed to make it fail by enabling
          [BackwardCompatibilitySettings]AdvancedObjectRelationList=enabled

          Show
          Hamdi Laadhari added a comment - i just set up a complete new env on cloud9 and managed to make it fail by enabling [BackwardCompatibilitySettings] AdvancedObjectRelationList=enabled
          Yannick Roger (Inactive) made changes -
          Description this fix EZP-22030 created a regression

          when re-sorting objects of a ezobjectrelationlist, it doesn't save when hitting publish (or even save draft)

          because eZObjectRelationListType::fetchObjectAttributeHTTPInput too early and doesn't check POSTed priorities before return false;
          this fix EZP-22030 created a regression

          using :
          {code}
          [BackwardCompatibilitySettings]AdvancedObjectRelationList=enabled
          {code}

          when re-sorting objects of a ezobjectrelationlist, it doesn't save when hitting publish (or even save draft)

          because eZObjectRelationListType::fetchObjectAttributeHTTPInput too early and doesn't check POSTed priorities before return false;
          Hide
          Yannick Roger (Inactive) added a comment -

          Ok with this setting we can reproduce the problem.

          Show
          Yannick Roger (Inactive) added a comment - Ok with this setting we can reproduce the problem.
          Hide
          Hamdi Laadhari added a comment - - edited

          As i understood the problem, i am working on a better solution(not PHP side but TPL side). I'll amend the PR

          Show
          Hamdi Laadhari added a comment - - edited As i understood the problem, i am working on a better solution(not PHP side but TPL side). I'll amend the PR
          Hide
          Yannick Roger (Inactive) added a comment -

          Great. Feel free to ping me here or on github if you need feedback.

          Show
          Yannick Roger (Inactive) added a comment - Great. Feel free to ping me here or on github if you need feedback.
          Hide
          Hamdi Laadhari added a comment -

          PR updated

          Show
          Hamdi Laadhari added a comment - PR updated
          Yannick Roger (Inactive) made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Yannick Roger (Inactive) made changes -
          Assignee Yannick Roger [ yannick.roger@ez.no ]
          André Rømcke made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Yannick Roger (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Show
          Yannick Roger (Inactive) added a comment - Fixed in master: https://github.com/ezsystems/ezpublish-legacy/commit/bd8a1684d2c9f83d9a0940800f6c91cc817d4756
          Yannick Roger (Inactive) made changes -
          Affects Version/s 5.2 [ 12582 ]
          Affects Version/s 5.1 [ 11280 ]
          Affects Version/s 5.3-dev [ 12979 ]
          Yannick Roger (Inactive) logged work - 03/Jan/14 11:08 AM
          • Time Spent:
            1 hour
             
            <No comment>
          Yannick Roger (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 1 hour [ 3600 ]
          Worklog Id 44100 [ 44100 ]
          Yannick Roger (Inactive) made changes -
          Status Development [ 3 ] Documentation done [ 10011 ]
          Fix Version/s 5.3 [ 11282 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Fix Version/s 5.2 Maintenance [ 12782 ]
          Paulo Nunes (Inactive) logged work - 06/Jan/14 9:24 AM - edited
          • Time Spent:
            2 hours
             
            • Learning issue
            • Installing testing on ezp-5-1 and ezp-5.2
            • creating test case
          Paulo Nunes (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Yannick Roger [ yannick.roger@ez.no ] Paulo Nunes [ paulo.nunes@ez.no ]
          Pedro Resende (Inactive) made changes -
          Rank Ranked higher
          Paulo Nunes (Inactive) made changes -
          Time Spent 1 hour [ 3600 ] 3 hours [ 10800 ]
          Worklog Id 44341 [ 44341 ]
          Paulo Nunes (Inactive) made changes -
          Worklog Id 44341 [ 44341 ]
          Hide
          Paulo Nunes (Inactive) added a comment -

          QA Approved

          Show
          Paulo Nunes (Inactive) added a comment - QA Approved
          Paulo Nunes (Inactive) made changes -
          Assignee Paulo Nunes [ paulo.nunes@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Paulo Nunes (Inactive) logged work - 08/Jan/14 6:00 PM
          • Time Spent:
            2 hours
             

            Tested issue also on master

          Paulo Nunes (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Paulo Nunes (Inactive) made changes -
          Time Spent 3 hours [ 10800 ] 5 hours [ 18000 ]
          Worklog Id 44528 [ 44528 ]
          Paulo Nunes (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Joao Inacio (Inactive) made changes -
          Link This issue relates to EZP-22450 [ EZP-22450 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 60436 ] EZ* Development Workflow [ 84589 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84589 ] EZEE Development Workflow [ 123253 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          21d 17h 2m 1 yannick.roger@ez.no 03/Jan/14 9:48 AM
          Confirmed Confirmed InputQ InputQ
          46m 52s 1 André Rømcke 03/Jan/14 10:34 AM
          InputQ InputQ Development Development
          22s 1 yannick.roger@ez.no 03/Jan/14 10:35 AM
          Development Development Documentation Review done Documentation Review done
          33m 52s 1 yannick.roger@ez.no 03/Jan/14 11:09 AM
          Documentation Review done Documentation Review done QA QA
          2d 23h 57m 1 Paulo Nunes 06/Jan/14 11:06 AM
          QA QA Closed Closed
          2d 6h 53m 1 Paulo Nunes 08/Jan/14 5:59 PM
          Closed Closed Reopened Reopened
          1m 40s 1 Paulo Nunes 08/Jan/14 6:01 PM
          Reopened Reopened Closed Closed
          1s 1 Paulo Nunes 08/Jan/14 6:01 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Hamdi Laadhari
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours
                5h