Details

      Description

      Regression introduced in https://jira.ez.no/browse/EZP-21411 has been detected.

      steps to reproduce:
      • (in an environment with eZOracle and the patch from EZP-21411 applied)
      • Create and publish an object with a ezenum field
      • Verify that the value set to the ezenum field is not stored

        Issue Links

          Activity

          Joaquim Cavalleri (Inactive) created issue -
          Joaquim Cavalleri (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] Confirmed [ 10037 ]
          Joaquim Cavalleri (Inactive) made changes -
          Description Regression introduced in https://jira.ez.no/browse/EZP-21411 has been detected.

          h5. steps to reproduce:
          * (in an environment with eZOracle and the patch from EZP-21411 applied)
          * Create and publish an object with a ezenum field
          * verify that the value set to the ezenum field is not stored
          Regression introduced in https://jira.ez.no/browse/EZP-21411 has been detected.

          h5. steps to reproduce:
          * (in an environment with eZOracle and the patch from EZP-21411 applied)
          * Create and publish an object with a ezenum field
          * Verify that the value set to the ezenum field is not stored
          Gunnstein Lye made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Bertrand Dunogier made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 2 hours [ 7200 ]
          Worklog Id 42529 [ 42529 ]
          Bertrand Dunogier logged work - 22/Nov/13 10:38 AM
          • Time Spent:
            2 hours
             

            Investigated history

          Hide
          Bertrand Dunogier added a comment -

          Reproduced.

          Show
          Bertrand Dunogier added a comment - Reproduced.
          Hide
          Bertrand Dunogier added a comment - - edited

          I have thoroughly studied this part of the code, and came to the conclusion that the whole short name thing is broken on oracle. I don't see how it could not be.

          See https://github.com/ezsystems/ezpublish-legacy-ee/blob/stable-4.7/kernel/classes/ezpersistentobject.php#L79. This is where a row provided to initialize a persistent object is checked for short_name. The short name is a shortened name for a field, a workaround that "fixes" limited size of field names in certain RDBMS (oracle, postgresql...).

          The loop checks if there is a short_name for the PO's attribute. If there is, it uses the short_name to read from the provided $row. This implies that we should use the short name, not the normal one, as the key when initializing a persistent object. We don't. Not for eZEnumObjectValue, nor for eZURLObjectLink (the only 2 persistent objects that use this feature).

          On the other hand, I guess that the logic in setAttribute isn't flawed, which explains why the customer's patch works.

          Show
          Bertrand Dunogier added a comment - - edited I have thoroughly studied this part of the code, and came to the conclusion that the whole short name thing is broken on oracle. I don't see how it could not be. See https://github.com/ezsystems/ezpublish-legacy-ee/blob/stable-4.7/kernel/classes/ezpersistentobject.php#L79 . This is where a row provided to initialize a persistent object is checked for short_name . The short name is a shortened name for a field, a workaround that "fixes" limited size of field names in certain RDBMS (oracle, postgresql...). The loop checks if there is a short_name for the PO's attribute. If there is, it uses the short_name to read from the provided $row . This implies that we should use the short name, not the normal one, as the key when initializing a persistent object. We don't. Not for eZEnumObjectValue , nor for eZURLObjectLink (the only 2 persistent objects that use this feature). On the other hand, I guess that the logic in setAttribute isn't flawed, which explains why the customer's patch works.
          Bertrand Dunogier made changes -
          Link This issue relates to EZP-21411 [ EZP-21411 ]
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Bertrand Dunogier made changes -
          Time Spent 2 hours [ 7200 ] 1 day, 2 hours [ 36000 ]
          Worklog Id 43919 [ 43919 ]
          Bertrand Dunogier logged work - 24/Dec/13 6:15 PM
          • Time Spent:
            1 day
             

            .

          Bertrand Dunogier logged work - 09/Jan/14 3:22 PM
          • Time Spent:
            2 hours
             
            <No comment>
          Hide
          Bertrand Dunogier added a comment - - edited

          Merged to ezsystems/ezpublish-legacy/master @65eaea (revert) & @fcad1339.

          Show
          Bertrand Dunogier added a comment - - edited Merged to ezsystems/ezpublish-legacy/master @65eaea (revert) & @fcad1339 .
          Bertrand Dunogier made changes -
          Time Spent 1 day, 2 hours [ 36000 ] 1 day, 4 hours [ 43200 ]
          Worklog Id 44570 [ 44570 ]
          Bertrand Dunogier made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Affects Version/s 5.2 [ 12582 ]
          Affects Version/s 5.1 [ 11280 ]
          Affects Version/s 5.0 [ 10300 ]
          Affects Version/s 5.3-dev [ 12979 ]
          Bertrand Dunogier made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Pedro Resende (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Pedro Resende [ pedro.resende@ez.no ]
          Pedro Resende (Inactive) logged work - 10/Jan/14 9:13 AM
          • Time Spent:
            2 hours, 36 minutes
             

            Analyse and reproduce issue, write test case and verify the issue has been fixed after applying the patch

          Pedro Resende (Inactive) made changes -
          Comment [ A comment with security level 'Employees' was removed. ]
          Hide
          Pedro Resende (Inactive) added a comment -

          Tested and approved by Q.A. on eZ Publish 4.7 and 5.0, since the versions after aren't certified to use eZ Oracle

          Show
          Pedro Resende (Inactive) added a comment - Tested and approved by Q.A. on eZ Publish 4.7 and 5.0, since the versions after aren't certified to use eZ Oracle
          Pedro Resende (Inactive) made changes -
          Assignee Pedro Resende [ pedro.resende@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Pedro Resende (Inactive) made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Pedro Resende (Inactive) made changes -
          Time Spent 1 day, 4 hours [ 43200 ] 1 day, 6 hours, 36 minutes [ 52560 ]
          Worklog Id 44592 [ 44592 ]
          Pedro Resende (Inactive) made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Joao Inacio (Inactive) made changes -
          Link This issue relates to EZP-22177 [ EZP-22177 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 59797 ] EZ* Development Workflow [ 84446 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84446 ] EZEE Development Workflow [ 123101 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          3m 22s 1 joaquim.cavalleri@ez.no 28/Oct/13 5:51 PM
          Confirmed Confirmed InputQ InputQ
          16h 48m 1 Gunnstein Lye 29/Oct/13 10:39 AM
          InputQ InputQ Development Development
          36d 6h 33m 1 Bertrand Dunogier 04/Dec/13 5:12 PM
          Development Development Development Review Development Review
          20d 3m 1 Bertrand Dunogier 24/Dec/13 5:15 PM
          Development Review Development Review Development Review done Development Review done
          15d 22h 6m 1 Bertrand Dunogier 09/Jan/14 3:22 PM
          Development Review done Development Review done Documentation Review done Documentation Review done
          3m 32s 1 Bertrand Dunogier 09/Jan/14 3:26 PM
          Documentation Review done Documentation Review done QA QA
          11m 52s 1 pedro.resende@ez.no 09/Jan/14 3:38 PM
          QA QA Closed Closed
          19h 55m 1 pedro.resende@ez.no 10/Jan/14 11:33 AM
          Closed Closed Reopened Reopened
          1m 3s 1 pedro.resende@ez.no 10/Jan/14 11:34 AM
          Reopened Reopened Closed Closed
          1s 1 pedro.resende@ez.no 10/Jan/14 11:34 AM

            People

            • Assignee:
              Unassigned
              Reporter:
              Joaquim Cavalleri (Inactive)
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 6 hours, 36 minutes
                1d 6h 36m