Details

      Description

      RoleService methods persisting Limitations also validate them using:

      \eZ\Publish\SPI\Limitation\Type::validate()

      Right now for invalid Limitations InvalidArgumentException is thrown, but a new exception (LimitationValidationException) should be defined through which these errors could be accessed, similar to https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/Base/Exceptions/ContentFieldValidationException.php.

      Also some methods that persist and validate Policy do not hint the exception thrown. This should be documented in PHPDoc and maybe also similar exception (PolicyValidationException?) should be considered.

        Issue Links

          Activity

          Show
          Petar Spanja (Inactive) added a comment - Pull request: https://github.com/ezsystems/ezpublish-kernel/pull/567
          Show
          Petar Spanja (Inactive) added a comment - Fixed in ezpublish-kernel/master: https://github.com/ezsystems/ezpublish-kernel/commit/70a5cf1fa31bdeab2495fcbc5c6af6a96f649147
          Hide
          Filipe Dobreira (Inactive) added a comment -

          QA Approved.

          Show
          Filipe Dobreira (Inactive) added a comment - QA Approved.

            People

            • Assignee:
              Unassigned
              Reporter:
              Petar Spanja (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 3 hours, 10 minutes
                2d 3h 10m