Details

      Description

      If you have a redirection – let's say because content object renaming – with a querystring, the querystring will be lost.

      The file index.php.diff was given as fix suggestion.

      test case:
      1 - open some url my.site/object?config=foo in frontend
      2 - in backend, rename the object to object2
      3 - reload the url from point 1
      4 - site redirects /object -> /object2, but the querystring is lost.

      1. index.php.diff
        0.5 kB
        Eduardo Fernandes

        Issue Links

          Activity

          Eduardo Fernandes (Inactive) created issue -
          Hide
          Eduardo Fernandes (Inactive) added a comment -

          Steps to reproduce

          Show
          Eduardo Fernandes (Inactive) added a comment - Steps to reproduce In the backend, create any content object. In this case, an article named Article Version A Open the article in your front end, and add some query string. Lets say ?trackevent=123 http://mysite.com/article-version-a?trackevent=123 In the backend, rename the article to Article Version B In the frontend, call again the same URL. http://mysite.com/article-version-a?trackevent=123 eZ Publish will redirect it to the renamed article, but will remove the querystring http://mysite.com/article-version-b
          Eduardo Fernandes (Inactive) made changes -
          Field Original Value New Value
          Attachment index.php.diff [ 16919 ]
          Eduardo Fernandes (Inactive) made changes -
          Description If you have a redirection -- _let's say because content object renaming_ -- with a querystring, the querystring will be lost. If you have a redirection -- _let's say because content object renaming_ -- with a querystring, the querystring will be lost.

          The file index.php.diff was given as fix suggestion.
          Eduardo Fernandes (Inactive) made changes -
          Status Open [ 1 ] Confirmed [ 10037 ]
          Gunnstein Lye made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Paulo Bras (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Paulo Bras [ paulo.bras@ez.no ]
          Paulo Bras (Inactive) made changes -
          Link This issue discovered while testing EZP-21604 [ EZP-21604 ]
          Show
          Paulo Bras (Inactive) added a comment - pull request here: https://github.com/ezsystems/ezpublish-legacy/pull/768
          Paulo Bras (Inactive) made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Jérôme Vieilledent (Inactive) made changes -
          Remote Link This issue links to "https://github.com/ezsystems/ezpublish-legacy/pull/768 (Web Link)" [ 12520 ]
          Show
          Jérôme Vieilledent (Inactive) added a comment - Related PR: https://github.com/ezsystems/ezpublish-legacy/pull/493
          Jérôme Vieilledent (Inactive) made changes -
          Remote Link This issue links to "https://github.com/ezsystems/ezpublish-legacy/pull/493 (Web Link)" [ 12521 ]
          Paulo Bras (Inactive) made changes -
          Affects Version/s 4.5.0 [ 11000 ]
          Affects Version/s 5.0 [ 10300 ]
          Affects Version/s 5.1 [ 11280 ]
          Show
          Paulo Bras (Inactive) added a comment - fixed in master: https://github.com/ezsystems/ezpublish-legacy/commit/57a10b48120969b770104cd468aa153e983a8b82
          Paulo Bras (Inactive) made changes -
          Affects Version/s 5.2-alpha1 [ 11281 ]
          Affects Version/s 5.1 [ 11280 ]
          Affects Version/s 5.0 [ 10300 ]
          Paulo Bras (Inactive) made changes -
          Description If you have a redirection -- _let's say because content object renaming_ -- with a querystring, the querystring will be lost.

          The file index.php.diff was given as fix suggestion.
          If you have a redirection -- _let's say because content object renaming_ -- with a querystring, the querystring will be lost.

          The file index.php.diff was given as fix suggestion.

          test case:
          1 - open some url my.site/object?config=foo in frontend
          2 - in backend, rename the object to object2
          3 - reload the url from point 1
          4 - site redirects /object -> /object2, but the querystring is lost.

          Hide
          Paulo Bras (Inactive) added a comment -

          note: the 5.x versions have two cases - siteaccess with legacy mode, or pure Sf/twig.

          so, the 5.x solution must verify both routing cases.

          Show
          Paulo Bras (Inactive) added a comment - note: the 5.x versions have two cases - siteaccess with legacy mode, or pure Sf/twig. so, the 5.x solution must verify both routing cases.
          Hide
          Paulo Bras (Inactive) added a comment -
          Show
          Paulo Bras (Inactive) added a comment - PR for the 5.x kernel: https://github.com/ezsystems/ezpublish-kernel/pull/527
          Jérôme Vieilledent (Inactive) made changes -
          Assignee Paulo Bras [ paulo.bras@ez.no ] Jérôme Vieilledent [ jerome.vieilledent@ez.no ]
          Hide
          Jérôme Vieilledent (Inactive) added a comment - - edited
          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited Fixed in ezpublish-kernel master: https://github.com/ezsystems/ezpublish-kernel/commit/9a70edc
          Jérôme Vieilledent (Inactive) made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue relates to EZP-21684 [ EZP-21684 ]
          Hide
          Jérôme Vieilledent (Inactive) added a comment -
          Show
          Jérôme Vieilledent (Inactive) added a comment - Regression
          Show
          Jérôme Vieilledent (Inactive) added a comment - Regression fixed in master: https://github.com/ezsystems/ezpublish-kernel/commit/de47ba9efd8fde0c6006bdcc33416ea95c6bc794
          Jérôme Vieilledent (Inactive) made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Affects Version/s 5.2-beta1 [ 12684 ]
          Affects Version/s 5.2-alpha1 [ 11281 ]
          Fix Version/s 4.5 Maintenance [ 12585 ]
          Fix Version/s 4.6 Maintenance [ 12584 ]
          Fix Version/s 4.7 Maintenance [ 12583 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Fix Version/s 5.2-rc1 [ 12781 ]
          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Jérôme Vieilledent [ jerome.vieilledent@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Joao Pingo (Inactive) made changes -
          Status QA [ 10008 ] InputQ [ 10001 ]
          Assignee Joao Pingo [ joao.pingo@ez.no ]
          Joao Pingo (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 3 hours [ 10800 ]
          Worklog Id 41044 [ 41044 ]
          Joao Pingo (Inactive) logged work - 10/Oct/13 6:14 PM
          • Time Spent:
            3 hours
             

            Testing

          Hide
          Jérôme Vieilledent (Inactive) added a comment - - edited

          Joao Pingo: what is your test case please ?

          Show
          Jérôme Vieilledent (Inactive) added a comment - - edited Joao Pingo : what is your test case please ?
          Hide
          Joao Pingo (Inactive) added a comment - - edited

          Hi Jerome, i just followed what is described in the issue description:

          1 - open some url my.site/object?config=foo in frontend
          2 - in backend, rename the object to object2
          3 - reload the url from point 1
          4 - site redirects /object -> /object2, but the querystring is lost.

          Show
          Joao Pingo (Inactive) added a comment - - edited Hi Jerome, i just followed what is described in the issue description: 1 - open some url my.site/object?config=foo in frontend 2 - in backend, rename the object to object2 3 - reload the url from point 1 4 - site redirects /object -> /object2, but the querystring is lost.
          Jérôme Vieilledent (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Jérôme Vieilledent [ jerome.vieilledent@ez.no ]
          Show
          Jérôme Vieilledent (Inactive) added a comment - Additional fix in ezpublish-kernel master: https://github.com/ezsystems/ezpublish-kernel/commit/ac307bba5f7dcc7cc95a7e5a72dd4b2b73cb9c5c
          Jérôme Vieilledent (Inactive) made changes -
          Status Development [ 3 ] Documentation done [ 10011 ]
          Pedro Resende (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Jérôme Vieilledent [ jerome.vieilledent@ez.no ] Pedro Resende [ pedro.resende@ez.no ]
          Pedro Resende (Inactive) made changes -
          Time Spent 3 hours [ 10800 ] 5 hours, 42 minutes [ 20520 ]
          Worklog Id 41366 [ 41366 ]
          Hide
          Pedro Resende (Inactive) added a comment -

          Tested and approved by Q.A.

          Show
          Pedro Resende (Inactive) added a comment - Tested and approved by Q.A.
          Pedro Resende (Inactive) made changes -
          Assignee Pedro Resende [ pedro.resende@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Pedro Resende (Inactive) logged work - 21/Oct/13 6:39 PM
          • Time Spent:
            2 hours, 42 minutes
             

            Analyse and reproduce issue, write test case and verify the issue has been fixed

          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 59053 ] EZ* Development Workflow [ 84254 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84254 ] EZEE Development Workflow [ 122900 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          9m 34s 1 eduardo.fernandes@ez.no 19/Sep/13 11:40 AM
          Confirmed Confirmed InputQ InputQ
          50m 49s 1 Gunnstein Lye 19/Sep/13 12:31 PM
          Development Development Development Review Development Review
          4d 19h 20m 1 Paulo Bras (Inactive) 24/Sep/13 9:30 AM
          Development Review Development Review Development Review done Development Review done
          7d 2h 59m 1 jerome.vieilledent@ez.no 01/Oct/13 12:30 PM
          Development Review done Development Review done Documentation Review done Documentation Review done
          8d 23h 19m 1 jerome.vieilledent@ez.no 10/Oct/13 11:49 AM
          QA QA InputQ InputQ
          1h 50m 1 Joao Pingo (Inactive) 10/Oct/13 5:14 PM
          InputQ InputQ Development Development
          10d 23h 42m 2 jerome.vieilledent@ez.no 21/Oct/13 3:17 PM
          Development Development Documentation Review done Documentation Review done
          13m 6s 1 jerome.vieilledent@ez.no 21/Oct/13 3:30 PM
          Documentation Review done Documentation Review done QA QA
          3h 38m 2 pedro.resende@ez.no 21/Oct/13 3:34 PM
          QA QA Closed Closed
          2h 7m 1 pedro.resende@ez.no 21/Oct/13 5:41 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Eduardo Fernandes (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 42 minutes
                5h 42m