Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-21344

[REST Spec] Wrong xml tag on the response of create view

    Details

      Description

      On response example of REST API Spec: 1.3.2.7.1.1 XML Example
      ( https://github.com/ezsystems/ezpublish-kernel/blob/master/doc/specifications/rest/REST-API-V2.rst#view )

      The XML response starts:

      <?xml version="1.0" encoding="UTF-8"?>
      <View href="/content/views/TitleView" media-type="application/vnd.ez.api.View+xml">
        <identifier>TitleView</identifier>
        <User href="/user/users/14" media-type="vnd.ez.api.User+xml"/>
        <public>false</public>
        <Query>
          <Criteria>
            <FullTextCritierion>Title</FieldCritierion>
          </Criteria>
      

      The XML code inside Criteria is incorrect FullTextCritierion - FieldCritierion

        Issue Links

          Activity

          Marcos Loureiro (Inactive) created issue -
          Show
          Marcos Loureiro (Inactive) added a comment - PR: https://github.com/ezsystems/ezpublish-kernel/pull/469
          Marcos Loureiro (Inactive) made changes -
          Field Original Value New Value
          Status Open [ 1 ] Confirmed [ 10037 ]
          André Rømcke made changes -
          Status Confirmed [ 10037 ] InputQ [ 10001 ]
          Show
          Bertrand Dunogier added a comment - New PR: https://github.com/ezsystems/ezpublish-kernel/pull/537 .
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Bertrand Dunogier logged work - 03/Oct/13 9:06 AM
          • Time Spent:
            15 minutes
             
            <No comment>
          Bertrand Dunogier made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 15 minutes [ 900 ]
          Worklog Id 40706 [ 40706 ]
          Bertrand Dunogier made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Fix Version/s 5.2-rc1 [ 12781 ]
          Bertrand Dunogier made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Joao Pingo (Inactive) logged work - 07/Oct/13 10:16 AM
          • Time Spent:
            30 minutes
             

            Testing

          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Joao Pingo (Inactive) made changes -
          Time Spent 15 minutes [ 900 ] 45 minutes [ 2700 ]
          Worklog Id 40973 [ 40973 ]
          Joao Pingo (Inactive) made changes -
          Rank Ranked higher
          Joao Pingo (Inactive) made changes -
          Time Spent 45 minutes [ 2700 ] 1 hour, 15 minutes [ 4500 ]
          Worklog Id 40988 [ 40988 ]
          Joao Pingo (Inactive) logged work - 08/Oct/13 6:57 PM
          • Time Spent:
            30 minutes
             

            Testing

          Joao Pingo (Inactive) made changes -
          Status QA [ 10008 ] InputQ [ 10001 ]
          Assignee Joao Pingo [ joao.pingo@ez.no ]
          Hide
          Bertrand Dunogier added a comment -

          No, it won't be backported to 5.2, unless we classify it as a blocker. I don't think we should, as the online version usually acts as a reference, even though this might not be ideal. I don't think we should expect people to go dig through the rest spec in the version they have downloaded.

          I have committed one more fix for another occurrence of the same mistake: https://github.com/ezsystems/ezpublish-kernel/commit/04d1876e6fbc4a75d5ffedaa76e015e1694d0071.

          Show
          Bertrand Dunogier added a comment - No, it won't be backported to 5.2, unless we classify it as a blocker. I don't think we should, as the online version usually acts as a reference, even though this might not be ideal. I don't think we should expect people to go dig through the rest spec in the version they have downloaded. I have committed one more fix for another occurrence of the same mistake: https://github.com/ezsystems/ezpublish-kernel/commit/04d1876e6fbc4a75d5ffedaa76e015e1694d0071 .
          Bertrand Dunogier made changes -
          Status InputQ [ 10001 ] Documentation [ 10010 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Documentation [ 10010 ] Documentation done [ 10011 ]
          Bertrand Dunogier made changes -
          Fix Version/s 5.3 [ 11282 ]
          Fix Version/s 5.2-rc1 [ 12781 ]
          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Hide
          Joao Pingo (Inactive) added a comment -

          @Bertrand
          Running the test as documented returns the correct objects ... but the response is 200 Ok, in doc we have 201 Created (in line 2101)

          Show
          Joao Pingo (Inactive) added a comment - @Bertrand Running the test as documented returns the correct objects ... but the response is 200 Ok, in doc we have 201 Created (in line 2101)
          Joao Pingo (Inactive) logged work - 22/Nov/13 5:51 PM
          • Time Spent:
            1 hour, 30 minutes
             

            Testing

          Joao Pingo (Inactive) made changes -
          Time Spent 1 hour, 15 minutes [ 4500 ] 2 hours, 45 minutes [ 9900 ]
          Worklog Id 42548 [ 42548 ]
          Hide
          Bertrand Dunogier added a comment -

          Actually, the example says 201, but the Response example a couple lines ago says 200...

          But actually, this particular one is a bit trickier. The specs say that a POST request to /content/views will create a view, and return the results. But it doesn't. This isn't implemented yet.

          So technically, it is correct that we return 200 and not 201, since nothing is created. I'd say that when storage is actually implemented, the response should be changed to 201.

          I guess the doc needs to be updated to reflect that.

          Show
          Bertrand Dunogier added a comment - Actually, the example says 201, but the Response example a couple lines ago says 200... But actually, this particular one is a bit trickier. The specs say that a POST request to /content/views will create a view , and return the results. But it doesn't. This isn't implemented yet. So technically, it is correct that we return 200 and not 201, since nothing is created. I'd say that when storage is actually implemented, the response should be changed to 201. I guess the doc needs to be updated to reflect that.
          Bertrand Dunogier made changes -
          Status QA [ 10008 ] Development Acceptance Done [ 10030 ]
          Bertrand Dunogier made changes -
          Status Development Acceptance Done [ 10030 ] Documentation [ 10010 ]
          Assignee Joao Pingo [ joao.pingo@ez.no ] Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Assignee Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ] Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ]
          Sarah Haïm-Lubczanski (Inactive) logged work - 10/Mar/14 12:20 PM
          • Time Spent:
            1 hour
             
            <No comment>
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Time Spent 2 hours, 45 minutes [ 9900 ] 3 hours, 45 minutes [ 13500 ]
          Worklog Id 46232 [ 46232 ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Status Documentation [ 10010 ] Documentation done [ 10011 ]
          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Bertrand Dunogier made changes -
          Remote Link This issue links to "Doc pull request ezpublish-kernel#772 (Web Link)" [ 13702 ]
          Hide
          Bertrand Dunogier added a comment -

          Doc pull request ezpublish-kernel#772

          Show
          Bertrand Dunogier added a comment - Doc pull request ezpublish-kernel#772
          Joao Pingo (Inactive) made changes -
          Status QA [ 10008 ] Development Acceptance Done [ 10030 ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Status Development Acceptance Done [ 10030 ] Documentation [ 10010 ]
          Assignee Joao Pingo [ joao.pingo@ez.no ] Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Time Spent 3 hours, 45 minutes [ 13500 ] 4 hours, 15 minutes [ 15300 ]
          Worklog Id 46951 [ 46951 ]
          Sarah Haïm-Lubczanski (Inactive) made changes -
          Status Documentation [ 10010 ] Documentation done [ 10011 ]
          Sarah Haïm-Lubczanski (Inactive) logged work - 19/Mar/14 5:39 PM
          • Time Spent:
            30 minutes
             

            squashing and correcting typo

          Hide
          Joao Pingo (Inactive) added a comment -

          QA Approved

          Show
          Joao Pingo (Inactive) added a comment - QA Approved
          Joao Pingo (Inactive) made changes -
          Assignee Sarah Haïm-Lubczanski [ sarah.haim-lubczanski@ez.no ]
          Status Documentation done [ 10011 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 57164 ] EZ* Development Workflow [ 84092 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 84092 ] EZEE Development Workflow [ 122728 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Confirmed Confirmed
          24m 10s 1 Marcos Loureiro (Inactive) 25/Jul/13 5:25 PM
          Confirmed Confirmed InputQ InputQ
          52d 16h 52m 1 André Rømcke 16/Sep/13 10:17 AM
          InputQ InputQ Development Development
          16d 5h 10m 1 Bertrand Dunogier 02/Oct/13 3:28 PM
          Development Development Development Review Development Review
          7s 1 Bertrand Dunogier 02/Oct/13 3:28 PM
          Development Review Development Review Development Review done Development Review done
          17h 37m 1 Bertrand Dunogier 03/Oct/13 9:06 AM
          Development Review done Development Review done Documentation Review done Documentation Review done
          1h 3m 1 Bertrand Dunogier 03/Oct/13 10:09 AM
          QA QA InputQ InputQ
          1d 16h 19m 1 Joao Pingo (Inactive) 09/Oct/13 10:01 AM
          InputQ InputQ Documentation Documentation
          35d 2h 57m 1 Bertrand Dunogier 13/Nov/13 11:59 AM
          Documentation Review done Documentation Review done QA QA
          14d 8h 18m 3 Joao Pingo (Inactive) 11/Mar/14 12:20 PM
          QA QA Removed Status Removed Status
          3d 22h 48m 2 Joao Pingo (Inactive) 11/Mar/14 1:52 PM
          Removed Status Removed Status Documentation Documentation
          7d 20h 10m 2 sarah.haim-lubczanski@ez.no 19/Mar/14 10:02 AM
          Documentation Documentation Documentation Review done Documentation Review done
          104d 8h 55m 3 sarah.haim-lubczanski@ez.no 19/Mar/14 4:40 PM
          Documentation Review done Documentation Review done Closed Closed
          1d 20h 8m 1 Joao Pingo (Inactive) 21/Mar/14 12:49 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Marcos Loureiro (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 15 minutes
                4h 15m