Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-20839

LoadFromCDN is ignored if YU3_config is not used as required

    Details

      Description

      It is clearly stated in doc/changelogs/4.7/CHANGELOG-4.6.0-to-4.7.0.txt
      "Make sure the YUI3_config is used when loading YUI3 components"

      One consequence of not complying to this Change note is that any custom implementation that includes a YUI().use(<module> on a site with [eZJScore] Packer=enabled , will have the <module> being loaded from yui.yahooapis.com, regardless of LoadFromCDN set value.

      It took me sometime to first notice the note in the changelog. Until then I did not understood why, on my test environment, some yui modules were being loaded from external sources.

      Wishing to make sure that my code was in compliance with eZ's main one, I grepped eZPROOT for YUI().use( . Found two relevant locations:
      /extension/ezfind/design/standard/javascript/ezajaxsearch.js
      /extension/ezflow/design/iphone/templates/pagelayout.tpl

      Although I have not been able to reproduce the issue with eZFind, it's easy reproducible in eZFlow's iphone design.

      steps to reproduce:
      • Setup an eZPublish 4.7 with eZFlow
      • Set [eJSCore] Packer=enabled | LoadFromCDN=false | PreferredLibrary=yui3
      • Clear browser and eZ caches
      • Access the home page in iphone siteaccess
      • Verify that http://yui.yahooapis.com/combo is accessed to retrieve the required modules

      This is a minor issue, nevertheless, I report it here to call everyone's attention to the note in changelog quoted above:
      Make sure the YUI3_config is used when loading YUI3 components

        Issue Links

          Activity

          Show
          André Rømcke added a comment - - edited Fixed in master: https://github.com/ezsystems/ezflow/commit/dd1c4366f407e68226c4b34386f1a85d57834424 5.1: https://github.com/ezsystems/ezflow/commit/7f17beb1ee7a78202cab9bd38f251d3b04ab384f 5.0: https://github.com/ezsystems/ezflow/commit/a14b3fa86c50fc09eef98ed326fad90a60f7e050 4.7: https://github.com/ezsystems/ezflow/commit/2f41f93ef292635d03dfc0ddaa950e785baa9ec0
          Hide
          Joao Pingo (Inactive) added a comment -

          Tested in master and 4.7 using tc-1592
          Test Passed ... QA Approved

          Show
          Joao Pingo (Inactive) added a comment - Tested in master and 4.7 using tc-1592 Test Passed ... QA Approved

            People

            • Assignee:
              Unassigned
              Reporter:
              Joaquim Cavalleri (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h