Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-20657

EmbedToHtml5 Converter doesn't define alignment parameters

    Details

      Description

      The eZ\Publish\Core\FieldType\XmlText\Converter\EmbedToHtml5 doesn't define a parameter for alignement of embed objects.

        Activity

        Hide
        Jérôme Vieilledent (Inactive) added a comment -

        Well it depends on how you use all this... If you rely on legacy fallback for the embedded content, there is indeed an issue since you won't go through embed.tpl which added the align css class. This appears to be a bug to me. Working on it.

        Show
        Jérôme Vieilledent (Inactive) added a comment - Well it depends on how you use all this... If you rely on legacy fallback for the embedded content, there is indeed an issue since you won't go through embed.tpl which added the align css class. This appears to be a bug to me. Working on it.
        Hide
        Jérôme Vieilledent (Inactive) added a comment - - edited

        Pull-request to fix embed tag: https://github.com/ezsystems/ezpublish-kernel/pull/386

        However, while now the appropriate css class is present, it doesn't seem to apply on ezdemo.
        [~damien.pobel@ez.no], any idea ?

        Show
        Jérôme Vieilledent (Inactive) added a comment - - edited Pull-request to fix embed tag: https://github.com/ezsystems/ezpublish-kernel/pull/386 However, while now the appropriate css class is present, it doesn't seem to apply on ezdemo. [~damien.pobel@ez.no] , any idea ?
        Show
        Jérôme Vieilledent (Inactive) added a comment - Fixed in master: https://github.com/ezsystems/ezpublish-kernel/commit/036807ef9a86348a4e5140df003ece579c1a4850
        Hide
        Damien Pobel (Inactive) added a comment -

        It seems to work for me but that's true that some combinations of view/style + align does not seem to have effects. For instance, if you embed a file with the "embed" view and set the class to "Highlighted Object", settings align to right does not seem to change anything compared to the "none" or "left" alignment. In such case, it's not really a bug but more some graphical constraints.

        Show
        Damien Pobel (Inactive) added a comment - It seems to work for me but that's true that some combinations of view/style + align does not seem to have effects. For instance, if you embed a file with the "embed" view and set the class to "Highlighted Object", settings align to right does not seem to change anything compared to the "none" or "left" alignment. In such case, it's not really a bug but more some graphical constraints.
        Hide
        Joao Pingo (Inactive) added a comment -

        Tested on master and passed
        QA Done

        Show
        Joao Pingo (Inactive) added a comment - Tested on master and passed QA Done

          People

          • Assignee:
            Unassigned
            Reporter:
            Matthieu Sévère
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 3 days, 3 hours, 30 minutes
              3d 3h 30m