Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-20558

Workflow Event/Approve not working correctly

    Details

      Description

      With the administrator user add an Event/approve workflow to be triggered with content/publish/before, then with another user add a few articles and you'll get the following error in the debug redirect

      Error: 	Mar 13 2013 12:41:52
       
      Internal transaction counter mismatch : 1. Should be zero.
      

      Steps

      Setup - Create editor user
       
      Log in as admin in admin
      Click "User accounts" in top menu
      Click "Editors" link
      Click "Create here" button
      Enter form data:
      First name: Editor_tc182
      Last name : Editor_tc182
      Username : Editor_tc182
      Password : Editor_tc182
      Confirm password : Editor_tc182
      Email: tc182@test.com
      Click "Send for publishing button"
       
      Setup - Create workflow
       
      Click "Setup" tab in top menu
      Click "Workflows" link on left menu
      Click "New Workflow Group" button
      Enter Data
      Name: Group Workflow tc_182
      Press "OK" button
      On "Workflow Groups", click on "Group Workflow tc_182"
      On Workflows group, press "New workflow" button
      Enter Data
      Name: Workflow tc_182
      On events combo box, choose "Event / Approve"
      Press "Add Event" button
      On "Users who approve content" press "Add users" button
      Click on " Administrator User" link
      Check the  user  Administrator User
      Press "OK" button on the bottom of the page
      Press "Triggers" link on left side menu
      For Module "Content", Function "Publish", Connection Type "Before" choose the workflow "tc_182" on Workflow combo box
      Press "Apply changes" button
      Logout
       
      Create 1 articles as Editor_tc182
       
      Enter Ez Publish as Editor_tc182
      Press "Content Structure" tab on top menu
      On "Sub Items" group, choose "article" from the combo box and press "Create here" button
      Create article1 with data:
      Title: Article1
      Intro: Intro for Article1
      Press "Send for Publishing button"
      

        Issue Links

          Activity

          Pedro Resende (Inactive) created issue -
          Pedro Resende (Inactive) made changes -
          Field Original Value New Value
          Fix Version/s 5.1 Certification [ 11879 ]
          Pedro Resende (Inactive) made changes -
          Fix Version/s QA tracked issues [ 11072 ]
          Affects Version/s QA tracked issues [ 11072 ]
          Vidar Langseid made changes -
          Status Open [ 1 ] Backlog [ 10000 ]
          Vidar Langseid made changes -
          Status Backlog [ 10000 ] InputQ [ 10001 ]
          Vidar Langseid made changes -
          Rank Ranked higher
          Vidar Langseid made changes -
          Rank Ranked higher
          Hide
          Jérôme Vieilledent (Inactive) added a comment -

          This issue is a regression from EZP-19660.

          Full transaction stack :

          Level 0
          {
            Began at:
            /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/content/ezcontentoperationcollection.php:112 eZDBInterface::begin
              ->???:??? eZContentOperationCollection::beginTransaction
              Level 1
              {    
                Began at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:99 eZDBInterface::begin
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem
                And commited at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:103 eZDBInterface::commit
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem
              }
              Level 1
              {    
                Began at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:99 eZDBInterface::begin
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem
                And commited at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:103 eZDBInterface::commit
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem
              }
              Level 1
              {    
                Began at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:244 eZDBInterface::begin
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:222 eZTrigger::runWorkflow
                And commited at:
                /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:298 eZDBInterface::commit
                  ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:222 eZTrigger::runWorkflow
              }
          }
          

          This is due to the fact that the transaction is not commited if operation is halted (seems so)

          Show
          Jérôme Vieilledent (Inactive) added a comment - This issue is a regression from EZP-19660 . Full transaction stack : Level 0 { Began at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/content/ezcontentoperationcollection.php:112 eZDBInterface::begin ->???:??? eZContentOperationCollection::beginTransaction Level 1 { Began at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:99 eZDBInterface::begin ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem And commited at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:103 eZDBInterface::commit ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem } Level 1 { Began at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:99 eZDBInterface::begin ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem And commited at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/ezcollaborationitemgrouplink.php:103 eZDBInterface::commit ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/collaborationhandlers/ezapprove/ezapprovecollaborationhandler.php:186 eZCollaborationItemGroupLink::addItem } Level 1 { Began at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:244 eZDBInterface::begin ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:222 eZTrigger::runWorkflow And commited at: /Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:298 eZDBInterface::commit ->/Users/lolautruche/workspace/ezsystems/ezpublish/kernel/classes/eztrigger.php:222 eZTrigger::runWorkflow } } This is due to the fact that the transaction is not commited if operation is halted (seems so)
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue testing discovered EZP-19660 [ EZP-19660 ]
          Jérôme Vieilledent (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 2 hours, 30 minutes [ 9000 ]
          Worklog Id 31209 [ 31209 ]
          Jérôme Vieilledent (Inactive) logged work - 22/Mar/13 6:33 PM
          • Time Spent:
            2 hours, 30 minutes
             

            .

          Jérôme Vieilledent (Inactive) made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Jerome Vieilledent [ jerome.vieilledent@ez.no ]
          Hide
          Jérôme Vieilledent (Inactive) added a comment -

          Note that this issue probably also occurs with asynchronous publishing.

          Show
          Jérôme Vieilledent (Inactive) added a comment - Note that this issue probably also occurs with asynchronous publishing.
          Show
          Jérôme Vieilledent (Inactive) added a comment - https://github.com/ezsystems/ezpublish-legacy/pull/581
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue testing discovered EZP-19660 [ EZP-19660 ]
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue relates to EZP-19660 [ EZP-19660 ]
          Jérôme Vieilledent (Inactive) logged work - 25/Mar/13 3:11 PM - edited
          • Time Spent:
            5 hours
             

            Working on issue EZP-20558

          Jérôme Vieilledent (Inactive) made changes -
          Time Spent 2 hours, 30 minutes [ 9000 ] 2 hours, 35 minutes [ 9300 ]
          Worklog Id 31262 [ 31262 ]
          Jérôme Vieilledent (Inactive) made changes -
          Status Development [ 3 ] Devlopment done [ 5 ]
          Jérôme Vieilledent (Inactive) made changes -
          Time Spent 2 hours, 35 minutes [ 9300 ] 7 hours, 30 minutes [ 27000 ]
          Worklog Id 31262 [ 31262 ]
          Patrick Allaert (Inactive) logged work - 25/Mar/13 4:27 PM
          • Time Spent:
            20 minutes
             

            Discussing the issue with JV

          Show
          Jérôme Vieilledent (Inactive) added a comment - Fixed in master : https://github.com/ezsystems/ezpublish-legacy/commit/c2992a1675594ac2a7aa5aff97692d635781ae92
          Jérôme Vieilledent (Inactive) logged work - 26/Mar/13 2:18 PM
          • Time Spent:
            1 hour, 30 minutes
             
            <No comment>
          Jérôme Vieilledent (Inactive) made changes -
          Time Spent 7 hours, 30 minutes [ 27000 ] 1 day, 1 hour [ 32400 ]
          Worklog Id 31298 [ 31298 ]
          Jérôme Vieilledent (Inactive) made changes -
          Status Devlopment done [ 5 ] Documentation done [ 10011 ]
          Patrick Allaert (Inactive) made changes -
          Time Spent 1 day, 1 hour [ 32400 ] 1 day, 1 hour, 25 minutes [ 33900 ]
          Worklog Id 31303 [ 31303 ]
          Patrick Allaert (Inactive) made changes -
          Time Spent 1 day, 1 hour, 25 minutes [ 33900 ] 1 day, 1 hour, 45 minutes [ 35100 ]
          Worklog Id 31304 [ 31304 ]
          Patrick Allaert (Inactive) logged work - 26/Mar/13 4:27 PM
          • Time Spent:
            25 minutes
             

            Reviewing and discussing PR

          Vidar Langseid made changes -
          Link This issue is duplicated by EZP-20471 [ EZP-20471 ]
          Paulo Nunes (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Jerome Vieilledent [ jerome.vieilledent@ez.no ] Paulo Nunes [ paulo.nunes@ez.no ]
          Hide
          Paulo Nunes (Inactive) added a comment -

          Passed after re-testing
          QA Approved.

          Show
          Paulo Nunes (Inactive) added a comment - Passed after re-testing QA Approved.
          Paulo Nunes (Inactive) made changes -
          Status QA [ 10008 ] QA done [ 10007 ]
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue relates to EZP-20635 [ EZP-20635 ]
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue is duplicated by EZP-20627 [ EZP-20627 ]
          André Rømcke made changes -
          Assignee Paulo Nunes [ paulo.nunes@ez.no ]
          Status QA done [ 10007 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Jérôme Vieilledent (Inactive) made changes -
          Link This issue relates to EZP-21565 [ EZP-21565 ]
          Show
          Jérôme Vieilledent (Inactive) added a comment - Much cleaner approach: https://github.com/ezsystems/ezpublish-legacy/pull/767
          Jérôme Vieilledent (Inactive) made changes -
          Remote Link This issue links to "https://github.com/ezsystems/ezpublish-legacy/pull/767 (Web Link)" [ 12513 ]
          Show
          Bertrand Dunogier added a comment - Reverted from ezpublish-legacy/master: https://github.com/ezsystems/ezpublish-legacy/commit/d355026740f39039e44e909544464c1a1fead233 . See https://jira.ez.no/browse/EZP-21599 for the final fix.
          Bertrand Dunogier made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Bertrand Dunogier made changes -
          Status Reopened [ 4 ] Confirmed [ 10037 ]
          Bertrand Dunogier made changes -
          Status Confirmed [ 10037 ] Backlog [ 10000 ]
          Bertrand Dunogier made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ]
          Bertrand Dunogier made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Fix Version/s 4.2 Maintenance [ 12588 ]
          Fix Version/s 4.3 Maintenance [ 12587 ]
          Fix Version/s 4.4 Maintenance [ 12586 ]
          Fix Version/s 4.5 Maintenance [ 12585 ]
          Fix Version/s 4.6 Maintenance [ 12584 ]
          Fix Version/s 4.7 Maintenance [ 12583 ]
          Fix Version/s 5.0 Maintenance [ 11287 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Fix Version/s 5.2-rc1 [ 12781 ]
          Bertrand Dunogier made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Bertrand Dunogier made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Joao Pingo (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Bertrand Dunogier [ bertrand.dunogier@ez.no ] Joao Pingo [ joao.pingo@ez.no ]
          Joao Pingo (Inactive) made changes -
          Assignee Joao Pingo [ joao.pingo@ez.no ]
          Status QA [ 10008 ] Closed [ 6 ]
          Resolution Obsolete [ 8 ]
          Hide
          Joao Pingo (Inactive) added a comment -

          No QA Needed
          Will be tested in https://jira.ez.no/browse/EZP-21599

          Show
          Joao Pingo (Inactive) added a comment - No QA Needed Will be tested in https://jira.ez.no/browse/EZP-21599
          Hide
          Paulo Nunes (Inactive) added a comment -
          Show
          Paulo Nunes (Inactive) added a comment - real fix on https://jira.ez.no/browse/EZP-21599
          Paulo Nunes (Inactive) made changes -
          Link This issue relates to EZP-21599 [ EZP-21599 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 52522 ] EZ* Development Workflow [ 83584 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 83584 ] EZEE Development Workflow [ 122195 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Backlog Backlog
          6d 21h 48m 1 Vidar Langseid 20/Mar/13 11:32 AM
          Backlog Backlog InputQ InputQ
          4s 1 Vidar Langseid 20/Mar/13 11:32 AM
          InputQ InputQ Development Development
          5d 12m 1 jerome.vieilledent@ez.no 25/Mar/13 11:44 AM
          Development Development Development Done Development Done
          3h 27m 1 jerome.vieilledent@ez.no 25/Mar/13 3:11 PM
          Development Done Development Done Documentation Review done Documentation Review done
          23h 7m 1 jerome.vieilledent@ez.no 26/Mar/13 2:18 PM
          QA QA QA Done QA Done
          34m 7s 1 Paulo Nunes 27/Mar/13 11:54 AM
          QA Done QA Done Closed Closed
          6d 21h 25m 1 André Rømcke 03/Apr/13 10:20 AM
          Closed Closed Reopened Reopened
          180d 6h 59m 1 Bertrand Dunogier 30/Sep/13 5:19 PM
          Reopened Reopened Confirmed Confirmed
          8s 1 Bertrand Dunogier 30/Sep/13 5:19 PM
          Confirmed Confirmed Backlog Backlog
          4s 1 Bertrand Dunogier 30/Sep/13 5:19 PM
          Backlog Backlog Development Development
          6s 1 Bertrand Dunogier 30/Sep/13 5:19 PM
          Development Development Development Review Development Review
          24m 58s 1 Bertrand Dunogier 30/Sep/13 5:44 PM
          Development Review Development Review Development Review done Development Review done
          6s 1 Bertrand Dunogier 30/Sep/13 5:44 PM
          Development Review done Development Review done Documentation Review done Documentation Review done
          6s 1 Bertrand Dunogier 30/Sep/13 5:44 PM
          Documentation Review done Documentation Review done QA QA
          3d 15h 43m 2 Joao Pingo (Inactive) 03/Oct/13 12:26 PM
          QA QA Closed Closed
          2h 27m 1 Joao Pingo (Inactive) 03/Oct/13 2:54 PM

            People

            • Assignee:
              Unassigned
              Reporter:
              Pedro Resende (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 1 hour, 45 minutes
                1d 1h 45m