Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-20267

Issues in the section management part of the new admin UI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Medium Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      + Use the REST API as a source of the asynchronous datatable
      + Do not load the full list of contents just to get the number of contents (list and section view)
      ? Pagination in the asynchronous datatable
      + the name of the content should be a link to the location of it
      + the published column should be filled with the date and time
      + While the datatable is loading, it displays "No data to display" which is confusing
      + Load the datatable before the content tab is actually focused
      + No global variable (sectionsListDataSource in section view)
      + Do not hardcode strings in JS files
      + Update the URL when a tab is focused
      + Use the YUI grid system for columns
      + Asynchronously loads custom JS file with YUI Loader
      + Use a semantic markup: <button> for buttons, link label with the corresponding input
      + Fix CS issues in PHP code

      • ...

        Issue Links

          Activity

          Hide
          Anton Petrushenkov (Inactive) added a comment -

          Converted custom JS into YUI module and
          asynchronously loading it with YUI Loader:
          https://github.com/ezsystems/AdminBundle/commit/186d22810e1f98004f4a09e7ceb7e49a1be050e8

          P.S. major disatvantage - file has to be served statically (which is very uncomfortable in dev enviroment), may be consider implementing this approach closer to production?

          Show
          Anton Petrushenkov (Inactive) added a comment - Converted custom JS into YUI module and asynchronously loading it with YUI Loader: https://github.com/ezsystems/AdminBundle/commit/186d22810e1f98004f4a09e7ceb7e49a1be050e8 P.S. major disatvantage - file has to be served statically (which is very uncomfortable in dev enviroment), may be consider implementing this approach closer to production?
          Show
          Anton Petrushenkov (Inactive) added a comment - Use a semantic markup: <button> for buttons. https://github.com/ezsystems/AdminBundle/commit/41a577e6055716f46339af55720ad062913392ad
          Show
          Anton Petrushenkov (Inactive) added a comment - Fix CS issues in PHP code https://github.com/ezsystems/AdminBundle/commit/54e4ec28df1bb433ea60442f365bc38f21385067
          Hide
          Damien Pobel (Inactive) added a comment - - edited

          + Use the REST API as a source of the asynchronous datatable
          => does not work with Firefox because it adds ";charset= utf-8", this will be fixed server side (I hope) but this also shows that the error handling of the datatable is not done at all, it should at least show a dedicated message and not just keep on showing "Loading..." in case of error

          + Do not load the full list of contents just to get the number of contents (list and section view)
          => OK but the Public API misses a way to only get the number of results (SearchService::findContent()) actually loads everything

          ? Pagination in the asynchronous datatable
          => I'm sure there's a solution, I'll check that.

          + the name of the content should be a link to the location of it
          => why not building a system URL (/content/content/<id> or something like this) instead of a nice url

          + the published column should be filled with the date and time
          => the format should in the configuration object

          + While the datatable is loading, it displays "No data to display" which is confusing
          OK

          + Load the datatable before the content tab is actually focused
          OK for now

          + No global variable (sectionsListDataSource in section view)
          there's still a global variable object...

          + Do not hardcod strings in JS files
          OK

          + Update the URL when a tab is focused
          OK

          + Use the YUI grid system for columns
          the float on aside and .content are useless

          + Asynchronously loads custom JS file with YUI Loader
          OK for this point but why don't you use the asset() to build the path to the JS files

          + Use a semantic markup: <button> for buttons, link label with the corresponding input
          if it's to add a behaviour in JS, it's useless... Please use the standard web/browser behaviours so the "Create new section" button has to be in a form and the section-list.js is useless.

          + Fix CS issues in PHP code
          OK

          Show
          Damien Pobel (Inactive) added a comment - - edited + Use the REST API as a source of the asynchronous datatable => does not work with Firefox because it adds ";charset= utf-8", this will be fixed server side (I hope) but this also shows that the error handling of the datatable is not done at all, it should at least show a dedicated message and not just keep on showing "Loading..." in case of error + Do not load the full list of contents just to get the number of contents (list and section view) => OK but the Public API misses a way to only get the number of results (SearchService::findContent()) actually loads everything ? Pagination in the asynchronous datatable => I'm sure there's a solution, I'll check that. + the name of the content should be a link to the location of it => why not building a system URL (/content/content/<id> or something like this) instead of a nice url + the published column should be filled with the date and time => the format should in the configuration object + While the datatable is loading, it displays "No data to display" which is confusing OK + Load the datatable before the content tab is actually focused OK for now + No global variable (sectionsListDataSource in section view) there's still a global variable object... + Do not hardcod strings in JS files OK + Update the URL when a tab is focused OK + Use the YUI grid system for columns the float on aside and .content are useless + Asynchronously loads custom JS file with YUI Loader OK for this point but why don't you use the asset() to build the path to the JS files + Use a semantic markup: <button> for buttons, link label with the corresponding input if it's to add a behaviour in JS, it's useless... Please use the standard web/browser behaviours so the "Create new section" button has to be in a form and the section-list.js is useless. + Fix CS issues in PHP code OK
          Show
          Damien Pobel (Inactive) added a comment - Refactored, improved tabs/url management: https://github.com/ezsystems/AdminBundle/commit/1a7f741454434927e2bbaac9c844671979acfb58 General markup/CSS improvements: https://github.com/ezsystems/AdminBundle/commit/739f26cf053e0a54891e39d52096f266004e53e3 Section view improvements: https://github.com/ezsystems/AdminBundle/commit/4eb3f194a4a72b404c8c2e00290c0dc0f5936c26

            People

            • Assignee:
              Unassigned
              Reporter:
              Damien Pobel (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 6 hours
                3d 6h

                  Agile