Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-20018

Missing Language, Visibility & ObjectState Criteria

    Details

      Description

      • Implement missing criterions in API and Legacy
      • Update LanguageLimitationType & StateLimitationType ->getCriterion() to return these
      • test

        Issue Links

          Activity

          Hide
          Edi Modrić (Inactive) added a comment -

          Visiblity & ObjectState criteria are potentially problematic with the current way criterion handlers are implemented in legacy.

          While they are possible to implement, the only way to match on object state and visibility is to create a subselect on the main query that selects matching content IDs from ezcontnetobject_tree and ezcobj_state_link tables.

          Both of these tables contain at least one record for each content object and if the amount of content objects is large, these subselects can be quite a bottleneck.

          For example: any kind of search for only visible objects needs to perform the subselect "SELECT contentobject_id FROM ezcontentobject_tree WHERE hidden = 0 AND invisible = 0" which will, in most cases, return almost all content object IDs from the table.

          Show
          Edi Modrić (Inactive) added a comment - Visiblity & ObjectState criteria are potentially problematic with the current way criterion handlers are implemented in legacy. While they are possible to implement, the only way to match on object state and visibility is to create a subselect on the main query that selects matching content IDs from ezcontnetobject_tree and ezcobj_state_link tables. Both of these tables contain at least one record for each content object and if the amount of content objects is large, these subselects can be quite a bottleneck. For example: any kind of search for only visible objects needs to perform the subselect "SELECT contentobject_id FROM ezcontentobject_tree WHERE hidden = 0 AND invisible = 0" which will, in most cases, return almost all content object IDs from the table.
          Hide
          Edi Modrić (Inactive) added a comment - - edited
          Show
          Edi Modrić (Inactive) added a comment - - edited https://github.com/ezsystems/ezpublish-kernel/pull/132 ( See PR for the merge commit )
          Hide
          André Rømcke added a comment - - edited
          Show
          André Rømcke added a comment - - edited PR for the remaining failure: https://github.com/ezsystems/ezpublish-kernel/pull/485
          Show
          André Rømcke added a comment - Merged in https://github.com/ezsystems/ezpublish-kernel/commit/333f98ff66f3708e63cd3ee76d4b781787fd1792
          Hide
          Joao Pingo (Inactive) added a comment -

          Created Test Case tc-1801, tested in 5.1 and Master
          All tests passed ... QA Approved

          Show
          Joao Pingo (Inactive) added a comment - Created Test Case tc-1801, tested in 5.1 and Master All tests passed ... QA Approved

            People

            • Assignee:
              Unassigned
              Reporter:
              André Rømcke
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Time Spent - 3 days, 5 hours, 30 minutes Remaining Estimate - 2 hours
                2h
                Logged:
                Time Spent - 3 days, 5 hours, 30 minutes Remaining Estimate - 2 hours
                3d 5h 30m