Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-19324

(eZ Image Editor) The shortcuts, in the image Editor button's tooltips, are in triplicate

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Medium Medium
    • Resolution: Unresolved
    • Affects Version/s: 4.7.0-dev
    • Labels:
      None
    • Environment:

      Operating System: Internet Explorer 9.0.8112.16421
      PHP Version: 5.3.3
      Database and version: PostgreSQL (8.4.8)
      Browser (and version): Firefox 11.0

      Description

      Hi,

      When i hoove over buttons of the eZ Image Editor that have a shortcut (like the "redo" or "Undo"), we can see that the tooltips display the shortcur three times (like: Redo (ctr+y) (ctr+y) (ctr+y))

      Steps to reproduce

      Start eZ Image Editor
      Hoove over any button that have a shortcut (like the "redo" or "Undo")
      

        Issue Links

          Activity

          Hide
          Filipe Dobreira added a comment -

          To add to the description of this issue:

          The eZ Image Editor main window features a list of tools on the left, hovering over each tool will display its name and, if available, a keyboard shortcut for said tool between parenthesis. For example: *Sepia (p)*

          Currently, if you open the image editor window, close it, and reopen it, the shortcut indication is once again appended to the end of the tool's title, so for example, the Sepia example above now becomes: *Sepia (p) (p)*

          Close the window one more time, re-open it, the title is now *Sepia (p) (p) (p)*. This goes on endlessly.

          A simple proposed fix is the following:

          In ezie/design/standard/javascript/ezie/design/standard/javascript/ezie.gui.tools_window.js
          Line ~45, check that the editor hasn't already been initialized before appending to the title once again, as such:

           
                      if (config.shortcut && !initialized) {
                          item.attr("title", item.attr("title") + " (" + config.shortcut + ")");
           
          . . .
          

          Show
          Filipe Dobreira added a comment - To add to the description of this issue: The eZ Image Editor main window features a list of tools on the left, hovering over each tool will display its name and, if available, a keyboard shortcut for said tool between parenthesis. For example: * Sepia (p) * Currently, if you open the image editor window, close it, and reopen it, the shortcut indication is once again appended to the end of the tool's title, so for example, the Sepia example above now becomes: * Sepia (p) (p) * Close the window one more time, re-open it, the title is now * Sepia (p) (p) (p) *. This goes on endlessly. A simple proposed fix is the following: In ezie/design/standard/javascript/ezie/design/standard/javascript/ezie.gui.tools_window.js Line ~45, check that the editor hasn't already been initialized before appending to the title once again, as such:   if (config.shortcut && !initialized) { item.attr("title", item.attr("title") + " (" + config.shortcut + ")");   . . .

            People

            • Assignee:
              unknown
              Reporter:
              Paulo Cardiga
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated: