Details

      Description

      embed-inline (Inline checkbox ticked, not just drop-down selected) needs same treatment as embed.

      Problem found:
      1. Trying to enter a row under an embed-inline object is impossible unless a paragraph already exists beneath or between two embed-inline objects.

      2. Keyboard (arrows) navigation is not possible with embed-inline although it is with embed.

      3. Trying to embed object when embed-inline is ticked is not possible, clicking "Ok" results in the following error: el is null http://mysite.com/ezoe/relations/2853/67/auto/eZObject_2846 Line 88

      Relationship to:
      http://issues.ez.no/IssueView.php?Id=18209
      http://issues.ez.no/IssueView.php?Id=18419

      This is an ongoing issue that is frustrating clients a source of disappointment, please address this.

      Steps to reproduce

      Click embed button, browse to object and tick "Inline" checkbox.

        Issue Links

          Activity

          Brendan Pike created issue -
          André Rømcke made changes -
          Field Original Value New Value
          Workflow eZ Community Workflow [ 32775 ] eZ Engineering Scrumban Workflow [ 35635 ]
          André Rømcke made changes -
          Status Open [ 1 ] Backlog [ 10000 ]
          André Rømcke made changes -
          Status Backlog [ 10000 ] Development [ 3 ]
          Assignee unknown [ unknown ] André Rømcke [ andre.romcke@ez.no ]
          Hide
          André Rømcke added a comment - - edited

          Fixed in:
          https://github.com/ezsystems/ezpublish-legacy/commit/e1589dc13c2501f6f2de62fc3fbb2514f3ba9d77

          Fixes done in #EZP-20676 is also needed for full fix.
          Note: Could not reproduce arrow issue!

          Show
          André Rømcke added a comment - - edited Fixed in: https://github.com/ezsystems/ezpublish-legacy/commit/e1589dc13c2501f6f2de62fc3fbb2514f3ba9d77 Fixes done in # EZP-20676 is also needed for full fix. Note: Could not reproduce arrow issue!
          André Rømcke made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 2 hours [ 7200 ]
          Worklog Id 35506 [ 35506 ]
          André Rømcke made changes -
          Status Development [ 3 ] Documentation done [ 10011 ]
          Affects Version/s 5.1 [ 11280 ]
          Fix Version/s 5.2 [ 11281 ]
          André Rømcke made changes -
          Link This issue relates to EZP-20676 [ EZP-20676 ]
          André Rømcke made changes -
          Link This issue relates to EZP-18264 [ EZP-18264 ]
          André Rømcke made changes -
          Assignee André Rømcke [ andre.romcke@ez.no ]
          Status Documentation done [ 10011 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Łukasz Serwatka made changes -
          Link This issue is duplicated by EZP-21448 [ EZP-21448 ]
          Hide
          Gunnstein Lye added a comment -

          Reopen for QA

          Show
          Gunnstein Lye added a comment - Reopen for QA
          Gunnstein Lye made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Gunnstein Lye made changes -
          Status Reopened [ 4 ] InputQ [ 10001 ]
          Gunnstein Lye made changes -
          Status InputQ [ 10001 ] Development [ 3 ]
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Gunnstein Lye made changes -
          Fix Version/s 4.7 Maintenance [ 12583 ]
          Fix Version/s 5.0 Maintenance [ 11287 ]
          Fix Version/s 5.1 Maintenance [ 12301 ]
          Gunnstein Lye made changes -
          Affects Version/s 5.0 [ 10300 ]
          Affects Version/s 4.7.0 [ 11010 ]
          Gunnstein Lye made changes -
          Status Development [ 3 ] Development review [ 10006 ]
          Gunnstein Lye made changes -
          Status Development review [ 10006 ] Development Review done [ 10028 ]
          Gunnstein Lye made changes -
          Status Development Review done [ 10028 ] Documentation done [ 10011 ]
          Gunnstein Lye made changes -
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Rui Silva (Inactive) made changes -
          Status Documentation done [ 10011 ] QA [ 10008 ]
          Assignee Rui Silva [ rui.silva@ez.no ]
          Hide
          Brendan Pike added a comment -

          Thank you guys!

          Show
          Brendan Pike added a comment - Thank you guys!
          Hide
          Rui Silva (Inactive) added a comment -

          @Brendan Pike,
          regarding the problems found:

          2. Keyboard (arrows) navigation is not possible with embed-inline although it is with embed.

          Can you explain this one a little more detailed?
          I'm not sure what you mean with this one..

          Show
          Rui Silva (Inactive) added a comment - @Brendan Pike, regarding the problems found: 2. Keyboard (arrows) navigation is not possible with embed-inline although it is with embed. Can you explain this one a little more detailed? I'm not sure what you mean with this one..
          Rui Silva (Inactive) made changes -
          Flagged Impediment [ 10000 ]
          Hide
          Brendan Pike added a comment -

          Its

          @Rui Silva,

          Its been awhile now, but I think I'm referring to not been able to mouse the selector around the content with normal keyboard navigation when an embed-inline object is involved. So for example if you place an embed-inline object in the middle of a sentence you will not be able to use the left arrow to move to the start of the sentence. Similarly if there is an embed-inline object at the top / left (first item) in an XML field I don't think its possible to write a row above it. From memory I had to first disable the editor place a new line above the inline object and then re-enable the editor. This is obviously not a what a clients would expect to have to do.

          Thanks again

          Show
          Brendan Pike added a comment - Its @Rui Silva, Its been awhile now, but I think I'm referring to not been able to mouse the selector around the content with normal keyboard navigation when an embed-inline object is involved. So for example if you place an embed-inline object in the middle of a sentence you will not be able to use the left arrow to move to the start of the sentence. Similarly if there is an embed-inline object at the top / left (first item) in an XML field I don't think its possible to write a row above it. From memory I had to first disable the editor place a new line above the inline object and then re-enable the editor. This is obviously not a what a clients would expect to have to do. Thanks again
          Hide
          Rui Silva (Inactive) added a comment -

          @Brendan Pike, thank you for shedding light on this.
          I had seen this happen, but since the keyboard navigation only seems to get stuck at the element itself and not everywhere in the XML field, I wasn't sure that was what you meant.

          Show
          Rui Silva (Inactive) added a comment - @Brendan Pike, thank you for shedding light on this. I had seen this happen, but since the keyboard navigation only seems to get stuck at the element itself and not everywhere in the XML field, I wasn't sure that was what you meant.
          Rui Silva (Inactive) made changes -
          Status QA [ 10008 ] InputQ [ 10001 ]
          Assignee Rui Silva [ rui.silva@ez.no ]
          Hide
          André Rømcke added a comment -

          Guys, remember to open new issue and not reopen when a issue is already part of a release, which is the case here

          Show
          André Rømcke added a comment - Guys, remember to open new issue and not reopen when a issue is already part of a release, which is the case here
          Bertrand Dunogier made changes -
          Component/s Extensions/eZ Online Editor/Online Editor [ 10839 ]
          André Rømcke made changes -
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Gunnstein Lye made changes -
          Link This issue relates to EZP-23981 [ EZP-23981 ]
          Hide
          Gunnstein Lye added a comment -

          Closing since this is has been released. Further fixes will be done in EZP-23981.

          Show
          Gunnstein Lye added a comment - Closing since this is has been released. Further fixes will be done in EZP-23981 .
          Gunnstein Lye made changes -
          Assignee Gunnstein Lye [ gunnstein.lye@ez.no ]
          Status InputQ [ 10001 ] Closed [ 6 ]
          Resolution Incomplete [ 4 ]
          André Rømcke made changes -
          Workflow eZ Engineering Scrumban Workflow [ 35635 ] EZ* Development Workflow [ 82473 ]
          Alex Schuster made changes -
          Workflow EZ* Development Workflow [ 82473 ] EZEE Development Workflow [ 121053 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Backlog Backlog
          503d 3h 9m 1 André Rømcke 24/Jun/13 9:36 AM
          Backlog Backlog Development Development
          2s 1 André Rømcke 24/Jun/13 9:36 AM
          Development Development Documentation Review done Documentation Review done
          40s 1 André Rømcke 24/Jun/13 9:36 AM
          Documentation Review done Documentation Review done Closed Closed
          1h 39m 1 André Rømcke 24/Jun/13 11:16 AM
          Closed Closed Reopened Reopened
          525d 4h 8m 1 Gunnstein Lye 01/Dec/14 2:25 PM
          Reopened Reopened InputQ InputQ
          2m 41s 1 Gunnstein Lye 01/Dec/14 2:28 PM
          InputQ InputQ Development Development
          6s 1 Gunnstein Lye 01/Dec/14 2:28 PM
          Development Development Development Review Development Review
          1m 33s 1 Gunnstein Lye 01/Dec/14 2:29 PM
          Development Review Development Review Development Review done Development Review done
          45s 1 Gunnstein Lye 01/Dec/14 2:30 PM
          Development Review done Development Review done Documentation Review done Documentation Review done
          5s 1 Gunnstein Lye 01/Dec/14 2:30 PM
          Documentation Review done Documentation Review done QA QA
          1h 9m 1 rui.silva@ez.no 01/Dec/14 3:39 PM
          QA QA InputQ InputQ
          1d 17h 48m 1 rui.silva@ez.no 03/Dec/14 9:28 AM
          InputQ InputQ Closed Closed
          63d 6m 1 Gunnstein Lye 04/Feb/15 9:34 AM

            People

            • Assignee:
              Unassigned
              Reporter:
              Brendan Pike
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h