Uploaded image for project: 'eZ Publish / Platform'
  1. eZ Publish / Platform
  2. EZP-18259

PHP 5.4 compliance : Bad variable used in eZModuleFunctionInfo::execute(...)

    XMLWordPrintable

Details

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 4.7.0alpha1
    • 2011.10, 2011.11, 4.4.0, 4.4.1, 4.5.0, 4.6.0
    • Misc
    • None
    • Operating System: Not relevant
      PHP Version: 5.4.0RC4
      Database and version: Not relevant
      Browser (and version): Not relevant

    Description

      Hello eZ Team,

      File lib/ezutils/classes/ezmodulefunctioninfo.php
      In eZModuleFunctionInfo::execute( $functionName, $functionParameters ) :

      • line 180
        if ( !isset( $functionName['call_method'] ) )
        should be replaced by
        if ( !isset( $functionDefinition['call_method'] ) )
      • line 185
        if ( !isset( $functionName['parameters'] ) )
        should be replaced by
        if ( !isset( $functionDefinition['parameters'] ) )

      I assume that it has been working until now because it always takes the index 0 of $functionName, that is required to be a non-empty string according to the tests that are made on it earlier, so it never returns null. But this behaviour does not seem to work any more with PHP 5.4.

      I don't think that it has been reported or fixed yet as I made a search on the issues tracker and nothing is opened for this issue, and the doxygen source code still contains these few lines.

      Best regards.

      Attachments

        Activity

          People

            jv@ez.no jv@ez.no
            helloworld helloworld
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: