Details

      Description

      The geo map doesn't work in oracle db
      Everything seems normal when createing a new geo article (use for instance "klostergata 30 skien" as localtion and click search...
      However, when viewing the geo article afterwards, all you see is hudson bay
      Latitude and Longitude seems to be stored correctly in the object though.

      (fyi dfs on mysql works fine)

        Issue Links

          Activity

          Hide
          André R added a comment - - edited

          There shouldn't be anything in gmaplocation that is specific to cluster or dfs or anything like that, so issue is probably somewhere else.

          Show
          André R added a comment - - edited There shouldn't be anything in gmaplocation that is specific to cluster or dfs or anything like that, so issue is probably somewhere else.
          Hide
          Vidar Langseid added a comment -

          Maybe it shouldn't, but there is.. I also retested on mysql dfs and there it works fine...

          Show
          Vidar Langseid added a comment - Maybe it shouldn't, but there is.. I also retested on mysql dfs and there it works fine...
          Hide
          Gaetano Giunta added a comment -

          No warnings in the logs?

          Show
          Gaetano Giunta added a comment - No warnings in the logs?
          Hide
          Vidar Langseid added a comment -

          In reply to comment #053162
          Nope... so it is kinda weird..

          Show
          Vidar Langseid added a comment - In reply to comment #053162 Nope... so it is kinda weird..
          Hide
          Gaetano Giunta added a comment -

          Red herring here - gmaplocation datatype does not work with oracle fullstop. No cluster involved.

          The fault is in assuming that the .latitude and .longitude attributes of the datatype are strings using a '.' for separation of integer and decimal part (or a floating point that will be converted using a dot).

          With oracle, those values are gotten back as strings with a comma inside.

          And javascript does not work when it gets floating points that use a comma for separation.

          Easy fix: do the str_replace in the template.
          Better fix: do a typecast in the datatype and make sure there is no php.ini internationalization setting that will affect automatic conversion from php floats to string (if there is, revert to easy fix above)

          Show
          Gaetano Giunta added a comment - Red herring here - gmaplocation datatype does not work with oracle fullstop. No cluster involved. The fault is in assuming that the .latitude and .longitude attributes of the datatype are strings using a '.' for separation of integer and decimal part (or a floating point that will be converted using a dot). With oracle, those values are gotten back as strings with a comma inside. And javascript does not work when it gets floating points that use a comma for separation. Easy fix: do the str_replace in the template. Better fix: do a typecast in the datatype and make sure there is no php.ini internationalization setting that will affect automatic conversion from php floats to string (if there is, revert to easy fix above)
          Hide
          André R added a comment -

          In reply to comment #053164
          Thanks for the comments, would something like attached patch do?017683_gmap_oracle_issue.diff

          Show
          André R added a comment - In reply to comment #053164 Thanks for the comments, would something like attached patch do? 017683_gmap_oracle_issue.diff
          Hide
          Vidar Langseid added a comment -

          In reply to comment #053165
          Can you please make unified diff ( or some diff compatible with GNU patch ) ? Then we can test it

          It can be done like this for a branch AFAIK:

          /path/to/ezpublish(master)$ git co BranchToGeneratePatchFor
          /path/to/ezpublish(BranchToGeneratePatchFor)$  git format-patch master
          --no-prefix  --stdout > file.patch
          

          Show
          Vidar Langseid added a comment - In reply to comment #053165 Can you please make unified diff ( or some diff compatible with GNU patch ) ? Then we can test it It can be done like this for a branch AFAIK: /path/to/ezpublish(master)$ git co BranchToGeneratePatchFor /path/to/ezpublish(BranchToGeneratePatchFor)$ git format-patch master --no-prefix --stdout > file.patch
          Hide
          André R added a comment - - edited
          Show
          André R added a comment - - edited In reply to comment #053167 Attached. 017683_gmap_oracle_issue.diff
          Hide
          Bertrand Dunogier added a comment -

          In reply to comment #053167
          QA, were you able to test the patch ?

          Show
          Bertrand Dunogier added a comment - In reply to comment #053167 QA, were you able to test the patch ?
          Hide
          Vidar Langseid added a comment -

          In reply to comment #053169
          Yes.. seems to work
          And it still works on mysql (didn't break that)
          So I think patch is ready to go

          Show
          Vidar Langseid added a comment - In reply to comment #053169 Yes.. seems to work And it still works on mysql (didn't break that) So I think patch is ready to go
          Show
          André R added a comment - Pushed to master: https://github.com/ezsystems/ezgmaplocation/commit/d07d945c763167d264a8c70c238d9f5779b36208
          Hide
          Geir Arne Waaler added a comment -

          Reported as fixed. I move it to Closed.

          Geir Arne Waaler
          eZ Documentation

          Show
          Geir Arne Waaler added a comment - Reported as fixed. I move it to Closed. Geir Arne Waaler eZ Documentation
          Hide
          Paulo Cardiga added a comment -

          Problem remains in Oracle.
          Have this error in var/log/error.log
          [ Oct 22 2011 21:46:54 ] [192.168.2.4] eZTemplate:ezini:
          !!!No such variable 'CustomAttributeTypes' in group 'GMapItems' for block.ini

          Show
          Paulo Cardiga added a comment - Problem remains in Oracle. Have this error in var/log/error.log [ Oct 22 2011 21:46:54 ] [192.168.2.4] eZTemplate:ezini: !!!No such variable 'CustomAttributeTypes' in group 'GMapItems' for block.ini
          Hide
          André R added a comment -

          In reply to comment #053173
          That error comes from ezflow (block.ini is ezflow specific), so if that error is the reason why you reopened this issue, then I suggest we re close it and create another issue for that one.

          Show
          André R added a comment - In reply to comment #053173 That error comes from ezflow (block.ini is ezflow specific), so if that error is the reason why you reopened this issue, then I suggest we re close it and create another issue for that one.
          Hide
          Paulo Cardiga added a comment -

          In reply to comment #053174
          Ok. i just opened this new issue http://issues.ez.no/18818 with the error presented on ezflow.
          André, can you plese re-close the current issue, since o don't have a workflow option for it?
          Thanks

          Show
          Paulo Cardiga added a comment - In reply to comment #053174 Ok. i just opened this new issue http://issues.ez.no/18818 with the error presented on ezflow. André, can you plese re-close the current issue, since o don't have a workflow option for it? Thanks

            People

            • Assignee:
              André R
              Reporter:
              Vidar Langseid
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: